From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8C399D24470 for ; Fri, 11 Oct 2024 17:32:45 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1szJIv-0002JM-Aj; Fri, 11 Oct 2024 13:19:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1szJ7s-0004gj-N5 for qemu-devel@nongnu.org; Fri, 11 Oct 2024 13:08:34 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1szETY-0004dN-JN for qemu-devel@nongnu.org; Fri, 11 Oct 2024 08:10:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1728648627; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bNu6mg4j5/zNLXqNoI9txETqrFRXTZ0Avb4+PoNfWd4=; b=g442yeW3VqAhYtCXI5pH6ualIdm6DDyxMQOOYW+HmuExWKSLN2Lq2VxjkCwar39RFoAQHI k3Ww6ERIEjiQRB0UPHsL3blNM6CJKrs5OPBSvfmn+L0OeQxhi5MLqjkMrZW5QokjQeQ09+ QBAPf8S9N9w3vi0yTLWXfROtzl99uB4= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-662-yY1dhWvtOYaJQCddAxeHUQ-1; Fri, 11 Oct 2024 08:10:25 -0400 X-MC-Unique: yY1dhWvtOYaJQCddAxeHUQ-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4311cf79381so5452325e9.0 for ; Fri, 11 Oct 2024 05:10:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728648624; x=1729253424; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bNu6mg4j5/zNLXqNoI9txETqrFRXTZ0Avb4+PoNfWd4=; b=plUAJkdW9MrNF6Q7nJd1Hdt/c0W1EDrRuJ6QpYyU5W8v31UK5y+3+DitpT7aAuRgAo xjpsdNacPPAXxBMpYdQcSkkhVkrgcFswRjZ7DnS76+k9e4MEFYYMMs5a6KHnEc3kzAV5 IlDXJA5BEqvMxbyeZsuOhdlSGjwHhC8/BV+t5THARdsdBFfOVTITHaDZvqBIx5QbEcbI OqZO2xF36kx6IM7fSfdT83B7C4szZ11rn81GnKvd0SD5uDlpfCS04J87GzUI7J5ewCZ+ 3ogOB5E7WvkAIuYSxUGuJhG0xciAJvP7vh1Y/VlcSCtC3zBO+EMTrL7e9JGGoVRGfWwX Y36A== X-Forwarded-Encrypted: i=1; AJvYcCUrOs0v+kn3Akbcd48mtW71PukvwQ5o6SqxzZ6c79nBmRW0A/rIW7whEDUL0vFJmhEB5TKUnw5g48fv@nongnu.org X-Gm-Message-State: AOJu0YwwFN6v911AZ+2y9o05vquzXrYcAvs+vXYjI66cEuH/uUXKF6rd s2oBNGdxwkhuzXXuEbHw1DzZHvhApD215zQM+wJeM0aYr5V6Gb56z2iDXX1f/bcLxAcCCkN3pQI cCGjVtgeD3jFoiDLiI6qwAKOLQgxRiC3GT42y5uOGpDcWfkdGbJiR X-Received: by 2002:adf:e54e:0:b0:37d:45f0:b33 with SMTP id ffacd0b85a97d-37d55184ae1mr1695903f8f.9.1728648624432; Fri, 11 Oct 2024 05:10:24 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF11vUvlTNIiJ7gHilyIxexzddOH23KQMYbPW1OW6OU1WyrBEl2t0fGBpE9AE/bhXKkDesXyA== X-Received: by 2002:adf:e54e:0:b0:37d:45f0:b33 with SMTP id ffacd0b85a97d-37d55184ae1mr1695874f8f.9.1728648623946; Fri, 11 Oct 2024 05:10:23 -0700 (PDT) Received: from imammedo.users.ipa.redhat.com (nat-pool-brq-t.redhat.com. [213.175.37.10]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-37d4b6d0071sm3749921f8f.62.2024.10.11.05.10.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Oct 2024 05:10:23 -0700 (PDT) Date: Fri, 11 Oct 2024 14:10:20 +0200 From: Igor Mammedov To: Annie Li Cc: miguel.luis@oracle.com, qemu-devel@nongnu.org, qemu-arm@nongnu.org, dave@treblig.org, mst@redhat.com, anisinha@redhat.com, shannon.zhaosl@gmail.com, peter.maydell@linaro.org, eduardo@habkost.net, marcel.apfelbaum@gmail.com, philmd@linaro.org, wangyanan55@huawei.com, zhao1.liu@intel.com, pbonzini@redhat.com, richard.henderson@linaro.org, eblake@redhat.com, armbru@redhat.com Subject: Re: [RFC V2 PATCH 02/11] acpi: Implement control method sleep button Message-ID: <20241011141020.61425d7c@imammedo.users.ipa.redhat.com> In-Reply-To: <120fc3a4-7601-4307-800d-bfa2637df81a@oracle.com> References: <20240927183906.1248-1-annie.li@oracle.com> <20240927183906.1248-3-annie.li@oracle.com> <20241007145950.0e53023c@imammedo.users.ipa.redhat.com> <120fc3a4-7601-4307-800d-bfa2637df81a@oracle.com> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.43; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=imammedo@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.15, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Tue, 8 Oct 2024 11:22:33 -0400 Annie Li wrote: > On 10/7/2024 8:59 AM, Igor Mammedov wrote: > > On Fri, 27 Sep 2024 14:38:57 -0400 > > Annie Li wrote: > > > >> The control method sleep button is added, as well as its GPE event > >> handler. > >> > >> Co-developed-by: Miguel Luis > >> Signed-off-by: Annie Li > >> --- > >> hw/acpi/control_method_device.c | 54 +++++++++++++++++++++++++ > >> hw/acpi/meson.build | 1 + > >> include/hw/acpi/control_method_device.h | 25 ++++++++++++ > >> 3 files changed, 80 insertions(+) > >> > >> diff --git a/hw/acpi/control_method_device.c b/hw/acpi/control_method_device.c > >> new file mode 100644 > >> index 0000000000..f52c190352 > >> --- /dev/null > >> +++ b/hw/acpi/control_method_device.c > >> @@ -0,0 +1,54 @@ > >> +/* > >> + * Control method devices > >> + * > >> + * Copyright (c) 2023 Oracle and/or its affiliates. > >> + * > >> + * > >> + * Authors: > >> + * Annie Li > >> + * > >> + * > >> + * This work is licensed under the terms of the GNU GPL, version 2 or later. > >> + * See the COPYING file in the top-level directory. > > replace it with SPDX-License-Identifier like it's done elsewhere > Nod > > > >> + * > >> + */ > >> + > >> +#include "qemu/osdep.h" > >> +#include "hw/acpi/control_method_device.h" > >> +#include "hw/mem/nvdimm.h" > >> + > >> +void acpi_dsdt_add_sleep_button(Aml *scope) > >> +{ > >> + Aml *dev = aml_device("\\_SB."ACPI_SLEEP_BUTTON_DEVICE); > > drop "\\_SB." here and below as well, > Make sense here since the scope parameter is "_SB", but for the "_SB" > in acpi_dsdt_add_sleep_gpe_event_handler where the scope parameter is > "_GPE", I suppose "\\_SB." is necessary. Check the spec onhow name resolution in ACPI works. Anyways you likely won't have dedicated acpi_dsdt_add_sleep_gpe_event_handler(), on respin > > > >> + aml_append(dev, aml_name_decl("_HID", aml_eisaid("PNP0C0E"))); > >> + Aml *pkg = aml_package(2); > >> + aml_append(pkg, aml_int(0x01)); > >> + aml_append(pkg, aml_int(0x04)); > >> + aml_append(dev, aml_name_decl("_PRW", pkg)); > >> + aml_append(dev, aml_operation_region("\\Boo", AML_SYSTEM_IO, > > use some sensible name for opreg > will do > >> + aml_int(0x201), 0x1)); > >> + Aml *field = aml_field("\\Boo", AML_BYTE_ACC, AML_NOLOCK, > >> + AML_WRITE_AS_ZEROS); > >> + aml_append(field, aml_named_field("SBP", 1)); > >> + aml_append(field, aml_named_field("SBW", 1)); > >> + aml_append(dev, field); > >> + aml_append(scope, dev); > >> +} > > also above and below lacks any documentation, > > add comments for relevant spec references, like we do with other ACPI > > functions. Also perhaps, it's out of order, reviewer has not clue > > where from above registers come and how it is supposed to work. > > > > if you invented those registers, there should be a preceding doc patch > > that documents them. > > > > Suggest to reorder after patch that implements above registers in hw, > > and also comment here where to look for them. > > Thanks for the feedback. > > Thanks > Annie > > >> + > >> +void acpi_dsdt_add_sleep_gpe_event_handler(Aml *scope) > >> +{ > >> + Aml *method = aml_method("_L07", 0, AML_NOTSERIALIZED); > >> + Aml *condition = aml_if(aml_name("\\_SB.SLPB.SBP")); > >> + aml_append(condition, aml_store(aml_int(1), aml_name("\\_SB.SLPB.SBP"))); > >> + aml_append(condition, > >> + aml_notify(aml_name("\\_SB."ACPI_SLEEP_BUTTON_DEVICE), > >> + aml_int(0x80))); > >> + aml_append(method, condition); > >> + condition = aml_if(aml_name("\\_SB.SLPB.SBW")); > >> + aml_append(condition, aml_store(aml_int(1), aml_name("\\_SB.SLPB.SBW"))); > >> + aml_append(condition, > >> + aml_notify(aml_name("\\_SB."ACPI_SLEEP_BUTTON_DEVICE), > >> + aml_int(0x2))); > >> + aml_append(method, condition); > >> + aml_append(scope, method); > >> +} > >> diff --git a/hw/acpi/meson.build b/hw/acpi/meson.build > >> index fa5c07db90..0b4f1b432d 100644 > >> --- a/hw/acpi/meson.build > >> +++ b/hw/acpi/meson.build > >> @@ -17,6 +17,7 @@ acpi_ss.add(when: 'CONFIG_ACPI_PCI', if_true: files('pci.c')) > >> acpi_ss.add(when: 'CONFIG_ACPI_CXL', if_true: files('cxl.c'), if_false: files('cxl-stub.c')) > >> acpi_ss.add(when: 'CONFIG_ACPI_VMGENID', if_true: files('vmgenid.c')) > >> acpi_ss.add(when: 'CONFIG_ACPI_HW_REDUCED', if_true: files('generic_event_device.c')) > >> +acpi_ss.add(when: 'CONFIG_ACPI_HW_REDUCED', if_true: files('control_method_device.c')) > >> acpi_ss.add(when: 'CONFIG_ACPI_HMAT', if_true: files('hmat.c')) > >> acpi_ss.add(when: 'CONFIG_ACPI_APEI', if_true: files('ghes.c'), if_false: files('ghes-stub.c')) > >> acpi_ss.add(when: 'CONFIG_ACPI_PIIX4', if_true: files('piix4.c')) > >> diff --git a/include/hw/acpi/control_method_device.h b/include/hw/acpi/control_method_device.h > >> new file mode 100644 > >> index 0000000000..87f8d6fd59 > >> --- /dev/null > >> +++ b/include/hw/acpi/control_method_device.h > >> @@ -0,0 +1,25 @@ > >> +/* > >> + * Control method devices > >> + * > >> + * Copyright (c) 2023 Oracle and/or its affiliates. > >> + * > >> + * > >> + * Authors: > >> + * Annie Li > >> + * > >> + * > >> + * This work is licensed under the terms of the GNU GPL, version 2 or later. > >> + * See the COPYING file in the top-level directory. > >> + * > >> + */ > >> + > >> + > >> +#ifndef HW_ACPI_CONTROL_METHOD_DEVICE_H > >> +#define HW_ACPI_CONTROL_NETHOD_DEVICE_H > >> + > >> +#define ACPI_SLEEP_BUTTON_DEVICE "SLPB" > >> + > >> +void acpi_dsdt_add_sleep_button(Aml *scope); > >> +void acpi_dsdt_add_sleep_gpe_event_handler(Aml *scope); > >> + > >> +#endif