From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: Thomas Huth <thuth@redhat.com>,
"Dr . David Alan Gilbert" <dave@treblig.org>
Subject: [PULL 07/27] linux-user/vm86: Fix compilation with Clang
Date: Sun, 13 Oct 2024 15:12:15 -0700 [thread overview]
Message-ID: <20241013221235.1585193-8-richard.henderson@linaro.org> (raw)
In-Reply-To: <20241013221235.1585193-1-richard.henderson@linaro.org>
From: Thomas Huth <thuth@redhat.com>
Since commit 95b9c27c81 ("linux-user: Remove unused handle_vm86_fault")
a bunch of other "static inline" function are now unused, too. Clang
warns about such unused "static inline" functions in .c files, so the
build currently breaks when compiling with "--enable-werror". Remove
the unused functions to get it going again.
Fixes: 95b9c27c81 ("linux-user: Remove unused handle_vm86_fault")
Signed-off-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Dr. David Alan Gilbert <dave@treblig.org>
Message-ID: <20241011161845.417342-1-thuth@redhat.com>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
linux-user/vm86.c | 65 -----------------------------------------------
1 file changed, 65 deletions(-)
diff --git a/linux-user/vm86.c b/linux-user/vm86.c
index 31a2d707cf..5091d53fb8 100644
--- a/linux-user/vm86.c
+++ b/linux-user/vm86.c
@@ -47,30 +47,6 @@ static inline void vm_putw(CPUX86State *env, uint32_t segptr,
cpu_stw_data(env, segptr + (reg16 & 0xffff), val);
}
-static inline void vm_putl(CPUX86State *env, uint32_t segptr,
- unsigned int reg16, unsigned int val)
-{
- cpu_stl_data(env, segptr + (reg16 & 0xffff), val);
-}
-
-static inline unsigned int vm_getb(CPUX86State *env,
- uint32_t segptr, unsigned int reg16)
-{
- return cpu_ldub_data(env, segptr + (reg16 & 0xffff));
-}
-
-static inline unsigned int vm_getw(CPUX86State *env,
- uint32_t segptr, unsigned int reg16)
-{
- return cpu_lduw_data(env, segptr + (reg16 & 0xffff));
-}
-
-static inline unsigned int vm_getl(CPUX86State *env,
- uint32_t segptr, unsigned int reg16)
-{
- return cpu_ldl_data(env, segptr + (reg16 & 0xffff));
-}
-
void save_v86_state(CPUX86State *env)
{
CPUState *cs = env_cpu(env);
@@ -131,19 +107,6 @@ static inline void return_to_32bit(CPUX86State *env, int retval)
env->regs[R_EAX] = retval;
}
-static inline int set_IF(CPUX86State *env)
-{
- CPUState *cs = env_cpu(env);
- TaskState *ts = get_task_state(cs);
-
- ts->v86flags |= VIF_MASK;
- if (ts->v86flags & VIP_MASK) {
- return_to_32bit(env, TARGET_VM86_STI);
- return 1;
- }
- return 0;
-}
-
static inline void clear_IF(CPUX86State *env)
{
CPUState *cs = env_cpu(env);
@@ -162,34 +125,6 @@ static inline void clear_AC(CPUX86State *env)
env->eflags &= ~AC_MASK;
}
-static inline int set_vflags_long(unsigned long eflags, CPUX86State *env)
-{
- CPUState *cs = env_cpu(env);
- TaskState *ts = get_task_state(cs);
-
- set_flags(ts->v86flags, eflags, ts->v86mask);
- set_flags(env->eflags, eflags, SAFE_MASK);
- if (eflags & IF_MASK)
- return set_IF(env);
- else
- clear_IF(env);
- return 0;
-}
-
-static inline int set_vflags_short(unsigned short flags, CPUX86State *env)
-{
- CPUState *cs = env_cpu(env);
- TaskState *ts = get_task_state(cs);
-
- set_flags(ts->v86flags, flags, ts->v86mask & 0xffff);
- set_flags(env->eflags, flags, SAFE_MASK);
- if (flags & IF_MASK)
- return set_IF(env);
- else
- clear_IF(env);
- return 0;
-}
-
static inline unsigned int get_vflags(CPUX86State *env)
{
CPUState *cs = env_cpu(env);
--
2.43.0
next prev parent reply other threads:[~2024-10-13 22:16 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-13 22:12 [PULL 00/27] tcg + linux patch queue Richard Henderson
2024-10-13 22:12 ` [PULL 01/27] tcg: remove singlestep_enabled from DisasContextBase Richard Henderson
2024-10-13 22:12 ` [PULL 02/27] include/exec: Introduce env_cpu_const() Richard Henderson
2024-10-13 22:12 ` [PULL 03/27] linux-user/i386: Emulate orig_ax Richard Henderson
2024-10-13 22:12 ` [PULL 04/27] target/i386/gdbstub: Factor out gdb_get_reg() and gdb_write_reg() Richard Henderson
2024-10-13 22:12 ` [PULL 05/27] target/i386/gdbstub: Expose orig_ax Richard Henderson
2024-10-13 22:12 ` [PULL 06/27] tests/tcg: Run test-proc-mappings.py on i386 Richard Henderson
2024-10-13 22:12 ` Richard Henderson [this message]
2024-10-13 22:12 ` [PULL 08/27] accel/tcg: Assert noreturn from write-only page for atomics Richard Henderson
2024-10-13 22:12 ` [PULL 09/27] include/exec/memop: Move get_alignment_bits from tcg.h Richard Henderson
2024-10-13 22:12 ` [PULL 10/27] include/exec/memop: Rename get_alignment_bits Richard Henderson
2024-10-13 22:12 ` [PULL 11/27] include/exec/memop: Introduce memop_atomicity_bits Richard Henderson
2024-10-13 22:12 ` [PULL 12/27] accel/tcg: Add TCGCPUOps.tlb_fill_align Richard Henderson
2024-10-13 22:12 ` [PULL 13/27] accel/tcg: Use the alignment test in tlb_fill_align Richard Henderson
2024-10-13 22:12 ` [PULL 14/27] target/hppa: Add MemOp argument to hppa_get_physical_address Richard Henderson
2024-10-13 22:12 ` [PULL 15/27] target/hppa: Perform access rights before protection id check Richard Henderson
2024-10-13 22:12 ` [PULL 16/27] target/hppa: Fix priority of T, D, and B page faults Richard Henderson
2024-10-13 22:12 ` [PULL 17/27] target/hppa: Handle alignment faults in hppa_get_physical_address Richard Henderson
2024-10-13 22:12 ` [PULL 18/27] target/hppa: Implement TCGCPUOps.tlb_fill_align Richard Henderson
2024-10-13 22:12 ` [PULL 19/27] target/arm: Pass MemOp to get_phys_addr Richard Henderson
2024-10-13 22:12 ` [PULL 20/27] target/arm: Pass MemOp to get_phys_addr_with_space_nogpc Richard Henderson
2024-10-13 22:12 ` [PULL 21/27] target/arm: Pass MemOp to get_phys_addr_gpc Richard Henderson
2024-10-13 22:12 ` [PULL 22/27] target/arm: Pass MemOp to get_phys_addr_nogpc Richard Henderson
2024-10-13 22:12 ` [PULL 23/27] target/arm: Pass MemOp through get_phys_addr_twostage Richard Henderson
2024-10-13 22:12 ` [PULL 24/27] target/arm: Pass MemOp to get_phys_addr_lpae Richard Henderson
2024-10-13 22:12 ` [PULL 25/27] target/arm: Move device detection earlier in get_phys_addr_lpae Richard Henderson
2024-10-13 22:12 ` [PULL 26/27] target/arm: Implement TCGCPUOps.tlb_fill_align Richard Henderson
2024-10-13 22:12 ` [PULL 27/27] target/arm: Fix alignment fault priority in get_phys_addr_lpae Richard Henderson
2024-10-14 12:03 ` [PULL 00/27] tcg + linux patch queue Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241013221235.1585193-8-richard.henderson@linaro.org \
--to=richard.henderson@linaro.org \
--cc=dave@treblig.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).