Re: [PATCH v1] hw/cxl: Fix background completion percentage calculation

[Jonathan Cameron via <qemu-devel@nongnu.org>]

On Sat, 14 Sep 2024 16:50:21 +0530
<ajay.opensrc@micron.com> wrote:

> From: Ajay Joshi <ajayjoshi@micron.com>
> 
> The current completion percentage calculation
> does not account for the relative time since
> the start of the background activity, this leads
> to showing incorrect start percentage vs what has
> actually been completed.
> 
> This patch calculates the percentage based on the actual
> elapsed time since the start of the operation.
> 
> Fixes: 221d2cfbdb ("hw/cxl/mbox: Add support for background operations")
> 
I'll include this is a fixes series I send to Michael + list later
today.  However for future reference, no line break between tags in
the tags block as it breaks some scripting.  I'll tidy that up.
Note I think you missed Michael's point about this on the first version.
+ as a second version, even without changes, this should have been v2.


Thanks

Jonathan

> Signed-off-by: Ajay Joshi <ajay.opensrc@micron.com>
> Reviewed-by: Davidlohr Bueso <dave@stgolabs.net>
> Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> ---
>  hw/cxl/cxl-mailbox-utils.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/hw/cxl/cxl-mailbox-utils.c b/hw/cxl/cxl-mailbox-utils.c
> index c2ed251bb3..873d60c069 100644
> --- a/hw/cxl/cxl-mailbox-utils.c
> +++ b/hw/cxl/cxl-mailbox-utils.c
> @@ -2708,7 +2708,8 @@ static void bg_timercb(void *opaque)
>          }
>      } else {
>          /* estimate only */
> -        cci->bg.complete_pct = 100 * now / total_time;
> +        cci->bg.complete_pct =
> +            100 * (now - cci->bg.starttime) / cci->bg.runtime;
>          timer_mod(cci->bg.timer, now + CXL_MBOX_BG_UPDATE_FREQ);
>      }
>