qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: julia <midnight@trainwit.ch>
To: qemu-devel@nongnu.org
Cc: julia <midnight@trainwit.ch>, Keith Busch <kbusch@kernel.org>,
	Klaus Jensen <its@irrelevant.dk>,
	Jesper Devantier <foss@defmacro.it>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
	qemu-block@nongnu.org (open list:nvme)
Subject: [PATCH] hw/nvme: Remove references to PCI IRQ "pulsing" when asserting
Date: Tue, 15 Oct 2024 21:33:48 +1100	[thread overview]
Message-ID: <20241015103351.688803-1-midnight@trainwit.ch> (raw)

The NVMe subsystem logs "pulsing IRQ pin" when it is asserting the PCI(e)
IRQ. This is confusing as it implies a short pulse, not the level-triggered
interrupts PCI(e) uses.

Also remove the pci_irq_pulse() function marked with FIXME as it is no
longer used by any calls.

Signed-off-by: julia <midnight@trainwit.ch>
---
 hw/nvme/trace-events |  2 +-
 include/hw/pci/pci.h | 10 ----------
 2 files changed, 1 insertion(+), 11 deletions(-)

diff --git a/hw/nvme/trace-events b/hw/nvme/trace-events
index 3a67680c6a..5d96d622ff 100644
--- a/hw/nvme/trace-events
+++ b/hw/nvme/trace-events
@@ -1,6 +1,6 @@
 # successful events
 pci_nvme_irq_msix(uint32_t vector) "raising MSI-X IRQ vector %u"
-pci_nvme_irq_pin(void) "pulsing IRQ pin"
+pci_nvme_irq_pin(void) "asserting IRQ pin"
 pci_nvme_irq_masked(void) "IRQ is masked"
 pci_nvme_dma_read(uint64_t prp1, uint64_t prp2) "DMA read, prp1=0x%"PRIx64" prp2=0x%"PRIx64""
 pci_nvme_dbbuf_config(uint64_t dbs_addr, uint64_t eis_addr) "dbs_addr=0x%"PRIx64" eis_addr=0x%"PRIx64""
diff --git a/include/hw/pci/pci.h b/include/hw/pci/pci.h
index eb26cac810..863aab0b80 100644
--- a/include/hw/pci/pci.h
+++ b/include/hw/pci/pci.h
@@ -667,16 +667,6 @@ static inline void pci_irq_deassert(PCIDevice *pci_dev)
     pci_set_irq(pci_dev, 0);
 }
 
-/*
- * FIXME: PCI does not work this way.
- * All the callers to this method should be fixed.
- */
-static inline void pci_irq_pulse(PCIDevice *pci_dev)
-{
-    pci_irq_assert(pci_dev);
-    pci_irq_deassert(pci_dev);
-}
-
 MSIMessage pci_get_msi_message(PCIDevice *dev, int vector);
 void pci_set_power(PCIDevice *pci_dev, bool state);
 
-- 
2.44.1



             reply	other threads:[~2024-10-15 12:40 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-15 10:33 julia [this message]
2024-10-18  4:01 ` [PATCH] hw/nvme: Remove references to PCI IRQ "pulsing" when asserting Julia
2024-11-01 11:40   ` Klaus Jensen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241015103351.688803-1-midnight@trainwit.ch \
    --to=midnight@trainwit.ch \
    --cc=foss@defmacro.it \
    --cc=its@irrelevant.dk \
    --cc=kbusch@kernel.org \
    --cc=marcel.apfelbaum@gmail.com \
    --cc=mst@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).