[PATCH] hw/acpi/acpi_dev_interface: Clean up remains of madt_cpu

[PATCH] hw/acpi/acpi_dev_interface: Clean up remains of madt_cpu

[Gustavo Romero]

Commit c461f3e382 ("Remove now unused madt_cpu virtual method") removed
madt_cpu virtual method but didn't remove the text about it in the
header file. Thus, remove it now.

Signed-off-by: Gustavo Romero <gustavo.romero@linaro.org>
---
 include/hw/acpi/acpi_dev_interface.h | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/include/hw/acpi/acpi_dev_interface.h b/include/hw/acpi/acpi_dev_interface.h
index 68d9d15f50..2f5ab5c1b1 100644
--- a/include/hw/acpi/acpi_dev_interface.h
+++ b/include/hw/acpi/acpi_dev_interface.h
@@ -34,10 +34,6 @@ void acpi_send_event(DeviceState *dev, AcpiEventStatusBits event);
  * ospm_status: returns status of ACPI device objects, reported
  *              via _OST method if device supports it.
  * send_event: inject a specified event into guest
- * madt_cpu: fills @entry with Interrupt Controller Structure
- *           for CPU indexed by @uid in @apic_ids array,
- *           returned structure types are:
- *           0 - Local APIC, 9 - Local x2APIC, 0xB - GICC
  *
  * Interface is designed for providing unified interface
  * to generic ACPI functionality that could be used without
-- 
2.34.1

Re: [PATCH] hw/acpi/acpi_dev_interface: Clean up remains of madt_cpu

[Philippe Mathieu-Daudé]

On 15/10/24 11:09, Gustavo Romero wrote:
> Commit c461f3e382 ("Remove now unused madt_cpu virtual method") removed
> madt_cpu virtual method but didn't remove the text about it in the
> header file. Thus, remove it now.
> 
> Signed-off-by: Gustavo Romero <gustavo.romero@linaro.org>
> ---
>   include/hw/acpi/acpi_dev_interface.h | 4 ----
>   1 file changed, 4 deletions(-)
> 
> diff --git a/include/hw/acpi/acpi_dev_interface.h b/include/hw/acpi/acpi_dev_interface.h
> index 68d9d15f50..2f5ab5c1b1 100644
> --- a/include/hw/acpi/acpi_dev_interface.h
> +++ b/include/hw/acpi/acpi_dev_interface.h
> @@ -34,10 +34,6 @@ void acpi_send_event(DeviceState *dev, AcpiEventStatusBits event);
>    * ospm_status: returns status of ACPI device objects, reported
>    *              via _OST method if device supports it.
>    * send_event: inject a specified event into guest
> - * madt_cpu: fills @entry with Interrupt Controller Structure
> - *           for CPU indexed by @uid in @apic_ids array,
> - *           returned structure types are:
> - *           0 - Local APIC, 9 - Local x2APIC, 0xB - GICC
>    *
>    * Interface is designed for providing unified interface
>    * to generic ACPI functionality that could be used without

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

Re: [PATCH] hw/acpi/acpi_dev_interface: Clean up remains of madt_cpu

[Bernhard Beschow]

Am 15. Oktober 2024 14:09:57 UTC schrieb Gustavo Romero <gustavo.romero@linaro.org>:
>Commit c461f3e382 ("Remove now unused madt_cpu virtual method") removed
>madt_cpu virtual method but didn't remove the text about it in the
>header file. Thus, remove it now.
>
>Signed-off-by: Gustavo Romero <gustavo.romero@linaro.org>
>---
> include/hw/acpi/acpi_dev_interface.h | 4 ----
> 1 file changed, 4 deletions(-)
>
>diff --git a/include/hw/acpi/acpi_dev_interface.h b/include/hw/acpi/acpi_dev_interface.h
>index 68d9d15f50..2f5ab5c1b1 100644
>--- a/include/hw/acpi/acpi_dev_interface.h
>+++ b/include/hw/acpi/acpi_dev_interface.h
>@@ -34,10 +34,6 @@ void acpi_send_event(DeviceState *dev, AcpiEventStatusBits event);
>  * ospm_status: returns status of ACPI device objects, reported
>  *              via _OST method if device supports it.
>  * send_event: inject a specified event into guest
>- * madt_cpu: fills @entry with Interrupt Controller Structure
>- *           for CPU indexed by @uid in @apic_ids array,
>- *           returned structure types are:
>- *           0 - Local APIC, 9 - Local x2APIC, 0xB - GICC
>  *
>  * Interface is designed for providing unified interface
>  * to generic ACPI functionality that could be used without

Reviewed-by: Bernhard Beschow <shentey@gmail.com>