qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: jrossi@linux.ibm.com
To: qemu-devel@nongnu.org, qemu-s390x@nongnu.org, thuth@redhat.com
Cc: frankja@linux.ibm.com, jrossi@linux.ibm.com
Subject: [PATCH v4 19/19] tests/qtest: Add s390x boot order tests to cdrom-test.c
Date: Wed, 16 Oct 2024 21:47:48 -0400	[thread overview]
Message-ID: <20241017014748.829029-20-jrossi@linux.ibm.com> (raw)
In-Reply-To: <20241017014748.829029-1-jrossi@linux.ibm.com>

From: Jared Rossi <jrossi@linux.ibm.com>

Add two new qtests to verify that a valid IPL device can successfully boot after
failed IPL attempts from one or more invalid devices.

cdrom-test/as-fallback-device: Defines the primary boot target as a device that
is invalid for IPL and a second boot target that is valid for IPL. Ensures that
the valid device will be selected after the initial failed IPL.

cdrom-test/as-last-option: Defines the maximum number of boot devices (8)
where only the final entry in the boot order is valid. Ensures that a valid
device will be selected even after multiple failed IPL attempts from both
virtio-blk and virtio-scsi device types.

Signed-off-by: Jared Rossi <jrossi@linux.ibm.com>
---
 tests/qtest/cdrom-test.c | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/tests/qtest/cdrom-test.c b/tests/qtest/cdrom-test.c
index 9d72b24e4b..c86725a511 100644
--- a/tests/qtest/cdrom-test.c
+++ b/tests/qtest/cdrom-test.c
@@ -213,6 +213,30 @@ static void add_s390x_tests(void)
                         "-drive driver=null-co,read-zeroes=on,if=none,id=d1 "
                         "-device virtio-blk,drive=d2,bootindex=1 "
                         "-drive if=none,id=d2,media=cdrom,file=", test_cdboot);
+    qtest_add_data_func("cdrom/boot/as-fallback-device",
+                        "-device virtio-serial -device virtio-scsi "
+                        "-device virtio-blk,drive=d1,bootindex=1 "
+                        "-drive driver=null-co,read-zeroes=on,if=none,id=d1 "
+                        "-device virtio-blk,drive=d2,bootindex=2 "
+                        "-drive if=none,id=d2,media=cdrom,file=", test_cdboot);
+    qtest_add_data_func("cdrom/boot/as-last-option",
+                        "-device virtio-serial -device virtio-scsi "
+                        "-device virtio-blk,drive=d1,bootindex=1 "
+                        "-drive driver=null-co,read-zeroes=on,if=none,id=d1 "
+                        "-device virtio-blk,drive=d2,bootindex=2 "
+                        "-drive driver=null-co,read-zeroes=on,if=none,id=d2 "
+                        "-device virtio-blk,drive=d3,bootindex=3 "
+                        "-drive driver=null-co,read-zeroes=on,if=none,id=d3 "
+                        "-device scsi-hd,drive=d4,bootindex=4 "
+                        "-drive driver=null-co,read-zeroes=on,if=none,id=d4 "
+                        "-device scsi-hd,drive=d5,bootindex=5 "
+                        "-drive driver=null-co,read-zeroes=on,if=none,id=d5 "
+                        "-device virtio-blk,drive=d6,bootindex=6 "
+                        "-drive driver=null-co,read-zeroes=on,if=none,id=d6 "
+                        "-device scsi-hd,drive=d7,bootindex=7 "
+                        "-drive driver=null-co,read-zeroes=on,if=none,id=d7 "
+                        "-device scsi-cd,drive=d8,bootindex=8 "
+                        "-drive if=none,id=d8,media=cdrom,file=", test_cdboot);
     if (qtest_has_device("x-terminal3270")) {
         qtest_add_data_func("cdrom/boot/without-bootindex",
                             "-device virtio-scsi -device virtio-serial "
-- 
2.45.1



  parent reply	other threads:[~2024-10-17  1:51 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-17  1:47 [PATCH v4 00/19] s390x: Add Full Boot Order Support jrossi
2024-10-17  1:47 ` [PATCH v4 01/19] hw/s390x/ipl: Provide more memory to the s390-ccw.img firmware jrossi
2024-10-17  1:47 ` [PATCH v4 02/19] pc-bios/s390-ccw: Use the libc from SLOF and remove sclp prints jrossi
2024-10-17  1:47 ` [PATCH v4 03/19] pc-bios/s390-ccw: Link the netboot code into the main s390-ccw.img binary jrossi
2024-10-17  1:47 ` [PATCH v4 04/19] hw/s390x: Remove the possibility to load the s390-netboot.img binary jrossi
2024-10-17  1:47 ` [PATCH v4 05/19] pc-bios/s390-ccw: Merge netboot.mak into the main Makefile jrossi
2024-10-17  1:47 ` [PATCH v4 06/19] docs/system/s390x/bootdevices: Update the documentation about network booting jrossi
2024-10-17  1:47 ` [PATCH v4 07/19] pc-bios/s390-ccw: Remove panics from ISO IPL path jrossi
2024-10-17  7:38   ` Thomas Huth
2024-10-17  1:47 ` [PATCH v4 08/19] pc-bios/s390-ccw: Remove panics from ECKD " jrossi
2024-10-17  8:01   ` Thomas Huth
2024-10-17  1:47 ` [PATCH v4 09/19] pc-bios/s390-ccw: Remove panics from SCSI " jrossi
2024-10-17 10:28   ` Thomas Huth
2024-10-17  1:47 ` [PATCH v4 10/19] pc-bios/s390-ccw: Remove panics from DASD " jrossi
2024-10-17  1:47 ` [PATCH v4 11/19] pc-bios/s390-ccw: Remove panics from Netboot " jrossi
2024-10-17 10:33   ` Thomas Huth
2024-10-17  1:47 ` [PATCH v4 12/19] pc-bios/s390-ccw: Enable failed IPL to return after error jrossi
2024-10-17  1:47 ` [PATCH v4 13/19] include/hw/s390x: Add include files for common IPL structs jrossi
2024-10-17  1:47 ` [PATCH v4 14/19] s390x: Add individual loadparm assignment to CCW device jrossi
2024-10-17  1:47 ` [PATCH v4 15/19] hw/s390x: Build an IPLB for each boot device jrossi
2024-10-17  1:47 ` [PATCH v4 16/19] s390x: Rebuild IPLB for SCSI device directly from DIAG308 jrossi
2024-10-17 11:27   ` Thomas Huth
2024-10-17  1:47 ` [PATCH v4 17/19] pc-bios/s390x: Enable multi-device boot loop jrossi
2024-10-17 11:41   ` Thomas Huth
2024-10-17  1:47 ` [PATCH v4 18/19] docs/system: Update documentation for s390x IPL jrossi
2024-10-17  1:47 ` jrossi [this message]
2024-10-17 11:51   ` [PATCH v4 19/19] tests/qtest: Add s390x boot order tests to cdrom-test.c Thomas Huth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241017014748.829029-20-jrossi@linux.ibm.com \
    --to=jrossi@linux.ibm.com \
    --cc=frankja@linux.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-s390x@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).