qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Daniel P. Berrangé" <berrange@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Markus Armbruster" <armbru@redhat.com>,
	"Daniel P. Berrangé" <berrange@redhat.com>
Subject: [PATCH v2 01/31] include: move include/qapi/qmp/ to include/qobject/
Date: Thu, 17 Oct 2024 12:33:13 +0100	[thread overview]
Message-ID: <20241017113344.883424-2-berrange@redhat.com> (raw)
In-Reply-To: <20241017113344.883424-1-berrange@redhat.com>

The general expectation is that header files should follow the same
file/path naming scheme as the corresponding source file. There are
various historical exceptions to this practice in QEMU, with one of
the most notable being the include/qapi/qmp/ directory. Most of the
headers there correspond to source files in qobject/.

This patch corrects that inconsistency by creating include/qobject/.
The only outlier is include/qapi/qmp/dispatch.h which gets renamed
to include/qapi/qmp-registry.h.

To allow the code to continue to build, symlinks are temporarily
added in $QEMU/qapi/qmp/ to point to the new location. They will
be removed in a later commit.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 MAINTAINERS                                     | 5 +----
 include/qapi/{qmp/dispatch.h => qmp-registry.h} | 0
 include/{qapi/qmp => qobject}/json-parser.h     | 0
 include/{qapi/qmp => qobject}/json-writer.h     | 0
 include/{qapi/qmp => qobject}/qbool.h           | 0
 include/{qapi/qmp => qobject}/qdict.h           | 0
 include/{qapi/qmp => qobject}/qjson.h           | 0
 include/{qapi/qmp => qobject}/qlist.h           | 0
 include/{qapi/qmp => qobject}/qlit.h            | 0
 include/{qapi/qmp => qobject}/qnull.h           | 0
 include/{qapi/qmp => qobject}/qnum.h            | 0
 include/{qapi/qmp => qobject}/qobject.h         | 0
 include/{qapi/qmp => qobject}/qstring.h         | 0
 qapi/qmp/dispatch.h                             | 1 +
 qapi/qmp/json-parser.h                          | 1 +
 qapi/qmp/json-writer.h                          | 1 +
 qapi/qmp/qbool.h                                | 1 +
 qapi/qmp/qdict.h                                | 1 +
 qapi/qmp/qjson.h                                | 1 +
 qapi/qmp/qlist.h                                | 1 +
 qapi/qmp/qlit.h                                 | 1 +
 qapi/qmp/qnull.h                                | 1 +
 qapi/qmp/qnum.h                                 | 1 +
 qapi/qmp/qobject.h                              | 1 +
 qapi/qmp/qstring.h                              | 1 +
 25 files changed, 13 insertions(+), 4 deletions(-)
 rename include/qapi/{qmp/dispatch.h => qmp-registry.h} (100%)
 rename include/{qapi/qmp => qobject}/json-parser.h (100%)
 rename include/{qapi/qmp => qobject}/json-writer.h (100%)
 rename include/{qapi/qmp => qobject}/qbool.h (100%)
 rename include/{qapi/qmp => qobject}/qdict.h (100%)
 rename include/{qapi/qmp => qobject}/qjson.h (100%)
 rename include/{qapi/qmp => qobject}/qlist.h (100%)
 rename include/{qapi/qmp => qobject}/qlit.h (100%)
 rename include/{qapi/qmp => qobject}/qnull.h (100%)
 rename include/{qapi/qmp => qobject}/qnum.h (100%)
 rename include/{qapi/qmp => qobject}/qobject.h (100%)
 rename include/{qapi/qmp => qobject}/qstring.h (100%)
 create mode 120000 qapi/qmp/dispatch.h
 create mode 120000 qapi/qmp/json-parser.h
 create mode 120000 qapi/qmp/json-writer.h
 create mode 120000 qapi/qmp/qbool.h
 create mode 120000 qapi/qmp/qdict.h
 create mode 120000 qapi/qmp/qjson.h
 create mode 120000 qapi/qmp/qlist.h
 create mode 120000 qapi/qmp/qlit.h
 create mode 120000 qapi/qmp/qnull.h
 create mode 120000 qapi/qmp/qnum.h
 create mode 120000 qapi/qmp/qobject.h
 create mode 120000 qapi/qmp/qstring.h

diff --git a/MAINTAINERS b/MAINTAINERS
index c21d6a2f9e..656482b2a4 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -3153,8 +3153,6 @@ S: Supported
 F: qapi/
 X: qapi/*.json
 F: include/qapi/
-X: include/qapi/qmp/
-F: include/qapi/qmp/dispatch.h
 F: tests/qapi-schema/
 F: tests/unit/test-*-visitor.c
 F: tests/unit/test-qapi-*.c
@@ -3178,8 +3176,7 @@ QObject
 M: Markus Armbruster <armbru@redhat.com>
 S: Supported
 F: qobject/
-F: include/qapi/qmp/
-X: include/qapi/qmp/dispatch.h
+F: include/qobject/
 F: scripts/coccinelle/qobject.cocci
 F: tests/unit/check-qdict.c
 F: tests/unit/check-qjson.c
diff --git a/include/qapi/qmp/dispatch.h b/include/qapi/qmp-registry.h
similarity index 100%
rename from include/qapi/qmp/dispatch.h
rename to include/qapi/qmp-registry.h
diff --git a/include/qapi/qmp/json-parser.h b/include/qobject/json-parser.h
similarity index 100%
rename from include/qapi/qmp/json-parser.h
rename to include/qobject/json-parser.h
diff --git a/include/qapi/qmp/json-writer.h b/include/qobject/json-writer.h
similarity index 100%
rename from include/qapi/qmp/json-writer.h
rename to include/qobject/json-writer.h
diff --git a/include/qapi/qmp/qbool.h b/include/qobject/qbool.h
similarity index 100%
rename from include/qapi/qmp/qbool.h
rename to include/qobject/qbool.h
diff --git a/include/qapi/qmp/qdict.h b/include/qobject/qdict.h
similarity index 100%
rename from include/qapi/qmp/qdict.h
rename to include/qobject/qdict.h
diff --git a/include/qapi/qmp/qjson.h b/include/qobject/qjson.h
similarity index 100%
rename from include/qapi/qmp/qjson.h
rename to include/qobject/qjson.h
diff --git a/include/qapi/qmp/qlist.h b/include/qobject/qlist.h
similarity index 100%
rename from include/qapi/qmp/qlist.h
rename to include/qobject/qlist.h
diff --git a/include/qapi/qmp/qlit.h b/include/qobject/qlit.h
similarity index 100%
rename from include/qapi/qmp/qlit.h
rename to include/qobject/qlit.h
diff --git a/include/qapi/qmp/qnull.h b/include/qobject/qnull.h
similarity index 100%
rename from include/qapi/qmp/qnull.h
rename to include/qobject/qnull.h
diff --git a/include/qapi/qmp/qnum.h b/include/qobject/qnum.h
similarity index 100%
rename from include/qapi/qmp/qnum.h
rename to include/qobject/qnum.h
diff --git a/include/qapi/qmp/qobject.h b/include/qobject/qobject.h
similarity index 100%
rename from include/qapi/qmp/qobject.h
rename to include/qobject/qobject.h
diff --git a/include/qapi/qmp/qstring.h b/include/qobject/qstring.h
similarity index 100%
rename from include/qapi/qmp/qstring.h
rename to include/qobject/qstring.h
diff --git a/qapi/qmp/dispatch.h b/qapi/qmp/dispatch.h
new file mode 120000
index 0000000000..ffedc3971d
--- /dev/null
+++ b/qapi/qmp/dispatch.h
@@ -0,0 +1 @@
+../../include/qapi/qmp-registry.h
\ No newline at end of file
diff --git a/qapi/qmp/json-parser.h b/qapi/qmp/json-parser.h
new file mode 120000
index 0000000000..059cb73fa8
--- /dev/null
+++ b/qapi/qmp/json-parser.h
@@ -0,0 +1 @@
+../../include/qobject/json-parser.h
\ No newline at end of file
diff --git a/qapi/qmp/json-writer.h b/qapi/qmp/json-writer.h
new file mode 120000
index 0000000000..3e952f4c97
--- /dev/null
+++ b/qapi/qmp/json-writer.h
@@ -0,0 +1 @@
+../../include/qobject/json-writer.h
\ No newline at end of file
diff --git a/qapi/qmp/qbool.h b/qapi/qmp/qbool.h
new file mode 120000
index 0000000000..443c881cf8
--- /dev/null
+++ b/qapi/qmp/qbool.h
@@ -0,0 +1 @@
+../../include/qobject/qbool.h
\ No newline at end of file
diff --git a/qapi/qmp/qdict.h b/qapi/qmp/qdict.h
new file mode 120000
index 0000000000..8183614eae
--- /dev/null
+++ b/qapi/qmp/qdict.h
@@ -0,0 +1 @@
+../../include/qobject/qdict.h
\ No newline at end of file
diff --git a/qapi/qmp/qjson.h b/qapi/qmp/qjson.h
new file mode 120000
index 0000000000..85b48c5bfd
--- /dev/null
+++ b/qapi/qmp/qjson.h
@@ -0,0 +1 @@
+../../include/qobject/qjson.h
\ No newline at end of file
diff --git a/qapi/qmp/qlist.h b/qapi/qmp/qlist.h
new file mode 120000
index 0000000000..d40db0a12b
--- /dev/null
+++ b/qapi/qmp/qlist.h
@@ -0,0 +1 @@
+../../include/qobject/qlist.h
\ No newline at end of file
diff --git a/qapi/qmp/qlit.h b/qapi/qmp/qlit.h
new file mode 120000
index 0000000000..5dd5ac8ccb
--- /dev/null
+++ b/qapi/qmp/qlit.h
@@ -0,0 +1 @@
+../../include/qobject/qlit.h
\ No newline at end of file
diff --git a/qapi/qmp/qnull.h b/qapi/qmp/qnull.h
new file mode 120000
index 0000000000..944769d44b
--- /dev/null
+++ b/qapi/qmp/qnull.h
@@ -0,0 +1 @@
+../../include/qobject/qnull.h
\ No newline at end of file
diff --git a/qapi/qmp/qnum.h b/qapi/qmp/qnum.h
new file mode 120000
index 0000000000..8038e2f4d6
--- /dev/null
+++ b/qapi/qmp/qnum.h
@@ -0,0 +1 @@
+../../include/qobject/qnum.h
\ No newline at end of file
diff --git a/qapi/qmp/qobject.h b/qapi/qmp/qobject.h
new file mode 120000
index 0000000000..89d9118cfd
--- /dev/null
+++ b/qapi/qmp/qobject.h
@@ -0,0 +1 @@
+../../include/qobject/qobject.h
\ No newline at end of file
diff --git a/qapi/qmp/qstring.h b/qapi/qmp/qstring.h
new file mode 120000
index 0000000000..24f48de18a
--- /dev/null
+++ b/qapi/qmp/qstring.h
@@ -0,0 +1 @@
+../../include/qobject/qstring.h
\ No newline at end of file
-- 
2.46.0



  reply	other threads:[~2024-10-17 11:35 UTC|newest]

Thread overview: 68+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-17 11:33 [PATCH v2 00/31] include: move include/qapi/qmp/ to include/qobject/ Daniel P. Berrangé
2024-10-17 11:33 ` Daniel P. Berrangé [this message]
2024-10-18  9:47   ` [PATCH v2 01/31] " Zhao Liu
2024-11-14 14:30   ` Markus Armbruster
2024-11-15 17:51     ` Daniel P. Berrangé
2024-10-17 11:33 ` [PATCH v2 02/31] audio: adapt to new import path for qobject data type headers Daniel P. Berrangé
2024-10-18  9:48   ` Zhao Liu
2024-10-17 11:33 ` [PATCH v2 03/31] authz: " Daniel P. Berrangé
2024-10-18  9:48   ` Zhao Liu
2024-10-17 11:33 ` [PATCH v2 04/31] block: " Daniel P. Berrangé
2024-10-18  9:51   ` Zhao Liu
2024-10-17 11:33 ` [PATCH v2 05/31] backends: " Daniel P. Berrangé
2024-10-18  9:51   ` Zhao Liu
2024-10-17 11:33 ` [PATCH v2 06/31] chardev: " Daniel P. Berrangé
2024-10-18  9:52   ` Zhao Liu
2024-10-17 11:33 ` [PATCH v2 07/31] docs: " Daniel P. Berrangé
2024-10-18  9:52   ` Zhao Liu
2024-10-17 11:33 ` [PATCH v2 08/31] dump: " Daniel P. Berrangé
2024-10-18  9:53   ` Zhao Liu
2024-10-17 11:33 ` [PATCH v2 09/31] hw: " Daniel P. Berrangé
2024-10-17 20:38   ` Halil Pasic
2024-10-18  9:54   ` Zhao Liu
2024-10-17 11:33 ` [PATCH v2 10/31] include: " Daniel P. Berrangé
2024-10-18  9:55   ` Zhao Liu
2024-10-17 11:33 ` [PATCH v2 11/31] migration: " Daniel P. Berrangé
2024-10-18  9:56   ` Zhao Liu
2024-10-17 11:33 ` [PATCH v2 12/31] monitor: " Daniel P. Berrangé
2024-10-18  9:57   ` Zhao Liu
2024-10-17 11:33 ` [PATCH v2 13/31] net: " Daniel P. Berrangé
2024-10-18  9:57   ` Zhao Liu
2024-10-17 11:33 ` [PATCH v2 14/31] qapi: " Daniel P. Berrangé
2024-10-18  9:58   ` Zhao Liu
2024-10-17 11:33 ` [PATCH v2 15/31] qga: " Daniel P. Berrangé
2024-10-18  9:59   ` Zhao Liu
2024-10-17 11:33 ` [PATCH v2 16/31] qobject: " Daniel P. Berrangé
2024-10-18 10:01   ` Zhao Liu
2024-10-17 11:33 ` [PATCH v2 17/31] qom: " Daniel P. Berrangé
2024-10-18 10:01   ` Zhao Liu
2024-10-17 11:33 ` [PATCH v2 18/31] replay: " Daniel P. Berrangé
2024-10-18 10:02   ` Zhao Liu
2024-10-17 11:33 ` [PATCH v2 19/31] scripts: " Daniel P. Berrangé
2024-10-18 10:02   ` Zhao Liu
2024-10-17 11:33 ` [PATCH v2 20/31] scsi: " Daniel P. Berrangé
2024-10-18 10:02   ` Zhao Liu
2024-10-17 11:33 ` [PATCH v2 21/31] stats: " Daniel P. Berrangé
2024-10-18 10:03   ` Zhao Liu
2024-10-17 11:33 ` [PATCH v2 22/31] stubs: " Daniel P. Berrangé
2024-10-18 10:03   ` Zhao Liu
2024-10-17 11:33 ` [PATCH v2 23/31] system: " Daniel P. Berrangé
2024-10-18 10:06   ` Zhao Liu
2024-10-18 10:02     ` Daniel P. Berrangé
2024-10-17 11:33 ` [PATCH v2 24/31] target: " Daniel P. Berrangé
2024-10-18 10:07   ` Zhao Liu
2024-10-17 11:33 ` [PATCH v2 25/31] tests: " Daniel P. Berrangé
2024-10-18 10:12   ` Zhao Liu
2024-10-17 11:33 ` [PATCH v2 26/31] trace: " Daniel P. Berrangé
2024-10-18 10:12   ` Zhao Liu
2024-10-17 11:33 ` [PATCH v2 27/31] ui: " Daniel P. Berrangé
2024-10-18 10:12   ` Zhao Liu
2024-10-17 11:33 ` [PATCH v2 28/31] util: " Daniel P. Berrangé
2024-10-18 10:13   ` Zhao Liu
2024-10-17 11:33 ` [PATCH v2 29/31] qapi: remove header file compatibility symlinks Daniel P. Berrangé
2024-10-18 10:13   ` Zhao Liu
2024-10-17 11:33 ` [PATCH v2 30/31] qga: remove unused qerror.h header Daniel P. Berrangé
2024-10-18 10:14   ` Zhao Liu
2024-10-17 11:33 ` [PATCH v2 31/31] system: " Daniel P. Berrangé
2024-10-18 10:17   ` Zhao Liu
2024-10-18 13:34     ` Daniel P. Berrangé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241017113344.883424-2-berrange@redhat.com \
    --to=berrange@redhat.com \
    --cc=armbru@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).