* [PATCH] configure: Replace literally printed '\n' with newline
@ 2024-10-18 12:05 Kevin Wolf
2024-10-18 12:08 ` Daniel P. Berrangé
2024-10-21 12:17 ` Paolo Bonzini
0 siblings, 2 replies; 3+ messages in thread
From: Kevin Wolf @ 2024-10-18 12:05 UTC (permalink / raw)
To: qemu-devel; +Cc: kwolf, manos.pitsidianakis, pbonzini, qemu-trivial
The idea here was to leave an empty line before the message, but by
default, echo prints '\n' literally instead of interpreting it. Use a
separate echo without parameter instead like in other places in the
script.
Fixes: 6fdc5bc173188f5e4942616b16d589500b874a15
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
configure | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/configure b/configure
index 72d1a94225..0918147156 100755
--- a/configure
+++ b/configure
@@ -2062,7 +2062,8 @@ chmod +x config.status
rm -r "$TMPDIR1"
if test "$rust" != disabled; then
- echo '\nINFO: Rust bindings generation with `bindgen` might fail in some cases where'
+ echo
+ echo 'INFO: Rust bindings generation with `bindgen` might fail in some cases where'
echo 'the detected `libclang` does not match the expected `clang` version/target. In'
echo 'this case you must pass the path to `clang` and `libclang` to your build'
echo 'command invocation using the environment variables CLANG_PATH and LIBCLANG_PATH'
--
2.47.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] configure: Replace literally printed '\n' with newline
2024-10-18 12:05 [PATCH] configure: Replace literally printed '\n' with newline Kevin Wolf
@ 2024-10-18 12:08 ` Daniel P. Berrangé
2024-10-21 12:17 ` Paolo Bonzini
1 sibling, 0 replies; 3+ messages in thread
From: Daniel P. Berrangé @ 2024-10-18 12:08 UTC (permalink / raw)
To: Kevin Wolf; +Cc: qemu-devel, manos.pitsidianakis, pbonzini, qemu-trivial
On Fri, Oct 18, 2024 at 02:05:57PM +0200, Kevin Wolf wrote:
> The idea here was to leave an empty line before the message, but by
> default, echo prints '\n' literally instead of interpreting it. Use a
> separate echo without parameter instead like in other places in the
> script.
>
> Fixes: 6fdc5bc173188f5e4942616b16d589500b874a15
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> configure | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] configure: Replace literally printed '\n' with newline
2024-10-18 12:05 [PATCH] configure: Replace literally printed '\n' with newline Kevin Wolf
2024-10-18 12:08 ` Daniel P. Berrangé
@ 2024-10-21 12:17 ` Paolo Bonzini
1 sibling, 0 replies; 3+ messages in thread
From: Paolo Bonzini @ 2024-10-21 12:17 UTC (permalink / raw)
To: Kevin Wolf; +Cc: qemu-devel, manos.pitsidianakis, pbonzini, qemu-trivial
Queued, thanks.
Paolo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-10-21 12:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-18 12:05 [PATCH] configure: Replace literally printed '\n' with newline Kevin Wolf
2024-10-18 12:08 ` Daniel P. Berrangé
2024-10-21 12:17 ` Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).