qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org,
	"Daniel P. Berrangé" <berrange@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: [PULL 8/9] hw/intc/openpic: Improve errors for out of bounds property values
Date: Fri, 18 Oct 2024 15:28:23 +0200	[thread overview]
Message-ID: <20241018132824.3379780-9-armbru@redhat.com> (raw)
In-Reply-To: <20241018132824.3379780-1-armbru@redhat.com>

The error message doesn't matter much, as the "openpic" device isn't
user-creatable.  But it's the last use of
QERR_PROPERTY_VALUE_OUT_OF_RANGE, which has to go.  Change the message
just like the previous commit did for x86 CPUs.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-ID: <20241010150144.986655-7-armbru@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 hw/intc/openpic.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/hw/intc/openpic.c b/hw/intc/openpic.c
index 32bd880dfa..cd3d87768e 100644
--- a/hw/intc/openpic.c
+++ b/hw/intc/openpic.c
@@ -41,7 +41,6 @@
 #include "hw/pci/msi.h"
 #include "qapi/error.h"
 #include "qemu/bitops.h"
-#include "qapi/qmp/qerror.h"
 #include "qemu/module.h"
 #include "qemu/timer.h"
 #include "qemu/error-report.h"
@@ -1535,9 +1534,7 @@ static void openpic_realize(DeviceState *dev, Error **errp)
     };
 
     if (opp->nb_cpus > MAX_CPU) {
-        error_setg(errp, QERR_PROPERTY_VALUE_OUT_OF_RANGE,
-                   TYPE_OPENPIC, "nb_cpus", (uint64_t)opp->nb_cpus,
-                   (uint64_t)0, (uint64_t)MAX_CPU);
+        error_setg(errp, "property 'nb_cpus' can be at most %d", MAX_CPU);
         return;
     }
 
-- 
2.46.0



  parent reply	other threads:[~2024-10-18 13:30 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-18 13:28 [PULL 0/9] Error reporting patches for 2024-10-18 Markus Armbruster
2024-10-18 13:28 ` [PULL 1/9] qga/qapi-schema: Drop obsolete note on "unsupported" errors Markus Armbruster
2024-10-18 13:28 ` [PULL 2/9] qga: Improve error for guest-set-user-password parameter @crypted Markus Armbruster
2024-10-18 13:28 ` [PULL 3/9] error: Drop superfluous #include "qapi/qmp/qerror.h" Markus Armbruster
2024-10-18 13:28 ` [PULL 4/9] block: Improve errors about block sizes Markus Armbruster
2024-10-18 13:28 ` [PULL 5/9] block: Adjust check_block_size() signature Markus Armbruster
2024-10-18 13:28 ` [PULL 6/9] target/i386/cpu: Avoid mixing signed and unsigned in property setters Markus Armbruster
2024-10-18 13:28 ` [PULL 7/9] target/i386/cpu: Improve errors for out of bounds property values Markus Armbruster
2024-10-18 13:28 ` Markus Armbruster [this message]
2024-10-18 13:28 ` [PULL 9/9] qerror: QERR_PROPERTY_VALUE_OUT_OF_RANGE is no longer used, drop Markus Armbruster
2024-10-21 11:36 ` [PULL 0/9] Error reporting patches for 2024-10-18 Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241018132824.3379780-9-armbru@redhat.com \
    --to=armbru@redhat.com \
    --cc=berrange@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).