qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: qemu-stable@nongnu.org
Subject: [PATCH] stubs: remove stubs/qdev.c
Date: Fri, 18 Oct 2024 16:33:33 +0200	[thread overview]
Message-ID: <20241018143334.949045-1-pbonzini@redhat.com> (raw)

qapi_event_send_device_deleted is always included (together
with the rest of QAPI) in libqemuutil.a, so it is unnecessary
to include a stub for it.

This avoids a duplicate symbol in libqemuutil.a, which in
principle could result in missing events on the monitor.

Cc: qemu-stable@nongnu.org
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 stubs/qdev.c      | 22 ----------------------
 stubs/meson.build |  1 -
 2 files changed, 23 deletions(-)
 delete mode 100644 stubs/qdev.c

diff --git a/stubs/qdev.c b/stubs/qdev.c
deleted file mode 100644
index 7e957b3e524..00000000000
--- a/stubs/qdev.c
+++ /dev/null
@@ -1,22 +0,0 @@
-/*
- * QOM stubs
- *
- * Copyright (c) 2021 Red Hat, Inc.
- *
- * Author:
- *   Philippe Mathieu-Daudé <philmd@redhat.com>
- *
- * SPDX-License-Identifier: GPL-2.0-or-later
- *
- * This work is licensed under the terms of the GNU GPL, version 2 or later.
- * See the COPYING file in the top-level directory.
- */
-
-#include "qemu/osdep.h"
-#include "qapi/qapi-events-qdev.h"
-
-void qapi_event_send_device_deleted(const char *device,
-                                    const char *path)
-{
-    /* Nothing to do. */
-}
diff --git a/stubs/meson.build b/stubs/meson.build
index 772a3e817df..64b7263dde2 100644
--- a/stubs/meson.build
+++ b/stubs/meson.build
@@ -55,7 +55,6 @@ endif
 if have_user
   # Symbols that are used by hw/core.
   stub_ss.add(files('cpu-synchronize-state.c'))
-  stub_ss.add(files('qdev.c'))
 endif
 
 if have_system
-- 
2.46.2



             reply	other threads:[~2024-10-18 14:34 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-18 14:33 Paolo Bonzini [this message]
2024-10-18 16:44 ` [PATCH] stubs: remove stubs/qdev.c Zhao Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241018143334.949045-1-pbonzini@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-stable@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).