qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>,
	Junjie Mao <junjie.mao@hotmail.com>
Subject: [PATCH 09/13] rust: clean up define_property macro
Date: Fri, 18 Oct 2024 16:43:01 +0200	[thread overview]
Message-ID: <20241018144306.954716-10-pbonzini@redhat.com> (raw)
In-Reply-To: <20241018144306.954716-1-pbonzini@redhat.com>

Use the "struct update" syntax to initialize most of the fields to zero,
and simplify the handmade type-checking of $name.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 rust/qemu-api/src/device_class.rs | 29 ++++++-----------------------
 1 file changed, 6 insertions(+), 23 deletions(-)

diff --git a/rust/qemu-api/src/device_class.rs b/rust/qemu-api/src/device_class.rs
index 2219b9f73d0..5aba426d243 100644
--- a/rust/qemu-api/src/device_class.rs
+++ b/rust/qemu-api/src/device_class.rs
@@ -29,44 +29,27 @@ macro_rules! device_class_init {
 macro_rules! define_property {
     ($name:expr, $state:ty, $field:expr, $prop:expr, $type:expr, default = $defval:expr$(,)*) => {
         $crate::bindings::Property {
-            name: {
-                #[used]
-                static _TEMP: &::core::ffi::CStr = $name;
-                _TEMP.as_ptr()
-            },
+            // use associated function syntax for type checking
+            name: ::core::ffi::CStr::as_ptr($name),
             info: $prop,
             offset: ::core::mem::offset_of!($state, $field)
                 .try_into()
                 .expect("Could not fit offset value to type"),
-            bitnr: 0,
-            bitmask: 0,
             set_default: true,
             defval: $crate::bindings::Property__bindgen_ty_1 { u: $defval.into() },
-            arrayoffset: 0,
-            arrayinfo: ::core::ptr::null(),
-            arrayfieldsize: 0,
-            link_type: ::core::ptr::null(),
+            ..unsafe { ::core::mem::MaybeUninit::<$crate::bindings::Property>::zeroed().assume_init() }
         }
     };
     ($name:expr, $state:ty, $field:expr, $prop:expr, $type:expr$(,)*) => {
         $crate::bindings::Property {
-            name: {
-                #[used]
-                static _TEMP: &::core::ffi::CStr = $name;
-                _TEMP.as_ptr()
-            },
+            // use associated function syntax for type checking
+            name: ::core::ffi::CStr::as_ptr($name),
             info: $prop,
             offset: ::core::mem::offset_of!($state, $field)
                 .try_into()
                 .expect("Could not fit offset value to type"),
-            bitnr: 0,
-            bitmask: 0,
             set_default: false,
-            defval: $crate::bindings::Property__bindgen_ty_1 { i: 0 },
-            arrayoffset: 0,
-            arrayinfo: ::core::ptr::null(),
-            arrayfieldsize: 0,
-            link_type: ::core::ptr::null(),
+            ..unsafe { ::core::mem::MaybeUninit::<$crate::bindings::Property>::zeroed().assume_init() }
         }
     };
 }
-- 
2.46.2



  parent reply	other threads:[~2024-10-18 14:45 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-18 14:42 [PATCH 00/13] rust: miscellaneous cleanups + QOM integration tests Paolo Bonzini
2024-10-18 14:42 ` [PATCH 01/13] meson: import rust module into a global variable Paolo Bonzini
2024-10-18 14:42 ` [PATCH 02/13] meson: remove repeated search for rust_root_crate.sh Paolo Bonzini
2024-10-18 14:42 ` [PATCH 03/13] meson: pass rustc_args when building all crates Paolo Bonzini
2024-10-18 14:42 ` [PATCH 04/13] rust: do not use --no-size_t-is-usize Paolo Bonzini
2024-10-18 14:42 ` [PATCH 05/13] rust: remove uses of #[no_mangle] Paolo Bonzini
2024-10-21 10:07   ` Junjie Mao
2024-10-18 14:42 ` [PATCH 06/13] rust: remove unused macro module_init! Paolo Bonzini
2024-10-21 10:16   ` Junjie Mao
2024-10-21 10:46     ` Paolo Bonzini
2024-10-18 14:42 ` [PATCH 07/13] rust: modernize #[derive(Object)] for ELF platforms Paolo Bonzini
2024-10-21 10:23   ` Junjie Mao
2024-10-18 14:43 ` [PATCH 08/13] rust: build integration test for the qemu_api crate Paolo Bonzini
2024-10-21 10:28   ` Junjie Mao
2024-10-21 10:47     ` Paolo Bonzini
2024-10-21 11:28   ` Junjie Mao
2024-10-21 11:43     ` Paolo Bonzini
2024-10-21 11:51       ` Junjie Mao
2024-10-21 13:02         ` Paolo Bonzini
2024-10-18 14:43 ` Paolo Bonzini [this message]
2024-10-21 10:35   ` [PATCH 09/13] rust: clean up define_property macro Junjie Mao
2024-10-21 10:44     ` Paolo Bonzini
2024-10-21 11:37       ` Junjie Mao
2024-10-18 14:43 ` [PATCH 10/13] qdev: make properties array "const" Paolo Bonzini
2024-10-18 14:43 ` [PATCH 11/13] rust: make properties array immutable Paolo Bonzini
2024-10-21 11:42   ` Junjie Mao
2024-10-18 14:43 ` [PATCH 12/13] rust: provide safe wrapper for MaybeUninit::zeroed() Paolo Bonzini
2024-10-21 11:46   ` Junjie Mao
2024-10-18 14:43 ` [PATCH 13/13] rust: do not use TYPE_CHARDEV unnecessarily Paolo Bonzini
2024-10-21 11:48   ` Junjie Mao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241018144306.954716-10-pbonzini@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=junjie.mao@hotmail.com \
    --cc=manos.pitsidianakis@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).