qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Daniel P. Berrangé" <berrange@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"Daniel P. Berrangé" <berrange@redhat.com>
Subject: [PATCH 4/6] ui/vnc: don't check for SSF after SASL authentication on UNIX sockets
Date: Mon, 21 Oct 2024 17:19:55 +0100	[thread overview]
Message-ID: <20241021161957.1431919-5-berrange@redhat.com> (raw)
In-Reply-To: <20241021161957.1431919-1-berrange@redhat.com>

Although we avoid requesting an SSF when querying SASL mechanisms for a
UNIX socket client, we still mistakenly checked for availability of an
SSF once the SASL auth process is complete.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 ui/vnc-auth-sasl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ui/vnc-auth-sasl.c b/ui/vnc-auth-sasl.c
index 43515447fb..25f6b4b776 100644
--- a/ui/vnc-auth-sasl.c
+++ b/ui/vnc-auth-sasl.c
@@ -628,7 +628,7 @@ void start_auth_sasl(VncState *vs)
             goto authabort;
         }
     } else {
-        vs->sasl.wantSSF = 1;
+        vs->sasl.wantSSF = !vnc_socket_is_unix(vs->sioc);
     }
 
     memset (&secprops, 0, sizeof secprops);
-- 
2.46.0



  parent reply	other threads:[~2024-10-21 16:21 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-21 16:19 [PATCH 0/6] ui: various improvements to VNC SASL code Daniel P. Berrangé
2024-10-21 16:19 ` [PATCH 1/6] ui/vnc: don't return an empty SASL mechlist to the client Daniel P. Berrangé
2024-10-21 16:19 ` [PATCH 2/6] ui/vnc: don't raise error formatting socket address for non-inet Daniel P. Berrangé
2024-10-21 16:19 ` [PATCH 3/6] ui/vnc: fix skipping SASL SSF on UNIX sockets Daniel P. Berrangé
2024-10-21 16:19 ` Daniel P. Berrangé [this message]
2024-10-21 16:19 ` [PATCH 5/6] ui: fix handling of NULL SASL server data Daniel P. Berrangé
2024-10-21 16:19 ` [PATCH 6/6] ui: validate NUL byte padding in SASL client data more strictly Daniel P. Berrangé
2024-10-21 17:53 ` [PATCH 0/6] ui: various improvements to VNC SASL code Marc-André Lureau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241021161957.1431919-5-berrange@redhat.com \
    --to=berrange@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).