qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>,
	Junjie Mao <junjie.mao@hotmail.com>
Subject: [PATCH v2 00/13] rust: miscellaneous cleanups + QOM integration tests
Date: Mon, 21 Oct 2024 18:35:25 +0200	[thread overview]
Message-ID: <20241021163538.136941-1-pbonzini@redhat.com> (raw)

This series integrates some of the observations from the MSRV patches at
https://lore.kernel.org/qemu-devel/20241015131735.518771-1-pbonzini@redhat.com/.

The main changes here are two: first, build an integration test that
actually tries to create a QOM object that is defined by Rust code;
second, make the properties array immutable so that declare_properties!
is enforced to use only const-friendly constructs.  These are patches
6-11; the others consist of small cleanups.

Hidden in here is actually a C patch (#10) which makes the
bindgen-generated prototypes use "*const" instead of "*mut".

Tested with Rust nightly and (together with more patches from the
RFC), with Rust 1.63.0.

Unlike the MSRV patches, this should be ready for inclusion; the
changes should be mostly uncontroversial.

Paolo

Based-on: <20241021163449.136804-1-pbonzini@redhat.com>


v1->v2:
- add comment justifying -D unsafe_op_in_unsafe_fn
- use module_init! macro from #[derive(Object)]
- use test() instead of rust.test() for integration test
- pass rustfmt and clippy


Paolo Bonzini (13):
  meson: import rust module into a global variable
  meson: remove repeated search for rust_root_crate.sh
  meson: pass rustc_args when building all crates
  rust: do not use --no-size_t-is-usize
  rust: remove uses of #[no_mangle]
  rust: modernize link_section usage for ELF platforms
  rust: build integration test for the qemu_api crate
  rust: cleanup module_init!, use it from #[derive(Object)]
  rust: clean up define_property macro
  qdev: make properties array "const"
  rust: make properties array immutable
  rust: provide safe wrapper for MaybeUninit::zeroed()
  rust: do not use TYPE_CHARDEV unnecessarily

 meson.build                            | 33 +++++++---
 include/hw/qdev-core.h                 |  4 +-
 include/hw/qdev-properties.h           |  4 +-
 hw/core/qdev-properties.c              | 26 ++++----
 system/qdev-monitor.c                  |  2 +-
 rust/hw/char/pl011/src/device.rs       |  7 +--
 rust/hw/char/pl011/src/device_class.rs | 10 ++--
 rust/hw/char/pl011/src/memory_ops.rs   | 13 ++--
 rust/qemu-api-macros/meson.build       |  2 +-
 rust/qemu-api-macros/src/lib.rs        | 30 ++--------
 rust/qemu-api/meson.build              | 29 +++++++--
 rust/qemu-api/src/definitions.rs       | 67 ++++++++++-----------
 rust/qemu-api/src/device_class.rs      | 83 +++++++-------------------
 rust/qemu-api/src/lib.rs               |  4 +-
 rust/qemu-api/src/tests.rs             | 49 ---------------
 rust/qemu-api/src/zeroable.rs          | 23 +++++++
 rust/qemu-api/tests/tests.rs           | 78 ++++++++++++++++++++++++
 17 files changed, 240 insertions(+), 224 deletions(-)
 delete mode 100644 rust/qemu-api/src/tests.rs
 create mode 100644 rust/qemu-api/src/zeroable.rs
 create mode 100644 rust/qemu-api/tests/tests.rs

-- 
2.46.2



             reply	other threads:[~2024-10-21 16:35 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-21 16:35 Paolo Bonzini [this message]
2024-10-21 16:35 ` [PATCH v2 01/13] meson: import rust module into a global variable Paolo Bonzini
2024-10-23 10:29   ` Manos Pitsidianakis
2024-10-21 16:35 ` [PATCH v2 02/13] meson: remove repeated search for rust_root_crate.sh Paolo Bonzini
2024-10-21 16:35 ` [PATCH v2 03/13] meson: pass rustc_args when building all crates Paolo Bonzini
2024-10-22  2:35   ` Junjie Mao
2024-10-22 15:35   ` Zhao Liu
2024-10-21 16:35 ` [PATCH v2 04/13] rust: do not use --no-size_t-is-usize Paolo Bonzini
2024-10-22  2:38   ` Junjie Mao
2024-10-23  4:24   ` Zhao Liu
2024-10-21 16:35 ` [PATCH v2 05/13] rust: remove uses of #[no_mangle] Paolo Bonzini
2024-10-23 10:48   ` Paolo Bonzini
2024-10-23 14:06     ` Zhao Liu
2024-10-23 14:13   ` Zhao Liu
2024-10-21 16:35 ` [PATCH v2 06/13] rust: modernize link_section usage for ELF platforms Paolo Bonzini
2024-10-23 15:31   ` Zhao Liu
2024-10-24  6:04     ` Paolo Bonzini
2024-10-21 16:35 ` [PATCH v2 07/13] rust: build integration test for the qemu_api crate Paolo Bonzini
2024-10-22  1:52   ` Junjie Mao
2024-10-24 17:23   ` Zhao Liu
2024-10-21 16:35 ` [PATCH v2 08/13] rust: cleanup module_init!, use it from #[derive(Object)] Paolo Bonzini
2024-10-22  2:02   ` Junjie Mao
2024-10-22  5:16     ` Paolo Bonzini
2024-10-22  6:00       ` Junjie Mao
2024-10-22  7:20         ` Paolo Bonzini
2024-10-22 20:32         ` Kevin Wolf
2024-10-23  6:46           ` Junjie Mao
2024-10-25  8:59   ` Zhao Liu
2024-10-25  9:12     ` Paolo Bonzini
2024-10-21 16:35 ` [PATCH v2 09/13] rust: clean up define_property macro Paolo Bonzini
2024-10-22 19:46   ` Kevin Wolf
2024-10-23  7:10     ` Paolo Bonzini
2024-10-23 10:38   ` Manos Pitsidianakis
2024-10-23 11:23     ` Paolo Bonzini
2024-10-25  9:17   ` Zhao Liu
2024-10-21 16:35 ` [PATCH v2 10/13] qdev: make properties array "const" Paolo Bonzini
2024-10-22  4:31   ` Philippe Mathieu-Daudé
2024-10-22  5:23     ` Paolo Bonzini
2024-10-22 21:43       ` Philippe Mathieu-Daudé
2024-10-23  7:06         ` Paolo Bonzini
2024-10-21 16:35 ` [PATCH v2 11/13] rust: make properties array immutable Paolo Bonzini
2024-10-25 11:27   ` Zhao Liu
2024-10-21 16:35 ` [PATCH v2 12/13] rust: provide safe wrapper for MaybeUninit::zeroed() Paolo Bonzini
2024-10-25 10:10   ` Zhao Liu
2024-10-21 16:35 ` [PATCH v2 13/13] rust: do not use TYPE_CHARDEV unnecessarily Paolo Bonzini
2024-10-25 10:05   ` Zhao Liu
2024-10-22 20:46 ` [PATCH v2 00/13] rust: miscellaneous cleanups + QOM integration tests Kevin Wolf
2024-10-23  7:14   ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241021163538.136941-1-pbonzini@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=junjie.mao@hotmail.com \
    --cc=manos.pitsidianakis@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).