qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Akihiko Odaki <akihiko.odaki@daynix.com>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
	"Alex Williamson" <alex.williamson@redhat.com>,
	"Cédric Le Goater" <clg@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Daniel P. Berrangé" <berrange@redhat.com>,
	"Eduardo Habkost" <eduardo@habkost.net>,
	"Sriram Yagnaraman" <sriram.yagnaraman@ericsson.com>,
	"Jason Wang" <jasowang@redhat.com>,
	"Keith Busch" <kbusch@kernel.org>,
	"Klaus Jensen" <its@irrelevant.dk>,
	"Markus Armbruster" <armbru@redhat.com>,
	"Matthew Rosato" <mjrosato@linux.ibm.com>,
	"Eric Farman" <farman@linux.ibm.com>,
	"Harsh Prateek Bora" <harshpb@linux.ibm.com>,
	"Shivaprasad G Bhat" <sbhat@linux.ibm.com>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org,
	 Akihiko Odaki <akihiko.odaki@daynix.com>
Subject: [PATCH v17 02/14] hw/ppc/spapr_pci: Do not create DT for disabled PCI device
Date: Tue, 22 Oct 2024 17:36:39 +0900	[thread overview]
Message-ID: <20241022-reuse-v17-2-bd7c133237e4@daynix.com> (raw)
In-Reply-To: <20241022-reuse-v17-0-bd7c133237e4@daynix.com>

Disabled means it is a disabled SR-IOV VF and hidden from the guest.
Do not create DT when starting the system and also keep the disabled PCI
device not linked to DRC, which generates DT in case of hotplug.

Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
---
 hw/ppc/spapr_pci.c | 14 +++++++++-----
 1 file changed, 9 insertions(+), 5 deletions(-)

diff --git a/hw/ppc/spapr_pci.c b/hw/ppc/spapr_pci.c
index 5c0024bef9c4..679a22fe4e79 100644
--- a/hw/ppc/spapr_pci.c
+++ b/hw/ppc/spapr_pci.c
@@ -1291,8 +1291,7 @@ static void spapr_dt_pci_device_cb(PCIBus *bus, PCIDevice *pdev,
     PciWalkFdt *p = opaque;
     int err;
 
-    if (p->err) {
-        /* Something's already broken, don't keep going */
+    if (p->err || !pdev->enabled) {
         return;
     }
 
@@ -1592,10 +1591,10 @@ static void spapr_pci_plug(HotplugHandler *plug_handler,
     uint32_t slotnr = PCI_SLOT(pdev->devfn);
 
     /*
-     * If DR is disabled we don't need to do anything in the case of
-     * hotplug or coldplug callbacks.
+     * If DR or the PCI device is disabled we don't need to do anything
+     * in the case of hotplug or coldplug callbacks.
      */
-    if (!phb->dr_enabled) {
+    if (!phb->dr_enabled || !pdev->enabled) {
         return;
     }
 
@@ -1680,6 +1679,11 @@ static void spapr_pci_unplug_request(HotplugHandler *plug_handler,
     }
 
     g_assert(drc);
+
+    if (!drc->dev) {
+        return;
+    }
+
     g_assert(drc->dev == plugged_dev);
 
     if (!spapr_drc_unplug_requested(drc)) {

-- 
2.47.0



  parent reply	other threads:[~2024-10-22  8:38 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-22  8:36 [PATCH v17 00/14] hw/pci: SR-IOV related fixes and improvements Akihiko Odaki
2024-10-22  8:36 ` [PATCH v17 01/14] hw/pci: Rename has_power to enabled Akihiko Odaki
2024-10-22  8:36 ` Akihiko Odaki [this message]
2024-10-28  3:08   ` [PATCH v17 02/14] hw/ppc/spapr_pci: Do not create DT for disabled PCI device Shivaprasad G Bhat
2024-10-28  5:58     ` Akihiko Odaki
2024-11-04  5:01       ` Shivaprasad G Bhat
2024-10-22  8:36 ` [PATCH v17 03/14] hw/ppc/spapr_pci: Do not reject VFs created after a PF Akihiko Odaki
2024-10-22  8:36 ` [PATCH v17 04/14] s390x/pci: Avoid creating zpci for VFs Akihiko Odaki
2024-10-22  8:36 ` [PATCH v17 05/14] s390x/pci: Allow plugging SR-IOV devices Akihiko Odaki
2024-10-22  8:36 ` [PATCH v17 06/14] s390x/pci: Check for multifunction after device realization Akihiko Odaki
2024-10-22  8:36 ` [PATCH v17 07/14] pcie_sriov: Do not manually unrealize Akihiko Odaki
2024-10-22  8:36 ` [PATCH v17 08/14] pcie_sriov: Ensure VF addr does not overflow Akihiko Odaki
2024-10-22  8:36 ` [PATCH v17 09/14] pcie_sriov: Reuse SR-IOV VF device instances Akihiko Odaki
2024-10-22  8:36 ` [PATCH v17 10/14] pcie_sriov: Release VFs failed to realize Akihiko Odaki
2024-10-22  8:36 ` [PATCH v17 11/14] pcie_sriov: Remove num_vfs from PCIESriovPF Akihiko Odaki
2024-10-22  8:36 ` [PATCH v17 12/14] pcie_sriov: Register VFs after migration Akihiko Odaki
2024-10-22  8:36 ` [PATCH v17 13/14] hw/pci: Use -1 as the default value for rombar Akihiko Odaki
2024-10-22  8:36 ` [PATCH v17 14/14] hw/qdev: Remove opts member Akihiko Odaki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241022-reuse-v17-2-bd7c133237e4@daynix.com \
    --to=akihiko.odaki@daynix.com \
    --cc=alex.williamson@redhat.com \
    --cc=armbru@redhat.com \
    --cc=berrange@redhat.com \
    --cc=clg@redhat.com \
    --cc=eduardo@habkost.net \
    --cc=farman@linux.ibm.com \
    --cc=harshpb@linux.ibm.com \
    --cc=its@irrelevant.dk \
    --cc=jasowang@redhat.com \
    --cc=kbusch@kernel.org \
    --cc=marcel.apfelbaum@gmail.com \
    --cc=mjrosato@linux.ibm.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=philmd@linaro.org \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=sbhat@linux.ibm.com \
    --cc=sriram.yagnaraman@ericsson.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).