From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: qemu-riscv@nongnu.org, dbarboza@ventanamicro.com,
alistair23@gmail.com, qemu-stable@nongnu.org,
Alistair Francis <alistair.francis@wdc.com>,
Pierrick Bouvier <pierrick.bouvier@linaro.org>
Subject: [PATCH v7 01/14] tcg: Reset data_gen_ptr correctly
Date: Mon, 21 Oct 2024 17:11:21 -0700 [thread overview]
Message-ID: <20241022001134.828724-2-richard.henderson@linaro.org> (raw)
In-Reply-To: <20241022001134.828724-1-richard.henderson@linaro.org>
This pointer needs to be reset after overflow just like
code_buf and code_ptr.
Cc: qemu-stable@nongnu.org
Fixes: 57a269469db ("tcg: Infrastructure for managing constant pools")
Acked-by: Alistair Francis <alistair.francis@wdc.com>
Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
tcg/tcg.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tcg/tcg.c b/tcg/tcg.c
index 5decd83cf4..0babae1b88 100644
--- a/tcg/tcg.c
+++ b/tcg/tcg.c
@@ -1399,7 +1399,6 @@ TranslationBlock *tcg_tb_alloc(TCGContext *s)
goto retry;
}
qatomic_set(&s->code_gen_ptr, next);
- s->data_gen_ptr = NULL;
return tb;
}
@@ -6172,6 +6171,7 @@ int tcg_gen_code(TCGContext *s, TranslationBlock *tb, uint64_t pc_start)
*/
s->code_buf = tcg_splitwx_to_rw(tb->tc.ptr);
s->code_ptr = s->code_buf;
+ s->data_gen_ptr = NULL;
#ifdef TCG_TARGET_NEED_LDST_LABELS
QSIMPLEQ_INIT(&s->ldst_labels);
--
2.43.0
next prev parent reply other threads:[~2024-10-22 0:14 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-22 0:11 [PATCH v7 00/14] tcg/riscv: Add support for vector Richard Henderson
2024-10-22 0:11 ` Richard Henderson [this message]
2024-10-22 0:11 ` [PATCH v7 02/14] disas/riscv: Fix vsetivli disassembly Richard Henderson
2024-10-22 0:11 ` [PATCH v7 03/14] util: Add RISC-V vector extension probe in cpuinfo Richard Henderson
2024-10-22 11:34 ` Daniel Henrique Barboza
2024-10-22 0:11 ` [PATCH v7 04/14] tcg/riscv: Add basic support for vector Richard Henderson
2024-10-22 0:11 ` [PATCH v7 05/14] tcg/riscv: Implement vector mov/dup{m/i} Richard Henderson
2024-10-22 0:11 ` [PATCH v7 06/14] tcg/riscv: Add support for basic vector opcodes Richard Henderson
2024-10-22 0:11 ` [PATCH v7 07/14] tcg/riscv: Implement vector cmp/cmpsel ops Richard Henderson
2024-10-22 0:11 ` [PATCH v7 08/14] tcg/riscv: Implement vector neg ops Richard Henderson
2024-10-22 0:11 ` [PATCH v7 09/14] tcg/riscv: Accept constant first argument to sub_vec Richard Henderson
2024-10-23 2:34 ` Alistair Francis
2024-10-22 0:11 ` [PATCH v7 10/14] tcg/riscv: Implement vector sat/mul ops Richard Henderson
2024-10-22 0:11 ` [PATCH v7 11/14] tcg/riscv: Implement vector min/max ops Richard Henderson
2024-10-22 0:11 ` [PATCH v7 12/14] tcg/riscv: Implement vector shi/s/v ops Richard Henderson
2024-10-22 0:11 ` [PATCH v7 13/14] tcg/riscv: Implement vector roti/v/x ops Richard Henderson
2024-10-22 0:11 ` [PATCH v7 14/14] tcg/riscv: Enable native vector support for TCG host Richard Henderson
2024-10-23 2:41 ` [PATCH v7 00/14] tcg/riscv: Add support for vector Alistair Francis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241022001134.828724-2-richard.henderson@linaro.org \
--to=richard.henderson@linaro.org \
--cc=alistair.francis@wdc.com \
--cc=alistair23@gmail.com \
--cc=dbarboza@ventanamicro.com \
--cc=pierrick.bouvier@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).