qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Beraldo Leal" <bleal@redhat.com>,
	"Laurent Vivier" <laurent@vivier.eu>,
	"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
	"Mahmoud Mandour" <ma.mandourr@gmail.com>,
	"Jiaxun Yang" <jiaxun.yang@flygoat.com>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"Yanan Wang" <wangyanan55@huawei.com>,
	"Thomas Huth" <thuth@redhat.com>, "John Snow" <jsnow@redhat.com>,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>,
	qemu-arm@nongnu.org, "Daniel P. Berrangé" <berrange@redhat.com>,
	"Eduardo Habkost" <eduardo@habkost.net>,
	devel@lists.libvirt.org, "Cleber Rosa" <crosa@redhat.com>,
	kvm@vger.kernel.org, "Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Alexandre Iooss" <erdnaxe@crans.org>,
	"Peter Maydell" <peter.maydell@linaro.org>,
	"Richard Henderson" <richard.henderson@linaro.org>,
	"Riku Voipio" <riku.voipio@iki.fi>,
	"Zhao Liu" <zhao1.liu@intel.com>,
	"Marcelo Tosatti" <mtosatti@redhat.com>,
	"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
	"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
	"Pierrick Bouvier" <pierrick.bouvier@linaro.org>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Ilya Leoshkevich" <iii@linux.ibm.com>
Subject: [PATCH v2 01/20] tests/docker: Fix microblaze atomics
Date: Tue, 22 Oct 2024 11:55:55 +0100	[thread overview]
Message-ID: <20241022105614.839199-2-alex.bennee@linaro.org> (raw)
In-Reply-To: <20241022105614.839199-1-alex.bennee@linaro.org>

From: Ilya Leoshkevich <iii@linux.ibm.com>

GCC produces invalid code for microblaze atomics.

The fix is unfortunately not upstream, so fetch it from an external
location and apply it locally.

Suggested-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
Message-Id: <20240919152308.10440-1-iii@linux.ibm.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
 .../debian-microblaze-cross.d/build-toolchain.sh          | 8 ++++++++
 tests/docker/dockerfiles/debian-toolchain.docker          | 7 +++++++
 2 files changed, 15 insertions(+)

diff --git a/tests/docker/dockerfiles/debian-microblaze-cross.d/build-toolchain.sh b/tests/docker/dockerfiles/debian-microblaze-cross.d/build-toolchain.sh
index 23ec0aa9a7..c5cd0aa931 100755
--- a/tests/docker/dockerfiles/debian-microblaze-cross.d/build-toolchain.sh
+++ b/tests/docker/dockerfiles/debian-microblaze-cross.d/build-toolchain.sh
@@ -10,6 +10,8 @@ TOOLCHAIN_INSTALL=/usr/local
 TOOLCHAIN_BIN=${TOOLCHAIN_INSTALL}/bin
 CROSS_SYSROOT=${TOOLCHAIN_INSTALL}/$TARGET/sys-root
 
+GCC_PATCH0_URL=https://raw.githubusercontent.com/Xilinx/meta-xilinx/refs/tags/xlnx-rel-v2024.1/meta-microblaze/recipes-devtools/gcc/gcc-12/0009-Patch-microblaze-Fix-atomic-boolean-return-value.patch
+
 export PATH=${TOOLCHAIN_BIN}:$PATH
 
 #
@@ -31,6 +33,12 @@ mv gcc-11.2.0 src-gcc
 mv musl-1.2.2 src-musl
 mv linux-5.10.70 src-linux
 
+#
+# Patch gcc
+#
+
+wget -O - ${GCC_PATCH0_URL} | patch -d src-gcc -p1
+
 mkdir -p bld-hdr bld-binu bld-gcc bld-musl
 mkdir -p ${CROSS_SYSROOT}/usr/include
 
diff --git a/tests/docker/dockerfiles/debian-toolchain.docker b/tests/docker/dockerfiles/debian-toolchain.docker
index 687a97fec4..ab4ce29533 100644
--- a/tests/docker/dockerfiles/debian-toolchain.docker
+++ b/tests/docker/dockerfiles/debian-toolchain.docker
@@ -10,6 +10,8 @@ FROM docker.io/library/debian:11-slim
 # ??? The build-dep isn't working, missing a number of
 # minimal build dependiencies, e.g. libmpc.
 
+RUN sed 's/^deb /deb-src /' </etc/apt/sources.list >/etc/apt/sources.list.d/deb-src.list
+
 RUN apt update && \
     DEBIAN_FRONTEND=noninteractive apt install -yy eatmydata && \
     DEBIAN_FRONTEND=noninteractive eatmydata \
@@ -33,6 +35,11 @@ RUN cd /root && ./build-toolchain.sh
 # and the build trees by restoring the original image,
 # then copying the built toolchain from stage 0.
 FROM docker.io/library/debian:11-slim
+RUN apt update && \
+    DEBIAN_FRONTEND=noninteractive apt install -yy eatmydata && \
+    DEBIAN_FRONTEND=noninteractive eatmydata \
+    apt install -y --no-install-recommends \
+        libmpc3
 COPY --from=0 /usr/local /usr/local
 # As a final step configure the user (if env is defined)
 ARG USER
-- 
2.39.5



  reply	other threads:[~2024-10-22 10:59 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-22 10:55 [PATCH v2 00/20] maintainer updates (testing, gdbstub, plugins) Alex Bennée
2024-10-22 10:55 ` Alex Bennée [this message]
2024-10-22 20:30   ` [PATCH v2 01/20] tests/docker: Fix microblaze atomics Pierrick Bouvier
2024-10-22 10:55 ` [PATCH v2 02/20] tests/docker: add NOFETCH env variable for testing Alex Bennée
2024-10-22 20:31   ` Pierrick Bouvier
2024-10-22 10:55 ` [PATCH v2 03/20] MAINTAINERS: mention my testing/next tree Alex Bennée
2024-10-22 11:20   ` Thomas Huth
2024-10-22 10:55 ` [PATCH v2 04/20] meson: hide tsan related warnings Alex Bennée
2024-10-22 10:55 ` [PATCH v2 05/20] docs/devel: update tsan build documentation Alex Bennée
2024-10-22 10:56 ` [PATCH v2 06/20] scripts/ci: remove architecture checks for build-environment updates Alex Bennée
2024-10-22 20:32   ` Pierrick Bouvier
2024-10-22 10:56 ` [PATCH v2 07/20] tests/tcg/x86_64: Add cross-modifying code test Alex Bennée
2024-10-22 20:36   ` Pierrick Bouvier
2024-10-23  0:16     ` Ilya Leoshkevich
2024-10-23  0:33       ` Pierrick Bouvier
2024-10-23  8:55         ` Alex Bennée
2024-10-22 10:56 ` [PATCH v2 08/20] accel/tcg: add tracepoints for cpu_loop_exit_atomic Alex Bennée
2024-10-22 10:56 ` [PATCH v2 09/20] dockerfiles: fix default targets for debian-loongarch-cross Alex Bennée
2024-10-22 10:56 ` [PATCH v2 10/20] gitlab: make check-[dco|patch] a little more verbose Alex Bennée
2024-10-22 11:04   ` Daniel P. Berrangé
2024-10-22 11:08   ` Thomas Huth
2024-10-22 10:56 ` [PATCH v2 11/20] MAINTAINERS: mention my gdbstub/next tree Alex Bennée
2024-10-22 11:29   ` Thomas Huth
2024-10-22 21:35   ` Philippe Mathieu-Daudé
2024-10-22 10:56 ` [PATCH v2 12/20] config/targets: update aarch64_be-linux-user gdb XML list Alex Bennée
2024-10-22 20:37   ` Pierrick Bouvier
2024-10-22 10:56 ` [PATCH v2 13/20] tests/tcg: enable basic testing for aarch64_be-linux-user Alex Bennée
2024-10-22 19:12   ` Richard Henderson
2024-10-22 20:39   ` Pierrick Bouvier
2024-10-22 21:37   ` Philippe Mathieu-Daudé
2024-10-22 10:56 ` [PATCH v2 14/20] tests/tcg/aarch64: Use raw strings for regexes in test-mte.py Alex Bennée
2024-10-22 10:56 ` [PATCH v2 15/20] testing: Enhance gdb probe script Alex Bennée
2024-10-22 20:39   ` Pierrick Bouvier
2024-10-22 10:56 ` [PATCH v2 16/20] MAINTAINERS: mention my plugins/next tree Alex Bennée
2024-10-22 20:40   ` Pierrick Bouvier
2024-10-22 10:56 ` [PATCH v2 17/20] plugins: add ability to register a GDB triggered callback Alex Bennée
2024-10-22 20:47   ` Pierrick Bouvier
2024-10-22 10:56 ` [PATCH v2 18/20] meson: build contrib/plugins with meson Alex Bennée
2024-10-23  7:51   ` Pierrick Bouvier
2024-10-23  8:57     ` Alex Bennée
2024-10-23 21:31       ` Pierrick Bouvier
2024-10-22 10:56 ` [PATCH v2 19/20] contrib/plugins: remove Makefile for contrib/plugins Alex Bennée
2024-10-22 10:56 ` [PATCH v2 20/20] plugins: fix qemu_plugin_reset Alex Bennée

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241022105614.839199-2-alex.bennee@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=berrange@redhat.com \
    --cc=bleal@redhat.com \
    --cc=crosa@redhat.com \
    --cc=devel@lists.libvirt.org \
    --cc=edgar.iglesias@gmail.com \
    --cc=eduardo@habkost.net \
    --cc=erdnaxe@crans.org \
    --cc=iii@linux.ibm.com \
    --cc=jiaxun.yang@flygoat.com \
    --cc=jsnow@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=laurent@vivier.eu \
    --cc=ma.mandourr@gmail.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=marcel.apfelbaum@gmail.com \
    --cc=mtosatti@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@linaro.org \
    --cc=pierrick.bouvier@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=riku.voipio@iki.fi \
    --cc=thuth@redhat.com \
    --cc=wainersm@redhat.com \
    --cc=wangyanan55@huawei.com \
    --cc=zhao1.liu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).