From: "Daniel P. Berrangé" <berrange@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
"Yuri Benditovich" <yuri.benditovich@daynix.com>,
"Daniel P. Berrangé" <berrange@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Andrew Melnychenko" <andrew@daynix.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Jason Wang" <jasowang@redhat.com>
Subject: [PATCH v3 0/8] Report fatal errors from failure with pre-opened eBPF RSS FDs
Date: Wed, 23 Oct 2024 09:50:55 +0100 [thread overview]
Message-ID: <20241023085103.1980072-1-berrange@redhat.com> (raw)
The virtio-net code for eBPF RSS is still ignoring errors when
failing to load the eBPF RSS program passed in by the mgmt app
via pre-opened FDs.
This series re-factors the eBPF common code so that it actually
reports using "Error" objects. Then it makes virtio-net treat
a failure to load pre-opened FDs as a fatal problem. When doing
speculative opening of eBPF FDs, QEMU merely prints a warning,
and allows the software fallback to continue.
Trace event coverage is significantly expanded to make this all
much more debuggable too.
Changed in v3:
- Fixed bpf stubs for new Error **errp argument
- Added fix for pre-existing flaw with libxdp build logic
when bpf is disabled
Changed in v2:
- Split 'ebpf_error' probe into multiple probes
Daniel P. Berrangé (8):
net: fix build when libbpf is disabled, but libxdp is enabled
hw/net: fix typo s/epbf/ebpf/ in virtio-net
ebpf: drop redundant parameter checks in static methods
ebpf: improve error trace events
ebpf: add formal error reporting to all APIs
hw/net: report errors from failing to use eBPF RSS FDs
ebpf: improve trace event coverage to all key operations
hw/net: improve tracing of eBPF RSS setup
ebpf/ebpf_rss-stub.c | 8 +--
ebpf/ebpf_rss.c | 118 ++++++++++++++++++++++++++++---------------
ebpf/ebpf_rss.h | 10 ++--
ebpf/trace-events | 8 ++-
hw/net/trace-events | 8 +--
hw/net/virtio-net.c | 63 +++++++++++++++--------
meson.build | 10 +++-
net/meson.build | 2 +-
8 files changed, 151 insertions(+), 76 deletions(-)
--
2.46.0
next reply other threads:[~2024-10-23 8:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-23 8:50 Daniel P. Berrangé [this message]
2024-10-23 8:50 ` [PATCH v3 1/8] net: fix build when libbpf is disabled, but libxdp is enabled Daniel P. Berrangé
2024-10-23 8:50 ` [PATCH v3 2/8] hw/net: fix typo s/epbf/ebpf/ in virtio-net Daniel P. Berrangé
2024-10-23 8:50 ` [PATCH v3 3/8] ebpf: drop redundant parameter checks in static methods Daniel P. Berrangé
2024-10-23 8:50 ` [PATCH v3 4/8] ebpf: improve error trace events Daniel P. Berrangé
2024-10-23 8:51 ` [PATCH v3 5/8] ebpf: add formal error reporting to all APIs Daniel P. Berrangé
2024-10-23 8:51 ` [PATCH v3 6/8] hw/net: report errors from failing to use eBPF RSS FDs Daniel P. Berrangé
2024-10-23 8:51 ` [PATCH v3 7/8] ebpf: improve trace event coverage to all key operations Daniel P. Berrangé
2024-10-23 8:51 ` [PATCH v3 8/8] hw/net: improve tracing of eBPF RSS setup Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241023085103.1980072-1-berrange@redhat.com \
--to=berrange@redhat.com \
--cc=andrew@daynix.com \
--cc=jasowang@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=yuri.benditovich@daynix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).