From: Thomas Huth <thuth@redhat.com>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
Jens Remus <jremus@linux.ibm.com>,
Marc Hartmayer <mhartmay@linux.ibm.com>
Subject: [PULL 20/23] pc-bios/s390-ccw: Clarify alignment is in bytes
Date: Wed, 23 Oct 2024 15:17:07 +0200 [thread overview]
Message-ID: <20241023131710.906748-21-thuth@redhat.com> (raw)
In-Reply-To: <20241023131710.906748-1-thuth@redhat.com>
From: Jens Remus <jremus@linux.ibm.com>
The assembler directive .align [1] has architecture-dependent behavior,
which may be ambiguous for the reader. Some architectures perform the
alignment in bytes, others in power of two. s390 does in bytes.
Use the directive .balign [2] instead, to clarify that the alignment
request is in bytes. No functional change.
[1] https://sourceware.org/binutils/docs/as/Align.html
[2] https://sourceware.org/binutils/docs/as/Balign.html
Signed-off-by: Jens Remus <jremus@linux.ibm.com>
Reviewed-by: Marc Hartmayer <mhartmay@linux.ibm.com>
Message-ID: <20241001153618.17791-2-mhartmay@linux.ibm.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
pc-bios/s390-ccw/start.S | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/pc-bios/s390-ccw/start.S b/pc-bios/s390-ccw/start.S
index 061b06591c..576fc12c06 100644
--- a/pc-bios/s390-ccw/start.S
+++ b/pc-bios/s390-ccw/start.S
@@ -112,7 +112,7 @@ io_new_code:
lctlg %c6,%c6,0(%r15)
br %r14
- .align 8
+ .balign 8
bss_start_literal:
.quad __bss_start
disabled_wait_psw:
@@ -125,7 +125,7 @@ io_new_mask:
.quad 0x0000000180000000
.bss
- .align 8
+ .balign 8
stack:
.space STACK_SIZE
.size stack,STACK_SIZE
--
2.47.0
next prev parent reply other threads:[~2024-10-23 13:19 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-23 13:16 [PULL 00/23] s390-ccw bios update Thomas Huth
2024-10-23 13:16 ` [PULL 01/23] hw/s390x/ipl: Provide more memory to the s390-ccw.img firmware Thomas Huth
2024-10-23 13:16 ` [PULL 02/23] pc-bios/s390-ccw: Use the libc from SLOF and remove sclp prints Thomas Huth
2024-10-23 13:16 ` [PULL 03/23] pc-bios/s390-ccw: Link the netboot code into the main s390-ccw.img binary Thomas Huth
2024-10-23 13:16 ` [PULL 04/23] hw/s390x: Remove the possibility to load the s390-netboot.img binary Thomas Huth
2024-10-23 13:16 ` [PULL 05/23] pc-bios/s390-ccw: Merge netboot.mak into the main Makefile Thomas Huth
2024-10-23 13:16 ` [PULL 06/23] docs/system/s390x/bootdevices: Update the documentation about network booting Thomas Huth
2024-10-23 13:16 ` [PULL 07/23] pc-bios/s390-ccw: Remove panics from ISO IPL path Thomas Huth
2024-10-23 13:16 ` [PULL 08/23] pc-bios/s390-ccw: Remove panics from ECKD " Thomas Huth
2024-10-23 13:16 ` [PULL 09/23] pc-bios/s390-ccw: Remove panics from SCSI " Thomas Huth
2024-10-23 13:16 ` [PULL 10/23] pc-bios/s390-ccw: Remove panics from DASD " Thomas Huth
2024-10-23 13:16 ` [PULL 11/23] pc-bios/s390-ccw: Remove panics from Netboot " Thomas Huth
2024-10-23 13:16 ` [PULL 12/23] pc-bios/s390-ccw: Enable failed IPL to return after error Thomas Huth
2024-10-23 13:17 ` [PULL 13/23] include/hw/s390x: Add include files for common IPL structs Thomas Huth
2024-10-23 13:17 ` [PULL 14/23] s390x: Add individual loadparm assignment to CCW device Thomas Huth
2024-10-23 13:17 ` [PULL 15/23] hw/s390x: Build an IPLB for each boot device Thomas Huth
2025-06-16 10:04 ` Philippe Mathieu-Daudé
2025-06-16 15:04 ` Jared Rossi
2024-10-23 13:17 ` [PULL 16/23] s390x: Rebuild IPLB for SCSI device directly from DIAG308 Thomas Huth
2024-10-23 13:17 ` [PULL 17/23] pc-bios/s390x: Enable multi-device boot loop Thomas Huth
2024-10-23 13:17 ` [PULL 18/23] docs/system: Update documentation for s390x IPL Thomas Huth
2024-10-23 13:17 ` [PULL 19/23] tests/qtest: Add s390x boot order tests to cdrom-test.c Thomas Huth
2024-10-23 13:17 ` Thomas Huth [this message]
2024-10-23 13:17 ` [PULL 21/23] pc-bios/s390-ccw: Don't generate TEXTRELs Thomas Huth
2024-10-23 13:17 ` [PULL 22/23] pc-bios/s390-ccw: Introduce `EXTRA_LDFLAGS` Thomas Huth
2024-10-23 13:17 ` [PULL 23/23] pc-bios/s390-ccw: Update s390-ccw.img with the full boot order support feature Thomas Huth
2024-10-25 12:34 ` [PULL 00/23] s390-ccw bios update Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241023131710.906748-21-thuth@redhat.com \
--to=thuth@redhat.com \
--cc=jremus@linux.ibm.com \
--cc=mhartmay@linux.ibm.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).