From: "J. Neuschäfer" <j.neuschaefer@gmx.net>
To: Laurent Vivier <laurent@vivier.eu>,
All patches CC here <qemu-devel@nongnu.org>
Cc: "J. Neuschäfer" <j.neuschaefer@gmx.net>
Subject: [PATCH] linux-user/strace: show TID instead of PID
Date: Thu, 24 Oct 2024 01:47:31 +0200 [thread overview]
Message-ID: <20241024-strace-v1-1-56c4161431cd@gmx.net> (raw)
This aligns with strace, and is very useful when tracing multi-threaded
programs. The result is the same in single-threaded programs.
gettid() requires the _GNU_SOURCE feature test macro, so it might be
unavailable in rare cases. I don't expect it to be a problem though,
because it's implemented by both glibc and musl.
Signed-off-by: J. Neuschäfer <j.neuschaefer@gmx.net>
---
linux-user/strace.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/linux-user/strace.c b/linux-user/strace.c
index c3eb3a2706a93fdcaf693b3413b13921a3c97e8e..93e8c73de8a4a307e6e0df5555bee4c769e41e64 100644
--- a/linux-user/strace.c
+++ b/linux-user/strace.c
@@ -4337,7 +4337,7 @@ print_syscall(CPUArchState *cpu_env, int num,
if (!f) {
return;
}
- fprintf(f, "%d ", getpid());
+ fprintf(f, "%d ", gettid());
for (i = 0; i < nsyscalls; i++) {
if (scnames[i].nr == num) {
---
base-commit: 6f625ce2f21d6a1243065d236298277c56f972d5
change-id: 20241024-strace-a52bd8e3d305
Best regards,
--
J. Neuschäfer <j.neuschaefer@gmx.net>
next reply other threads:[~2024-10-23 23:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-23 23:47 J. Neuschäfer [this message]
2024-11-10 14:10 ` [PATCH] linux-user/strace: show TID instead of PID J. Neuschäfer
2024-11-11 14:59 ` Richard Henderson
2024-11-11 15:02 ` Richard Henderson
2024-11-20 20:23 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241024-strace-v1-1-56c4161431cd@gmx.net \
--to=j.neuschaefer@gmx.net \
--cc=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).