From: "Alex Bennée" <alex.bennee@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Alex Bennée" <alex.bennee@linaro.org>,
"Daniel P . Berrangé" <berrange@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Thomas Huth" <thuth@redhat.com>,
"Wainer dos Santos Moschetta" <wainersm@redhat.com>
Subject: [PULL 10/17] gitlab: make check-[dco|patch] a little more verbose
Date: Thu, 24 Oct 2024 10:55:56 +0100 [thread overview]
Message-ID: <20241024095603.1813285-11-alex.bennee@linaro.org> (raw)
In-Reply-To: <20241024095603.1813285-1-alex.bennee@linaro.org>
When git fails the rather terse backtrace only indicates it failed
without some useful context. Add some to make the log a little more
useful.
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20241023113406.1284676-11-alex.bennee@linaro.org>
diff --git a/.gitlab-ci.d/check-dco.py b/.gitlab-ci.d/check-dco.py
index 632c8bcce8..d221b16bd5 100755
--- a/.gitlab-ci.d/check-dco.py
+++ b/.gitlab-ci.d/check-dco.py
@@ -19,10 +19,9 @@
reponame = os.path.basename(cwd)
repourl = "https://gitlab.com/%s/%s.git" % (namespace, reponame)
+print(f"adding upstream git repo @ {repourl}")
subprocess.check_call(["git", "remote", "add", "check-dco", repourl])
-subprocess.check_call(["git", "fetch", "check-dco", "master"],
- stdout=subprocess.DEVNULL,
- stderr=subprocess.DEVNULL)
+subprocess.check_call(["git", "fetch", "check-dco", "master"])
ancestor = subprocess.check_output(["git", "merge-base",
"check-dco/master", "HEAD"],
diff --git a/.gitlab-ci.d/check-patch.py b/.gitlab-ci.d/check-patch.py
index 39e2b403c9..68c549a146 100755
--- a/.gitlab-ci.d/check-patch.py
+++ b/.gitlab-ci.d/check-patch.py
@@ -19,13 +19,12 @@
reponame = os.path.basename(cwd)
repourl = "https://gitlab.com/%s/%s.git" % (namespace, reponame)
+print(f"adding upstream git repo @ {repourl}")
# GitLab CI environment does not give us any direct info about the
# base for the user's branch. We thus need to figure out a common
# ancestor between the user's branch and current git master.
subprocess.check_call(["git", "remote", "add", "check-patch", repourl])
-subprocess.check_call(["git", "fetch", "check-patch", "master"],
- stdout=subprocess.DEVNULL,
- stderr=subprocess.DEVNULL)
+subprocess.check_call(["git", "fetch", "check-patch", "master"])
ancestor = subprocess.check_output(["git", "merge-base",
"check-patch/master", "HEAD"],
--
2.39.5
next prev parent reply other threads:[~2024-10-24 9:57 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-24 9:55 [PULL 00/17] testing, gdbstub and plugin updates Alex Bennée
2024-10-24 9:55 ` [PULL 01/17] tests/docker: Fix microblaze atomics Alex Bennée
2024-10-24 9:55 ` [PULL 02/17] tests/docker: add NOFETCH env variable for testing Alex Bennée
2024-10-24 9:55 ` [PULL 03/17] MAINTAINERS: mention my testing/next tree Alex Bennée
2024-10-24 9:55 ` [PULL 04/17] meson: hide tsan related warnings Alex Bennée
2024-10-24 9:55 ` [PULL 05/17] docs/devel: update tsan build documentation Alex Bennée
2024-10-24 9:55 ` [PULL 06/17] scripts/ci: remove architecture checks for build-environment updates Alex Bennée
2024-10-24 9:55 ` [PULL 07/17] tests/tcg/x86_64: Add cross-modifying code test Alex Bennée
2024-10-24 9:55 ` [PULL 08/17] accel/tcg: add tracepoints for cpu_loop_exit_atomic Alex Bennée
2024-10-24 9:55 ` [PULL 09/17] dockerfiles: fix default targets for debian-loongarch-cross Alex Bennée
2024-10-24 9:55 ` Alex Bennée [this message]
2024-10-24 9:55 ` [PULL 11/17] MAINTAINERS: mention my gdbstub/next tree Alex Bennée
2024-10-24 9:55 ` [PULL 12/17] config/targets: update aarch64_be-linux-user gdb XML list Alex Bennée
2024-10-24 9:55 ` [PULL 13/17] tests/tcg: enable basic testing for aarch64_be-linux-user Alex Bennée
2024-10-24 9:56 ` [PULL 14/17] tests/tcg/aarch64: Use raw strings for regexes in test-mte.py Alex Bennée
2024-10-24 9:56 ` [PULL 15/17] testing: Enhance gdb probe script Alex Bennée
2024-10-24 9:56 ` [PULL 16/17] MAINTAINERS: mention my plugins/next tree Alex Bennée
2024-10-24 9:56 ` [PULL 17/17] plugins: fix qemu_plugin_reset Alex Bennée
2024-10-28 14:17 ` [PULL 00/17] testing, gdbstub and plugin updates Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241024095603.1813285-11-alex.bennee@linaro.org \
--to=alex.bennee@linaro.org \
--cc=berrange@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
--cc=wainersm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).