From: "Alex Bennée" <alex.bennee@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Alex Bennée" <alex.bennee@linaro.org>,
"Pierrick Bouvier" <pierrick.bouvier@linaro.org>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Thomas Huth" <thuth@redhat.com>,
"Wainer dos Santos Moschetta" <wainersm@redhat.com>
Subject: [PULL 02/17] tests/docker: add NOFETCH env variable for testing
Date: Thu, 24 Oct 2024 10:55:48 +0100 [thread overview]
Message-ID: <20241024095603.1813285-3-alex.bennee@linaro.org> (raw)
In-Reply-To: <20241024095603.1813285-1-alex.bennee@linaro.org>
Testing non-auto built docker containers (i.e. custom built compilers)
is a bit fiddly as you couldn't continue a build with a previously
locally built container. While you can play games with REGISTRY its
simpler to allow a NOFETCH that will go through the cached build
process when you run the tests.
Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20241023113406.1284676-3-alex.bennee@linaro.org>
diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include
index 681feae744..fead7d3abe 100644
--- a/tests/docker/Makefile.include
+++ b/tests/docker/Makefile.include
@@ -92,10 +92,10 @@ endif
docker-image-alpine: NOUSER=1
debian-toolchain-run = \
- $(if $(NOCACHE), \
+ $(if $(NOCACHE)$(NOFETCH), \
$(call quiet-command, \
$(DOCKER_SCRIPT) build -t qemu/$1 -f $< \
- $(if $V,,--quiet) --no-cache \
+ $(if $V,,--quiet) $(if $(NOCACHE),--no-cache) \
--registry $(DOCKER_REGISTRY) --extra-files \
$(DOCKER_FILES_DIR)/$1.d/build-toolchain.sh, \
"BUILD", $1), \
@@ -177,6 +177,7 @@ docker:
@echo ' NETWORK=$$BACKEND Enable virtual network interface with $$BACKEND.'
@echo ' NOUSER=1 Define to disable adding current user to containers passwd.'
@echo ' NOCACHE=1 Ignore cache when build images.'
+ @echo ' NOFETCH=1 Do not fetch from the registry.'
@echo ' EXECUTABLE=<path> Include executable in image.'
@echo ' EXTRA_FILES="<path> [... <path>]"'
@echo ' Include extra files in image.'
--
2.39.5
next prev parent reply other threads:[~2024-10-24 9:57 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-24 9:55 [PULL 00/17] testing, gdbstub and plugin updates Alex Bennée
2024-10-24 9:55 ` [PULL 01/17] tests/docker: Fix microblaze atomics Alex Bennée
2024-10-24 9:55 ` Alex Bennée [this message]
2024-10-24 9:55 ` [PULL 03/17] MAINTAINERS: mention my testing/next tree Alex Bennée
2024-10-24 9:55 ` [PULL 04/17] meson: hide tsan related warnings Alex Bennée
2024-10-24 9:55 ` [PULL 05/17] docs/devel: update tsan build documentation Alex Bennée
2024-10-24 9:55 ` [PULL 06/17] scripts/ci: remove architecture checks for build-environment updates Alex Bennée
2024-10-24 9:55 ` [PULL 07/17] tests/tcg/x86_64: Add cross-modifying code test Alex Bennée
2024-10-24 9:55 ` [PULL 08/17] accel/tcg: add tracepoints for cpu_loop_exit_atomic Alex Bennée
2024-10-24 9:55 ` [PULL 09/17] dockerfiles: fix default targets for debian-loongarch-cross Alex Bennée
2024-10-24 9:55 ` [PULL 10/17] gitlab: make check-[dco|patch] a little more verbose Alex Bennée
2024-10-24 9:55 ` [PULL 11/17] MAINTAINERS: mention my gdbstub/next tree Alex Bennée
2024-10-24 9:55 ` [PULL 12/17] config/targets: update aarch64_be-linux-user gdb XML list Alex Bennée
2024-10-24 9:55 ` [PULL 13/17] tests/tcg: enable basic testing for aarch64_be-linux-user Alex Bennée
2024-10-24 9:56 ` [PULL 14/17] tests/tcg/aarch64: Use raw strings for regexes in test-mte.py Alex Bennée
2024-10-24 9:56 ` [PULL 15/17] testing: Enhance gdb probe script Alex Bennée
2024-10-24 9:56 ` [PULL 16/17] MAINTAINERS: mention my plugins/next tree Alex Bennée
2024-10-24 9:56 ` [PULL 17/17] plugins: fix qemu_plugin_reset Alex Bennée
2024-10-28 14:17 ` [PULL 00/17] testing, gdbstub and plugin updates Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241024095603.1813285-3-alex.bennee@linaro.org \
--to=alex.bennee@linaro.org \
--cc=philmd@linaro.org \
--cc=pierrick.bouvier@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
--cc=wainersm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).