From: "Alex Bennée" <alex.bennee@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Pierrick Bouvier" <pierrick.bouvier@linaro.org>,
"Thomas Huth" <thuth@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Daniel P. Berrangé" <berrange@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: [PULL 04/17] meson: hide tsan related warnings
Date: Thu, 24 Oct 2024 10:55:50 +0100 [thread overview]
Message-ID: <20241024095603.1813285-5-alex.bennee@linaro.org> (raw)
In-Reply-To: <20241024095603.1813285-1-alex.bennee@linaro.org>
From: Pierrick Bouvier <pierrick.bouvier@linaro.org>
When building with gcc-12 -fsanitize=thread, gcc reports some
constructions not supported with tsan.
Found on debian stable.
qemu/include/qemu/atomic.h:36:52: error: ‘atomic_thread_fence’ is not supported with ‘-fsanitize=thread’ [-Werror=tsan]
36 | #define smp_mb() ({ barrier(); __atomic_thread_fence(__ATOMIC_SEQ_CST); })
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-Id: <20240910174013.1433331-2-pierrick.bouvier@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20241023113406.1284676-5-alex.bennee@linaro.org>
diff --git a/meson.build b/meson.build
index d26690ce20..bdd67a2d6d 100644
--- a/meson.build
+++ b/meson.build
@@ -538,7 +538,15 @@ if get_option('tsan')
prefix: '#include <sanitizer/tsan_interface.h>')
error('Cannot enable TSAN due to missing fiber annotation interface')
endif
- qemu_cflags = ['-fsanitize=thread'] + qemu_cflags
+ tsan_warn_suppress = []
+ # gcc (>=11) will report constructions not supported by tsan:
+ # "error: ‘atomic_thread_fence’ is not supported with ‘-fsanitize=thread’"
+ # https://gcc.gnu.org/gcc-11/changes.html
+ # However, clang does not support this warning and this triggers an error.
+ if cc.has_argument('-Wno-tsan')
+ tsan_warn_suppress = ['-Wno-tsan']
+ endif
+ qemu_cflags = ['-fsanitize=thread'] + tsan_warn_suppress + qemu_cflags
qemu_ldflags = ['-fsanitize=thread'] + qemu_ldflags
endif
--
2.39.5
next prev parent reply other threads:[~2024-10-24 9:58 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-24 9:55 [PULL 00/17] testing, gdbstub and plugin updates Alex Bennée
2024-10-24 9:55 ` [PULL 01/17] tests/docker: Fix microblaze atomics Alex Bennée
2024-10-24 9:55 ` [PULL 02/17] tests/docker: add NOFETCH env variable for testing Alex Bennée
2024-10-24 9:55 ` [PULL 03/17] MAINTAINERS: mention my testing/next tree Alex Bennée
2024-10-24 9:55 ` Alex Bennée [this message]
2024-10-24 9:55 ` [PULL 05/17] docs/devel: update tsan build documentation Alex Bennée
2024-10-24 9:55 ` [PULL 06/17] scripts/ci: remove architecture checks for build-environment updates Alex Bennée
2024-10-24 9:55 ` [PULL 07/17] tests/tcg/x86_64: Add cross-modifying code test Alex Bennée
2024-10-24 9:55 ` [PULL 08/17] accel/tcg: add tracepoints for cpu_loop_exit_atomic Alex Bennée
2024-10-24 9:55 ` [PULL 09/17] dockerfiles: fix default targets for debian-loongarch-cross Alex Bennée
2024-10-24 9:55 ` [PULL 10/17] gitlab: make check-[dco|patch] a little more verbose Alex Bennée
2024-10-24 9:55 ` [PULL 11/17] MAINTAINERS: mention my gdbstub/next tree Alex Bennée
2024-10-24 9:55 ` [PULL 12/17] config/targets: update aarch64_be-linux-user gdb XML list Alex Bennée
2024-10-24 9:55 ` [PULL 13/17] tests/tcg: enable basic testing for aarch64_be-linux-user Alex Bennée
2024-10-24 9:56 ` [PULL 14/17] tests/tcg/aarch64: Use raw strings for regexes in test-mte.py Alex Bennée
2024-10-24 9:56 ` [PULL 15/17] testing: Enhance gdb probe script Alex Bennée
2024-10-24 9:56 ` [PULL 16/17] MAINTAINERS: mention my plugins/next tree Alex Bennée
2024-10-24 9:56 ` [PULL 17/17] plugins: fix qemu_plugin_reset Alex Bennée
2024-10-28 14:17 ` [PULL 00/17] testing, gdbstub and plugin updates Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241024095603.1813285-5-alex.bennee@linaro.org \
--to=alex.bennee@linaro.org \
--cc=berrange@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=pierrick.bouvier@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).