From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: manos.pitsidianakis@linaro.org, zhao1.liu@intel.com,
junjie.mao@hotmail.com, berrange@redhat.com
Subject: [PATCH v3 00/23] rust: fix CI + allow older versions of rustc and bindgen
Date: Fri, 25 Oct 2024 18:01:45 +0200 [thread overview]
Message-ID: <20241025160209.194307-1-pbonzini@redhat.com> (raw)
Since Manos helpfully posted his vmstate patches, this series is all that
is needed in order to enable Rust for at least the Debian, Fedora and
Ubuntu jobs. I took his patches and isolated them from the procedural
macro experiment.
There are quite a few changes from the previous posting:
- new patches to bring pl011 mostly up to date with the C code (1-7)
- remove unnecessary .gitattributes file (8)
- apply rustfmt throughout
- add "rust: create a cargo workspace" to ensure a single version of the
dependencies is used for all cargo commands (14, based on a suggestion by
Junjie)
- add Junjie's syntax checks to the offset_of! macro. I added a small
struct with a From<> implementation, to make compile errors even easier
to report (15).
- add final patch to enable rust in the Debian and Ubuntu system build
jobs (23)
Note that this requires "meson subprojects update --reset" in order to do
an incremental build if you have already downloaded the Rust subprojects.
While I have a solution for that (modeled after scripts/git-submodule.sh),
I first need to check with the Meson folks whether my script is using only
stable interfaces.
This series can be found at branch rust-next of my git repository
(https://gitlab.com/bonzini/qemu.git), which also helps with the
problems in applying patch 8. Everything up to commit f6a46d2a4eb
("rust: do not use TYPE_CHARDEV unnecessarily", 2024-10-25) will be
my next pull request, which I will send early next week (to give
people some more days to complain).
Paolo
Supersedes: <20241022100956.196657-1-pbonzini@redhat.com>
CI: https://gitlab.com/bonzini/qemu/-/pipelines/1512732399
Manos Pitsidianakis (6):
rust: add definitions for vmstate
rust/pl011: add support for migration
rust/pl011: move CLK_NAME static to function scope
rust/pl011: add TYPE_PL011_LUMINARY device
rust/pl011: remove commented out C code
rust/pl011: Use correct masks for IBRD and FBRD
Paolo Bonzini (17):
rust/pl011: fix default value for migrate-clock
rust: patch bilge-impl to allow compilation with 1.63.0
rust: fix cfgs of proc-macro2 for 1.63.0
rust: use std::os::raw instead of core::ffi
rust: introduce a c_str macro
rust: silence unknown warnings for the sake of old compilers
rust: synchronize dependencies between subprojects and Cargo.lock
rust: create a cargo workspace
rust: introduce alternative implementation of offset_of!
rust: do not use MaybeUninit::zeroed()
rust: clean up detection of the language
rust: allow version 1.63.0 of rustc
rust: do not use --generate-cstr
rust: allow older version of bindgen
rust: make rustfmt optional
dockerfiles: install bindgen from cargo on Ubuntu 22.04
ci: enable rust in the Debian and Ubuntu system build job
docs/about/build-platforms.rst | 12 +
meson.build | 102 +++--
.gitattributes | 2 +
.gitlab-ci.d/buildtest.yml | 6 +-
meson_options.txt | 2 +
rust/{hw/char/pl011 => }/Cargo.lock | 4 +
rust/Cargo.toml | 7 +
rust/hw/char/pl011/Cargo.toml | 3 -
rust/hw/char/pl011/src/device.rs | 158 ++++++--
rust/hw/char/pl011/src/device_class.rs | 71 +++-
rust/hw/char/pl011/src/lib.rs | 5 +-
rust/hw/char/pl011/src/memory_ops.rs | 14 +-
rust/qemu-api-macros/Cargo.lock | 47 ---
rust/qemu-api-macros/Cargo.toml | 5 +-
rust/qemu-api-macros/src/lib.rs | 81 +++-
rust/qemu-api/Cargo.lock | 7 -
rust/qemu-api/Cargo.toml | 10 +-
rust/qemu-api/build.rs | 9 +
rust/qemu-api/meson.build | 17 +-
rust/qemu-api/src/c_str.rs | 53 +++
rust/qemu-api/src/definitions.rs | 2 +-
rust/qemu-api/src/device_class.rs | 43 +--
rust/qemu-api/src/lib.rs | 19 +-
rust/qemu-api/src/offset_of.rs | 161 ++++++++
rust/qemu-api/src/vmstate.rs | 358 ++++++++++++++++++
rust/qemu-api/src/zeroable.rs | 91 ++++-
rust/qemu-api/tests/tests.rs | 29 +-
scripts/meson-buildoptions.sh | 4 +
subprojects/bilge-impl-0.2-rs.wrap | 1 +
.../packagefiles/bilge-impl-1.63.0.patch | 45 +++
.../packagefiles/proc-macro2-1-rs/meson.build | 4 +-
subprojects/packagefiles/syn-2-rs/meson.build | 1 +
tests/docker/dockerfiles/ubuntu2204.docker | 5 +
tests/lcitool/mappings.yml | 4 +
tests/lcitool/refresh | 11 +-
35 files changed, 1166 insertions(+), 227 deletions(-)
rename rust/{hw/char/pl011 => }/Cargo.lock (98%)
create mode 100644 rust/Cargo.toml
delete mode 100644 rust/qemu-api-macros/Cargo.lock
delete mode 100644 rust/qemu-api/Cargo.lock
create mode 100644 rust/qemu-api/src/c_str.rs
create mode 100644 rust/qemu-api/src/offset_of.rs
create mode 100644 rust/qemu-api/src/vmstate.rs
create mode 100644 subprojects/packagefiles/bilge-impl-1.63.0.patch
--
2.47.0
next reply other threads:[~2024-10-25 16:09 UTC|newest]
Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-25 16:01 Paolo Bonzini [this message]
2024-10-25 16:01 ` [PATCH 01/23] rust: add definitions for vmstate Paolo Bonzini
2024-10-25 16:01 ` [PATCH 02/23] rust/pl011: fix default value for migrate-clock Paolo Bonzini
2024-10-25 16:01 ` [PATCH 03/23] rust/pl011: add support for migration Paolo Bonzini
2024-10-25 16:01 ` [PATCH 04/23] rust/pl011: move CLK_NAME static to function scope Paolo Bonzini
2024-10-25 16:01 ` [PATCH 05/23] rust/pl011: add TYPE_PL011_LUMINARY device Paolo Bonzini
2024-10-31 14:58 ` Zhao Liu
2024-10-25 16:01 ` [PATCH 06/23] rust/pl011: remove commented out C code Paolo Bonzini
2024-10-25 16:01 ` [PATCH 07/23] rust/pl011: Use correct masks for IBRD and FBRD Paolo Bonzini
2024-10-25 16:01 ` [PATCH 08/23] rust: patch bilge-impl to allow compilation with 1.63.0 Paolo Bonzini
2024-10-25 16:01 ` [PATCH 09/23] rust: fix cfgs of proc-macro2 for 1.63.0 Paolo Bonzini
2024-10-25 16:01 ` [PATCH 10/23] rust: use std::os::raw instead of core::ffi Paolo Bonzini
2024-10-25 16:01 ` [PATCH 11/23] rust: introduce a c_str macro Paolo Bonzini
2024-10-31 10:39 ` Zhao Liu
2024-10-25 16:01 ` [PATCH 12/23] rust: silence unknown warnings for the sake of old compilers Paolo Bonzini
2024-10-25 16:01 ` [PATCH 13/23] rust: synchronize dependencies between subprojects and Cargo.lock Paolo Bonzini
2024-10-31 11:31 ` Zhao Liu
2024-11-01 10:14 ` Junjie Mao
2024-11-01 15:30 ` Paolo Bonzini
2024-11-02 2:13 ` Junjie Mao
2024-10-25 16:01 ` [PATCH 14/23] rust: create a cargo workspace Paolo Bonzini
2024-10-31 13:46 ` Zhao Liu
2024-11-01 10:21 ` Junjie Mao
2024-10-25 16:02 ` [PATCH 15/23] rust: introduce alternative implementation of offset_of! Paolo Bonzini
2024-11-03 9:54 ` Junjie Mao
2024-11-04 16:02 ` Paolo Bonzini
2024-11-04 16:03 ` Paolo Bonzini
2024-11-04 16:03 ` Paolo Bonzini
2024-11-05 2:07 ` Junjie Mao
2024-10-25 16:02 ` [PATCH 16/23] rust: do not use MaybeUninit::zeroed() Paolo Bonzini
2024-10-25 16:02 ` [PATCH 17/23] rust: clean up detection of the language Paolo Bonzini
2024-10-25 16:02 ` [PATCH 18/23] rust: allow version 1.63.0 of rustc Paolo Bonzini
2024-10-25 16:02 ` [PATCH 19/23] rust: do not use --generate-cstr Paolo Bonzini
2024-10-25 20:03 ` Michael Tokarev
2024-10-25 20:06 ` Pierrick Bouvier
2024-10-25 20:10 ` Michael Tokarev
2024-10-25 20:12 ` Pierrick Bouvier
2024-10-25 20:11 ` Paolo Bonzini
2024-10-25 16:02 ` [PATCH 20/23] rust: allow older version of bindgen Paolo Bonzini
2024-10-25 16:02 ` [PATCH 21/23] rust: make rustfmt optional Paolo Bonzini
2024-10-25 16:02 ` [PATCH 22/23] dockerfiles: install bindgen from cargo on Ubuntu 22.04 Paolo Bonzini
2024-10-25 18:51 ` Pierrick Bouvier
2024-10-25 19:35 ` Paolo Bonzini
2024-10-25 19:47 ` Pierrick Bouvier
2024-10-25 20:08 ` Paolo Bonzini
2024-10-25 20:14 ` Pierrick Bouvier
2024-10-25 20:21 ` Paolo Bonzini
2024-10-25 20:08 ` Pierrick Bouvier
2024-10-25 16:02 ` [PATCH 23/23] ci: enable rust in the Debian and Ubuntu system build job Paolo Bonzini
2024-10-25 18:55 ` Pierrick Bouvier
2024-10-25 18:58 ` Pierrick Bouvier
2024-10-25 19:27 ` Paolo Bonzini
2024-10-25 19:33 ` Pierrick Bouvier
2024-10-25 20:08 ` Pierrick Bouvier
2024-10-25 16:23 ` [PATCH v3 00/23] rust: fix CI + allow older versions of rustc and bindgen Manos Pitsidianakis
2024-10-31 16:28 ` Paolo Bonzini
2024-10-27 7:01 ` Michael Tokarev
2024-10-27 8:00 ` Paolo Bonzini
2024-10-27 9:38 ` Michael Tokarev
2024-10-27 9:42 ` Michael Tokarev
2024-10-27 9:57 ` Michael Tokarev
2024-10-27 12:39 ` Paolo Bonzini
2024-10-28 9:21 ` Daniel P. Berrangé
2024-10-28 12:26 ` Alex Bennée
2024-10-28 12:41 ` Paolo Bonzini
2024-10-30 16:52 ` Paolo Bonzini
2024-10-31 16:41 ` Zhao Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241025160209.194307-1-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=berrange@redhat.com \
--cc=junjie.mao@hotmail.com \
--cc=manos.pitsidianakis@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=zhao1.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).