From: Cindy Lu <lulu@redhat.com>
To: lulu@redhat.com, mst@redhat.com, jasowang@redhat.com,
qemu-devel@nongnu.org
Subject: [PATCH v3 1/4] vhost_vdpa : Add a new parameter to enable check mac address
Date: Sat, 26 Oct 2024 15:59:59 +0800 [thread overview]
Message-ID: <20241026080121.461781-2-lulu@redhat.com> (raw)
In-Reply-To: <20241026080121.461781-1-lulu@redhat.com>
When using a VDPA device, it's important to ensure that the MAC
address is correctly set.
Add a new parameter in qemu cmdline to enable this check, default value
is false
The usage is:
....
-netdev type=vhost-vdpa,vhostdev=/dev/vhost-vdpa-0,id=vhost-vdpa0,macstrickcheck=true\
-device virtio-net-pci,netdev=vhost-vdpa0\
....
Signed-off-by: Cindy Lu <lulu@redhat.com>
---
include/net/net.h | 1 +
net/vhost-vdpa.c | 4 ++++
qapi/net.json | 5 +++++
3 files changed, 10 insertions(+)
diff --git a/include/net/net.h b/include/net/net.h
index c8f679761b..e00651a97b 100644
--- a/include/net/net.h
+++ b/include/net/net.h
@@ -112,6 +112,7 @@ struct NetClientState {
bool is_netdev;
bool do_not_pad; /* do not pad to the minimum ethernet frame length */
bool is_datapath;
+ bool check_mac;
QTAILQ_HEAD(, NetFilterState) filters;
};
diff --git a/net/vhost-vdpa.c b/net/vhost-vdpa.c
index 46b02c50be..071c3ff065 100644
--- a/net/vhost-vdpa.c
+++ b/net/vhost-vdpa.c
@@ -1860,6 +1860,8 @@ int net_init_vhost_vdpa(const Netdev *netdev, const char *name,
iova_range, features, shared, errp);
if (!ncs[i])
goto err;
+
+ ncs[i]->check_mac = opts->macstrickcheck;
}
if (has_cvq) {
@@ -1872,6 +1874,8 @@ int net_init_vhost_vdpa(const Netdev *netdev, const char *name,
errp);
if (!nc)
goto err;
+
+ nc->check_mac = opts->macstrickcheck;
}
return 0;
diff --git a/qapi/net.json b/qapi/net.json
index 87fc0d0b28..7d75119858 100644
--- a/qapi/net.json
+++ b/qapi/net.json
@@ -510,6 +510,10 @@
# @queues: number of queues to be created for multiqueue vhost-vdpa
# (default: 1)
#
+# @macstrickcheck: Enable the check for whether the device's MAC address
+# and the MAC in QEMU command line are acceptable for booting.
+# (default: false)
+#
# @x-svq: Start device with (experimental) shadow virtqueue. (Since
# 7.1) (default: false)
#
@@ -524,6 +528,7 @@
'*vhostdev': 'str',
'*vhostfd': 'str',
'*queues': 'int',
+ '*macstrickcheck': 'bool',
'*x-svq': {'type': 'bool', 'features' : [ 'unstable'] } } }
##
--
2.45.0
next prev parent reply other threads:[~2024-10-26 8:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-26 7:59 [PATCH v3 0/4] virtio_net: Add the check for vdpa's mac address Cindy Lu
2024-10-26 7:59 ` Cindy Lu [this message]
2024-11-06 9:25 ` [PATCH v3 1/4] vhost_vdpa : Add a new parameter to enable check " Michael S. Tsirkin
2024-11-06 9:42 ` Cindy Lu
2024-10-26 8:00 ` [PATCH v3 2/4] virtio_net: Add the check for vdpa's " Cindy Lu
2024-10-26 8:00 ` [PATCH v3 3/4] virtio_net: Add the 2rd acceptable situation for Mac setup Cindy Lu
2024-10-26 8:00 ` [PATCH v3 4/4] virtio_net: Add the 3rd " Cindy Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241026080121.461781-2-lulu@redhat.com \
--to=lulu@redhat.com \
--cc=jasowang@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).