From: Cindy Lu <lulu@redhat.com>
To: lulu@redhat.com, mst@redhat.com, jasowang@redhat.com,
qemu-devel@nongnu.org
Subject: [PATCH v3 4/4] virtio_net: Add the 3rd acceptable situation for Mac setup.
Date: Sat, 26 Oct 2024 16:00:02 +0800 [thread overview]
Message-ID: <20241026080121.461781-5-lulu@redhat.com> (raw)
In-Reply-To: <20241026080121.461781-1-lulu@redhat.com>
While the hardware MAC address is 0 and the MAC address in
the QEMU command line is also 0, this configuration is
acceptable.
Signed-off-by: Cindy Lu <lulu@redhat.com>
---
hw/net/virtio-net.c | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c
index 6900e3c44b..1e6a31baf8 100644
--- a/hw/net/virtio-net.c
+++ b/hw/net/virtio-net.c
@@ -3622,6 +3622,19 @@ static bool virtio_net_check_vdpa_mac(NetClientState *nc, VirtIONet *n,
return true;
}
}
+ /*
+ * 3.The hardware MAC address is 0,
+ * and the MAC address in the QEMU command line is also 0.
+ * In this situation, qemu will generate a random mac address
+ * QEMU will try to use CVQ/set_config to set this address to
+ * device
+ */
+ if ((memcmp(&hwcfg.mac, &zero, sizeof(MACAddr)) == 0) &&
+ (memcmp(cmdline_mac, &zero, sizeof(MACAddr)) == 0)) {
+ memcpy(&n->mac[0], &n->nic_conf.macaddr, sizeof(n->mac));
+
+ return true;
+ }
error_setg(errp,
"vDPA device's mac %02x:%02x:%02x:%02x:%02x:%02x"
--
2.45.0
prev parent reply other threads:[~2024-10-26 8:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-26 7:59 [PATCH v3 0/4] virtio_net: Add the check for vdpa's mac address Cindy Lu
2024-10-26 7:59 ` [PATCH v3 1/4] vhost_vdpa : Add a new parameter to enable check " Cindy Lu
2024-11-06 9:25 ` Michael S. Tsirkin
2024-11-06 9:42 ` Cindy Lu
2024-10-26 8:00 ` [PATCH v3 2/4] virtio_net: Add the check for vdpa's " Cindy Lu
2024-10-26 8:00 ` [PATCH v3 3/4] virtio_net: Add the 2rd acceptable situation for Mac setup Cindy Lu
2024-10-26 8:00 ` Cindy Lu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241026080121.461781-5-lulu@redhat.com \
--to=lulu@redhat.com \
--cc=jasowang@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).