qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Jan Luebbe <jlu@pengutronix.de>
To: qemu-devel@nongnu.org, "Cédric Le Goater" <clg@kaod.org>
Cc: "Jan Luebbe" <jlu@pengutronix.de>,
	"Guenter Roeck" <linux@roeck-us.net>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Peter Maydell" <peter.maydell@linaro.org>,
	"Thomas Huth" <thuth@redhat.com>, "Joel Stanley" <joel@jms.id.au>,
	qemu-arm@nongnu.org, qemu-block@nongnu.org
Subject: [PATCH] hw/sd/sdcard: Fix calculation of size when using eMMC boot partitions
Date: Mon, 28 Oct 2024 17:23:08 +0100	[thread overview]
Message-ID: <20241028162308.2152712-1-jlu@pengutronix.de> (raw)
In-Reply-To: <1bce4c22-9281-44c5-8acb-860881dc271c@kaod.org>

The sd_bootpart_offset() function calculates the *runtime* offset which
changes as the guest switches between accessing the main user data area
and the boot partitions by writing to the EXT_CSD_PART_CONFIG_ACC_MASK
bits, so it shouldn't be used to calculate the main user data area size.

Instead, subtract the boot_part_size directly (twice, as there are two
identical boot partitions defined by the eMMC spec).

Suggested-by: Cédric Le Goater <clg@kaod.org>
Signed-off-by: Jan Luebbe <jlu@pengutronix.de>
---
 hw/sd/sd.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/hw/sd/sd.c b/hw/sd/sd.c
index 2d3467c3d956..8430d5ae361c 100644
--- a/hw/sd/sd.c
+++ b/hw/sd/sd.c
@@ -826,7 +826,9 @@ static void sd_reset(DeviceState *dev)
         sect = 0;
     }
     size = sect << HWBLOCK_SHIFT;
-    size -= sd_bootpart_offset(sd);
+    if (sd_is_emmc(sd)) {
+        size -= sd->boot_part_size * 2;
+    }
 
     sect = sd_addr_to_wpnum(size) + 1;
 
-- 
2.39.5



  parent reply	other threads:[~2024-10-28 16:24 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-17 16:32 [PATCH 0/2] arm: Add collie and sx functional tests Peter Maydell
2024-10-17 16:32 ` [PATCH 1/2] tests/functional: Add a functional test for the collie board Peter Maydell
2024-10-17 17:15   ` Thomas Huth
2024-10-22  4:11   ` Philippe Mathieu-Daudé
2024-10-22  7:09     ` Daniel P. Berrangé
2024-10-22  9:02       ` Peter Maydell
2024-10-22 21:45         ` Philippe Mathieu-Daudé
2024-10-17 16:32 ` [PATCH 2/2] tests/functional: Add a functional test for the sx1 board Peter Maydell
2024-10-17 17:18   ` Thomas Huth
2024-10-21  7:15 ` [PATCH 0/2] arm: Add collie and sx functional tests Thomas Huth
2024-10-21  8:01   ` Thomas Huth
2024-10-21  9:17     ` Peter Maydell
2024-10-21  9:40       ` Thomas Huth
2024-10-21 14:02       ` Guenter Roeck
2024-10-22  4:09         ` Philippe Mathieu-Daudé
2024-10-22  5:24           ` Guenter Roeck
2024-10-22 15:04           ` Guenter Roeck
2024-10-24 17:59             ` Philippe Mathieu-Daudé
2024-10-25  6:55               ` Cédric Le Goater
2024-10-25  9:57                 ` Jan Lübbe
2024-10-25 13:59                   ` Guenter Roeck
2024-10-25 15:25                     ` Jan Lübbe
2024-10-25 17:05                       ` Guenter Roeck
2024-10-26  4:47                       ` Philippe Mathieu-Daudé
2024-10-26  5:54                         ` Guenter Roeck
2024-10-26 10:02                           ` Cédric Le Goater
2024-10-26 15:32                             ` Guenter Roeck
2024-10-27 21:13                               ` Cédric Le Goater
2024-10-27 22:11                                 ` Guenter Roeck
2024-10-27 22:26                                   ` Cédric Le Goater
2024-10-28  3:32                                     ` Guenter Roeck
2024-10-28  8:41                                       ` Jan Lübbe
2024-10-29 14:40                                         ` Guenter Roeck
2024-11-01 14:14                                           ` backing storage for eMMC boot partitions Jan Lübbe
2024-11-18  9:14                                             ` Cédric Le Goater
2024-11-18 12:15                                               ` Jan Lübbe
2024-11-18 12:36                                                 ` Cédric Le Goater
2024-10-28 16:23                             ` Jan Luebbe [this message]
2024-10-29  8:31                               ` [PATCH] hw/sd/sdcard: Fix calculation of size when using " Cédric Le Goater
2024-11-02 15:06                               ` Cédric Le Goater
2024-11-04 10:33                                 ` Philippe Mathieu-Daudé
2024-11-05 16:13                               ` Michael Tokarev
2024-11-05 16:31                                 ` Cédric Le Goater

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241028162308.2152712-1-jlu@pengutronix.de \
    --to=jlu@pengutronix.de \
    --cc=clg@kaod.org \
    --cc=joel@jms.id.au \
    --cc=linux@roeck-us.net \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).