From: Jamin Lin via <qemu-devel@nongnu.org>
To: "Cédric Le Goater" <clg@kaod.org>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Steven Lee" <steven_lee@aspeedtech.com>,
"Troy Lee" <leetroy@gmail.com>,
"Andrew Jeffery" <andrew@codeconstruct.com.au>,
"Joel Stanley" <joel@jms.id.au>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Bin Meng" <bmeng.cn@gmail.com>,
"open list:ASPEED BMCs" <qemu-arm@nongnu.org>,
"open list:All patches CC here" <qemu-devel@nongnu.org>,
"open list:SD (Secure Card)" <qemu-block@nongnu.org>
Cc: <jamin_lin@aspeedtech.com>, <troy_lee@aspeedtech.com>,
<yunlin.tang@aspeedtech.com>
Subject: [PATCH v1 8/8] aspeed: Support create flash devices via command line for AST1030
Date: Tue, 29 Oct 2024 17:17:29 +0800 [thread overview]
Message-ID: <20241029091729.3317512-9-jamin_lin@aspeedtech.com> (raw)
In-Reply-To: <20241029091729.3317512-1-jamin_lin@aspeedtech.com>
Add a "if-statement" in aspeed_minibmc_machine_init function. If users add
"-nodefaults" in command line, the flash devices should be created by users
setting. Otherwise, the flash devices are created at machine init.
Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>
---
hw/arm/aspeed.c | 22 ++++++++++++----------
1 file changed, 12 insertions(+), 10 deletions(-)
diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c
index 0468602d95..e161e6b1c5 100644
--- a/hw/arm/aspeed.c
+++ b/hw/arm/aspeed.c
@@ -1602,18 +1602,20 @@ static void aspeed_minibmc_machine_init(MachineState *machine)
connect_serial_hds_to_uarts(bmc);
qdev_realize(DEVICE(bmc->soc), NULL, &error_abort);
- aspeed_board_init_flashes(&bmc->soc->fmc,
- bmc->fmc_model ? bmc->fmc_model : amc->fmc_model,
- amc->num_cs,
- 0);
+ if (defaults_enabled()) {
+ aspeed_board_init_flashes(&bmc->soc->fmc,
+ bmc->fmc_model ? bmc->fmc_model : amc->fmc_model,
+ amc->num_cs,
+ 0);
- aspeed_board_init_flashes(&bmc->soc->spi[0],
- bmc->spi_model ? bmc->spi_model : amc->spi_model,
- amc->num_cs, amc->num_cs);
+ aspeed_board_init_flashes(&bmc->soc->spi[0],
+ bmc->spi_model ? bmc->spi_model : amc->spi_model,
+ amc->num_cs, amc->num_cs);
- aspeed_board_init_flashes(&bmc->soc->spi[1],
- bmc->spi_model ? bmc->spi_model : amc->spi_model,
- amc->num_cs, (amc->num_cs * 2));
+ aspeed_board_init_flashes(&bmc->soc->spi[1],
+ bmc->spi_model ? bmc->spi_model : amc->spi_model,
+ amc->num_cs, (amc->num_cs * 2));
+ }
if (amc->i2c_init) {
amc->i2c_init(bmc);
--
2.34.1
next prev parent reply other threads:[~2024-10-29 9:19 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-29 9:17 [PATCH v1 0/8] Support RTC for AST2700 Jamin Lin via
2024-10-29 9:17 ` [PATCH v1 1/8] aspeed/soc: " Jamin Lin via
2024-11-02 14:59 ` [SPAM] " Cédric Le Goater
2024-10-29 9:17 ` [PATCH v1 2/8] hw/timer/aspeed: Fix coding style Jamin Lin via
2024-11-02 15:01 ` [SPAM] " Cédric Le Goater
2024-10-29 9:17 ` [PATCH v1 3/8] hw/timer/aspeed: Fix interrupt status does not be cleared for AST2600 Jamin Lin via
2024-10-29 23:43 ` Andrew Jeffery
2024-11-02 14:59 ` [SPAM] " Cédric Le Goater
2024-10-29 9:17 ` [PATCH v1 4/8] hw/sd/sdhci: Fix coding style Jamin Lin via
2024-11-02 15:00 ` [SPAM] " Cédric Le Goater
2024-10-29 9:17 ` [PATCH v1 5/8] hw/sd/sdhci: Introduce a new Write Protected pin inverted property Jamin Lin via
2024-10-29 23:50 ` Andrew Jeffery
2024-10-30 2:10 ` Jamin Lin
2024-10-29 9:17 ` [PATCH v1 6/8] hw/sd/aspeed_sdhci: Introduce Capabilities Register 2 for SD slot 0 and 1 Jamin Lin via
2024-11-02 15:02 ` [SPAM] " Cédric Le Goater
2024-11-04 10:28 ` Philippe Mathieu-Daudé
2024-10-29 9:17 ` [PATCH v1 7/8] hw/arm/aspeed: Invert sdhci write protected pin for AST2600 and AST2500 EVBs Jamin Lin via
2024-10-30 0:20 ` Andrew Jeffery
2024-10-30 2:31 ` Jamin Lin
2024-10-29 9:17 ` Jamin Lin via [this message]
2024-11-02 15:02 ` [SPAM] [PATCH v1 8/8] aspeed: Support create flash devices via command line for AST1030 Cédric Le Goater
2024-11-02 15:03 ` [SPAM] [PATCH v1 0/8] Support RTC for AST2700 Cédric Le Goater
2024-11-04 1:16 ` Jamin Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241029091729.3317512-9-jamin_lin@aspeedtech.com \
--to=qemu-devel@nongnu.org \
--cc=andrew@codeconstruct.com.au \
--cc=bmeng.cn@gmail.com \
--cc=clg@kaod.org \
--cc=jamin_lin@aspeedtech.com \
--cc=joel@jms.id.au \
--cc=leetroy@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-block@nongnu.org \
--cc=steven_lee@aspeedtech.com \
--cc=troy_lee@aspeedtech.com \
--cc=yunlin.tang@aspeedtech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).