qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Prasad Pandit <ppandit@redhat.com>
To: qemu-devel@nongnu.org
Cc: Peter Xu <peterx@redhat.com>, Fabiano Rosas <farosas@suse.de>,
	Prasad Pandit <pjp@fedoraproject.org>
Subject: [PATCH 3/5] migration: remove multifd check with postcopy
Date: Tue, 29 Oct 2024 20:39:06 +0530	[thread overview]
Message-ID: <20241029150908.1136894-4-ppandit@redhat.com> (raw)
In-Reply-To: <20241029150908.1136894-1-ppandit@redhat.com>

From: Prasad Pandit <pjp@fedoraproject.org>

Remove multifd capability check with Postcopy mode.
This helps to enable both multifd and postcopy together.

Update migrate_multifd() to return false when migration
reaches Postcopy phase. In Postcopy phase, source guest
is paused, so the migration threads on the source stop
sending/pushing data on the channels. The destination
guest starts running and Postcopy threads there begin
to request/pull data from the source side.

Signed-off-by: Prasad Pandit <pjp@fedoraproject.org>
---
 migration/options.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/migration/options.c b/migration/options.c
index ad8d6989a8..47c5137d5f 100644
--- a/migration/options.c
+++ b/migration/options.c
@@ -266,7 +266,8 @@ bool migrate_multifd(void)
 {
     MigrationState *s = migrate_get_current();
 
-    return s->capabilities[MIGRATION_CAPABILITY_MULTIFD];
+    return s->capabilities[MIGRATION_CAPABILITY_MULTIFD]
+            && !migration_in_postcopy();
 }
 
 bool migrate_pause_before_switchover(void)
@@ -479,11 +480,6 @@ bool migrate_caps_check(bool *old_caps, bool *new_caps, Error **errp)
             error_setg(errp, "Postcopy is not compatible with ignore-shared");
             return false;
         }
-
-        if (new_caps[MIGRATION_CAPABILITY_MULTIFD]) {
-            error_setg(errp, "Postcopy is not yet compatible with multifd");
-            return false;
-        }
     }
 
     if (new_caps[MIGRATION_CAPABILITY_BACKGROUND_SNAPSHOT]) {
-- 
2.47.0



  parent reply	other threads:[~2024-10-29 15:10 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-29 15:09 [PATCH 0/5] Allow to enable multifd and postcopy migration together Prasad Pandit
2024-10-29 15:09 ` [PATCH 1/5] migration/multifd: move macros to multifd header Prasad Pandit
2024-10-29 15:09 ` [PATCH 2/5] migration/postcopy: magic value for postcopy channel Prasad Pandit
     [not found]   ` <ZyTnBwpOwXcHGGPJ@x1n>
2024-11-04 12:32     ` Prasad Pandit
2024-11-04 17:18       ` Peter Xu
2024-11-05 11:19         ` Prasad Pandit
2024-11-05 13:00           ` Peter Xu
2024-11-06 12:19             ` Prasad Pandit
2024-11-06 13:11               ` Fabiano Rosas
2024-11-07 12:05                 ` Prasad Pandit
2024-11-07 12:11                   ` Fabiano Rosas
2024-11-07 12:33                   ` Daniel P. Berrangé
2024-11-07 16:17                     ` Peter Xu
2024-11-07 16:57                       ` Daniel P. Berrangé
2024-11-07 17:45                         ` Peter Xu
2024-11-08 12:37                           ` Prasad Pandit
2024-11-08 13:25                             ` Fabiano Rosas
2024-11-06 16:00               ` Peter Xu
2024-11-07 11:52                 ` Prasad Pandit
2024-11-07 15:56                   ` Peter Xu
2024-10-29 15:09 ` Prasad Pandit [this message]
     [not found]   ` <ZyTnWYyHlrJUYQRB@x1n>
2024-11-04 12:23     ` [PATCH 3/5] migration: remove multifd check with postcopy Prasad Pandit
2024-11-04 16:52       ` Peter Xu
2024-11-05  9:50         ` Prasad Pandit
2024-10-29 15:09 ` [PATCH 4/5] migration: refactor ram_save_target_page functions Prasad Pandit
     [not found]   ` <ZyToBbvfWkIZ_40W@x1n>
2024-11-04 11:56     ` Prasad Pandit
2024-11-04 17:00       ` Peter Xu
2024-11-05 10:01         ` Prasad Pandit
2024-11-05 13:01           ` Peter Xu
2024-10-29 15:09 ` [PATCH 5/5] migration: enable multifd and postcopy together Prasad Pandit
2024-11-04 17:48   ` Peter Xu
2024-11-05 11:54     ` Prasad Pandit
2024-11-05 16:55       ` Peter Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241029150908.1136894-4-ppandit@redhat.com \
    --to=ppandit@redhat.com \
    --cc=farosas@suse.de \
    --cc=peterx@redhat.com \
    --cc=pjp@fedoraproject.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).