From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CAFF8D5CCA9 for ; Wed, 30 Oct 2024 13:04:52 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t68NA-0006Mq-T8; Wed, 30 Oct 2024 09:04:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t68N8-0006MI-AQ for qemu-devel@nongnu.org; Wed, 30 Oct 2024 09:04:26 -0400 Received: from frasgout.his.huawei.com ([185.176.79.56]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t68N5-00082e-CB for qemu-devel@nongnu.org; Wed, 30 Oct 2024 09:04:26 -0400 Received: from mail.maildlp.com (unknown [172.18.186.231]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4XdnMF3zMnz6K5mp; Wed, 30 Oct 2024 21:01:45 +0800 (CST) Received: from frapeml500008.china.huawei.com (unknown [7.182.85.71]) by mail.maildlp.com (Postfix) with ESMTPS id 9C130140B55; Wed, 30 Oct 2024 21:04:10 +0800 (CST) Received: from localhost (10.203.177.66) by frapeml500008.china.huawei.com (7.182.85.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Wed, 30 Oct 2024 14:04:10 +0100 Date: Wed, 30 Oct 2024 13:04:08 +0000 To: Fan Ni CC: , Markus Armbruster , , , , , Dave Jiang , Huang Ying , Michael Roth Subject: Re: [PATCH 2/6] hw/pci-bridge/cxl_upstream: Provide x-speed and x-width properties. Message-ID: <20241030130408.000008cb@Huawei.com> In-Reply-To: References: <20240916173518.1843023-1-Jonathan.Cameron@huawei.com> <20240916173518.1843023-3-Jonathan.Cameron@huawei.com> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.203.177.66] X-ClientProxiedBy: lhrpeml500004.china.huawei.com (7.191.163.9) To frapeml500008.china.huawei.com (7.182.85.71) Received-SPF: pass client-ip=185.176.79.56; envelope-from=jonathan.cameron@huawei.com; helo=frasgout.his.huawei.com X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Jonathan Cameron From: Jonathan Cameron via Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Tue, 29 Oct 2024 09:37:59 -0700 Fan Ni wrote: > On Mon, Sep 16, 2024 at 06:35:14PM +0100, Jonathan Cameron wrote: > > Copied from gen_pcie_root_port.c > > Drop the previous code that ensured a valid value in s->width, s->speed > > as now a default is provided so this will always be set. > > > > Note this changes the default settings but it is unlikely to have a negative > > effect on software as will only affect ports with now downstream device. > > All other ports will use the settings from that device. > > > > Signed-off-by: Jonathan Cameron > > --- > > hw/pci-bridge/cxl_downstream.c | 23 ++++++++++------------- > > 1 file changed, 10 insertions(+), 13 deletions(-) > > > > diff --git a/hw/pci-bridge/cxl_downstream.c b/hw/pci-bridge/cxl_downstream.c > > index 4b42984360..c347ac06f3 100644 > > --- a/hw/pci-bridge/cxl_downstream.c > > +++ b/hw/pci-bridge/cxl_downstream.c > > @@ -13,6 +13,8 @@ > > #include "hw/pci/msi.h" > > #include "hw/pci/pcie.h" > > #include "hw/pci/pcie_port.h" > > +#include "hw/qdev-properties.h" > > +#include "hw/qdev-properties-system.h" > > #include "hw/cxl/cxl.h" > > #include "qapi/error.h" > > > > @@ -210,24 +212,20 @@ static void cxl_dsp_exitfn(PCIDevice *d) > > pci_bridge_exitfn(d); > > } > > > > -static void cxl_dsp_instance_post_init(Object *obj) > > -{ > > - PCIESlot *s = PCIE_SLOT(obj); > > - > > - if (!s->speed) { > > - s->speed = QEMU_PCI_EXP_LNK_2_5GT; > > - } > > - > > - if (!s->width) { > > - s->width = QEMU_PCI_EXP_LNK_X1; > > - } > > -} > > +static Property cxl_dsp_props[] = { > > + DEFINE_PROP_PCIE_LINK_SPEED("x-speed", PCIESlot, > > + speed, PCIE_LINK_SPEED_64), > > + DEFINE_PROP_PCIE_LINK_WIDTH("x-width", PCIESlot, > > + width, PCIE_LINK_WIDTH_16), > > Not sure why. For the root port, we use PCIE_LINK_WIDTH_32, and here it is > PCIE_LINK_WIDTH_16? Random choice. There is no obvious default to choose. I'm fine changing them to another choice if that makes more sense. Jonathan > > Fan > > > + DEFINE_PROP_END_OF_LIST() > > +}; > > > > static void cxl_dsp_class_init(ObjectClass *oc, void *data) > > { > > DeviceClass *dc = DEVICE_CLASS(oc); > > PCIDeviceClass *k = PCI_DEVICE_CLASS(oc); > > > > + device_class_set_props(dc, cxl_dsp_props); > > k->config_write = cxl_dsp_config_write; > > k->realize = cxl_dsp_realize; > > k->exit = cxl_dsp_exitfn; > > @@ -243,7 +241,6 @@ static const TypeInfo cxl_dsp_info = { > > .name = TYPE_CXL_DSP, > > .instance_size = sizeof(CXLDownstreamPort), > > .parent = TYPE_PCIE_SLOT, > > - .instance_post_init = cxl_dsp_instance_post_init, > > .class_init = cxl_dsp_class_init, > > .interfaces = (InterfaceInfo[]) { > > { INTERFACE_PCIE_DEVICE }, > > -- > > 2.43.0 > > >