qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Xu <peterx@redhat.com>
To: qemu-devel@nongnu.org
Cc: Fabiano Rosas <farosas@suse.de>,
	Peter Maydell <peter.maydell@linaro.org>,
	"Maciej S. Szmigiero" <maciej.szmigiero@oracle.com>,
	Peter Xu <peterx@redhat.com>
Subject: [PULL 18/18] migration/multifd: Zero p->flags before starting filling a packet
Date: Wed, 30 Oct 2024 11:57:34 -0400	[thread overview]
Message-ID: <20241030155734.2141398-19-peterx@redhat.com> (raw)
In-Reply-To: <20241030155734.2141398-1-peterx@redhat.com>

From: "Maciej S. Szmigiero" <maciej.szmigiero@oracle.com>

This way there aren't stale flags there.

p->flags can't contain SYNC to be sent at the next RAM packet since syncs
are now handled separately in multifd_send_thread.

Reviewed-by: Fabiano Rosas <farosas@suse.de>
Reviewed-by: Peter Xu <peterx@redhat.com>
Signed-off-by: Maciej S. Szmigiero <maciej.szmigiero@oracle.com>
Link: https://lore.kernel.org/r/1c96b6cdb797e6f035eb1a4ad9bfc24f4c7f5df8.1730203967.git.maciej.szmigiero@oracle.com
Signed-off-by: Peter Xu <peterx@redhat.com>
---
 migration/multifd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/migration/multifd.c b/migration/multifd.c
index 697fe86fdf..4374e14a96 100644
--- a/migration/multifd.c
+++ b/migration/multifd.c
@@ -600,6 +600,7 @@ static void *multifd_send_thread(void *opaque)
          * qatomic_store_release() in multifd_send().
          */
         if (qatomic_load_acquire(&p->pending_job)) {
+            p->flags = 0;
             p->iovs_num = 0;
             assert(!multifd_payload_empty(p->data));
 
@@ -651,7 +652,6 @@ static void *multifd_send_thread(void *opaque)
                 }
                 /* p->next_packet_size will always be zero for a SYNC packet */
                 stat64_add(&mig_stats.multifd_bytes, p->packet_len);
-                p->flags = 0;
             }
 
             qatomic_set(&p->pending_sync, false);
-- 
2.45.0



  parent reply	other threads:[~2024-10-30 15:59 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-30 15:57 [PULL 00/18] Migration 20241030 patches Peter Xu
2024-10-30 15:57 ` [PULL 01/18] migration: Cleanup migrate_fd_cleanup() on accessing to_dst_file Peter Xu
2024-10-30 15:57 ` [PULL 02/18] migration: Put thread names together with macros Peter Xu
2024-10-30 15:57 ` [PULL 03/18] migration: Ensure vmstate_save() sets errp Peter Xu
2024-10-30 15:57 ` [PULL 04/18] accel/tcg/icount-common: Remove the reference to the unused header file Peter Xu
2024-10-30 15:57 ` [PULL 05/18] migration: Stop CPU throttling conditionally Peter Xu
2024-10-30 15:57 ` [PULL 06/18] migration: Move cpu-throttole.c from system to migration Peter Xu
2024-10-30 15:57 ` [PULL 07/18] migration: Remove "rs" parameter in migration_bitmap_sync_precopy Peter Xu
2024-10-30 15:57 ` [PULL 08/18] migration: Support periodic RAMBlock dirty bitmap sync Peter Xu
2024-10-30 15:57 ` [PULL 09/18] tests/migration: Add case for periodic ramblock dirty sync Peter Xu
2024-10-30 15:57 ` [PULL 10/18] migration/dirtyrate: Silence warning about strcpy() on OpenBSD Peter Xu
2024-10-30 15:57 ` [PULL 11/18] migration: Deprecate query-migrationthreads command Peter Xu
2024-10-30 15:57 ` [PULL 12/18] migration: Take migration object refcount earlier for threads Peter Xu
2024-10-30 15:57 ` [PULL 13/18] migration: Unexport dirty_bitmap_mig_init() Peter Xu
2024-10-30 15:57 ` [PULL 14/18] migration: Unexport ram_mig_init() Peter Xu
2024-10-30 15:57 ` [PULL 15/18] migration: Drop migration_is_setup_or_active() Peter Xu
2024-10-30 15:57 ` [PULL 16/18] migration: Drop migration_is_idle() Peter Xu
2024-10-30 15:57 ` [PULL 17/18] migration/ram: Add load start trace event Peter Xu
2024-10-30 15:57 ` Peter Xu [this message]
2024-10-31 13:28 ` [PULL 00/18] Migration 20241030 patches Peter Maydell
2024-10-31 14:50   ` Peter Xu
2024-10-31 14:52     ` Peter Maydell
2024-10-31 15:14       ` Peter Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241030155734.2141398-19-peterx@redhat.com \
    --to=peterx@redhat.com \
    --cc=farosas@suse.de \
    --cc=maciej.szmigiero@oracle.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).