From: John Snow <jsnow@redhat.com>
To: qemu-devel@nongnu.org
Cc: qemu-block@nongnu.org, Kevin Wolf <kwolf@redhat.com>,
Cleber Rosa <crosa@redhat.com>, Hanna Reitz <hreitz@redhat.com>,
John Snow <jsnow@redhat.com>
Subject: [PATCH 4/4] python: silence pylint raising-non-exception error
Date: Fri, 1 Nov 2024 13:37:00 -0400 [thread overview]
Message-ID: <20241101173700.965776-5-jsnow@redhat.com> (raw)
In-Reply-To: <20241101173700.965776-1-jsnow@redhat.com>
As of (at least) pylint 3.3.1, this code trips pylint up into believing
we are raising something other than an Exception. We are not: the first
two values may indeed be "None", but the last and final value must by
definition be a SystemExit exception.
Signed-off-by: John Snow <jsnow@redhat.com>
---
python/scripts/mkvenv.py | 3 +++
1 file changed, 3 insertions(+)
diff --git a/python/scripts/mkvenv.py b/python/scripts/mkvenv.py
index f2526af0a04..8ac5b0b2a05 100644
--- a/python/scripts/mkvenv.py
+++ b/python/scripts/mkvenv.py
@@ -379,6 +379,9 @@ def make_venv( # pylint: disable=too-many-arguments
try:
builder.create(str(env_dir))
except SystemExit as exc:
+ # pylint 3.3 bug:
+ # pylint: disable=raising-non-exception, raise-missing-from
+
# Some versions of the venv module raise SystemExit; *nasty*!
# We want the exception that prompted it. It might be a subprocess
# error that has output we *really* want to see.
--
2.47.0
next prev parent reply other threads:[~2024-11-01 17:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-01 17:36 [PATCH 0/4] python: update linting for new mypy/pylint releases John Snow
2024-11-01 17:36 ` [PATCH 1/4] iotests: reflow ReproducibleTestRunner arguments John Snow
2024-11-01 17:36 ` [PATCH 2/4] iotests: correct resultclass type in ReproducibleTestRunner John Snow
2024-11-01 17:36 ` [PATCH 3/4] python: disable too-many-positional-arguments warning John Snow
2024-11-01 17:37 ` John Snow [this message]
2024-11-06 9:57 ` [PATCH 0/4] python: update linting for new mypy/pylint releases Kevin Wolf
2024-11-07 16:58 ` John Snow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241101173700.965776-5-jsnow@redhat.com \
--to=jsnow@redhat.com \
--cc=crosa@redhat.com \
--cc=hreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).