From: dan tan <dantan@linux.vnet.ibm.com>
To: qemu-devel@nongnu.org
Cc: qemu-ppc@nongnu.org, stefanb@linux.vnet.ibm.com,
pbonzini@redhat.com, farosas@suse.de, lvivier@redhat.com,
clg@kaod.org
Subject: [PATCH v3 0/5] TPM TIS SPI Support
Date: Fri, 1 Nov 2024 13:57:13 -0500 [thread overview]
Message-ID: <20241101185718.5847-1-dantan@linux.vnet.ibm.com> (raw)
*** BLURB HERE ***
Support TPM for SPI (Serial Peripheral Interface)
Revision 3 summary:
device support:
- moved variable tis_addr from TPMStateSPI struct to local
- added the VM suspend/resume support:
- added vmstate_tpm_tis_spi declaration
- added tpm_tis_spi_pre_save() function
- fixed trace formatting string
qtest:
- removed the function prototypes declaration
- fixed code format to comply with convention
- changed function names and variable names to be the same
as the tpm-tis-i2c test.
- change hard coded numbers to #define's with meaningful
names that are identifiable with spec documentation
Version 2 summary,
addressed the following review comments:
- break up patch into 3 separate commits;
- add more details in the commit logs;
- I added links to the TCG TPM standard documents as this device
model communicates to the TPM device (hw / swtpm) via
tpm_tis_commom.c which is standard compliant;
- the TPM SPI model implementation in itself is not platform
specific. However, the SPI interface is via the PowerNV SPI
bus master, thus it is only supported on the PowerNV platform
- change all qemu_log() calls to trace events;
- move static global variables to the TPMStateSPI struct;
- fixed code formatting (verified by scripts/checkpatch.pl);
- per requests, make the code more readable by using self-
explanatory #defines and adding comments;
- added some documentation support (tpm.rst);
- beefed up the unit test exercising major supported locality
functionality
dan tan (5):
tpm/tpm_tis_spi: Support TPM for SPI (Serial Peripheral Interface)
tpm/tpm_tis_spi: activation for the PowerNV machines
tests/qtest/tpm: add unit test to tis-spi
tpm/tpm_tis_spi: Support TPM for SPI (rev 3)
tests/qtest/tpm: add unit test to tis-spi (rev 3)
docs/specs/tpm.rst | 15 +
include/sysemu/tpm.h | 3 +
hw/tpm/tpm_tis_spi.c | 360 +++++++++++++++
tests/qtest/tpm-tis-spi-pnv-test.c | 710 +++++++++++++++++++++++++++++
hw/ppc/Kconfig | 1 +
hw/tpm/Kconfig | 6 +
hw/tpm/meson.build | 1 +
hw/tpm/trace-events | 7 +
tests/qtest/meson.build | 2 +
9 files changed, 1105 insertions(+)
create mode 100644 hw/tpm/tpm_tis_spi.c
create mode 100644 tests/qtest/tpm-tis-spi-pnv-test.c
--
2.39.5
next reply other threads:[~2024-11-01 18:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-01 18:57 dan tan [this message]
2024-11-01 18:57 ` [PATCH v3 1/5] tpm/tpm_tis_spi: Support TPM for SPI (Serial Peripheral Interface) dan tan
2024-11-01 18:57 ` [PATCH v3 2/5] tpm/tpm_tis_spi: activation for the PowerNV machines dan tan
2024-11-01 18:57 ` [PATCH v3 3/5] tests/qtest/tpm: add unit test to tis-spi dan tan
2024-11-01 18:57 ` [PATCH v3 4/5] tpm/tpm_tis_spi: Support TPM for SPI (rev 3) dan tan
2024-11-01 18:57 ` [PATCH v3 5/5] tests/qtest/tpm: add unit test to tis-spi " dan tan
2024-11-01 19:25 ` [PATCH v3 0/5] TPM TIS SPI Support Stefan Berger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241101185718.5847-1-dantan@linux.vnet.ibm.com \
--to=dantan@linux.vnet.ibm.com \
--cc=clg@kaod.org \
--cc=farosas@suse.de \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=stefanb@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).