qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Bernhard Beschow <shentey@gmail.com>
To: qemu-devel@nongnu.org
Cc: "Jason Wang" <jasowang@redhat.com>,
	qemu-ppc@nongnu.org, "Cédric Le Goater" <clg@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Hanna Reitz" <hreitz@redhat.com>,
	"Nicholas Piggin" <npiggin@gmail.com>,
	"Corey Minyard" <cminyard@mvista.com>,
	"Kevin Wolf" <kwolf@redhat.com>, "Bin Meng" <bmeng.cn@gmail.com>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Bernhard Beschow" <shentey@gmail.com>,
	qemu-block@nongnu.org,
	"Alex Williamson" <alex.williamson@redhat.com>,
	"Daniel Henrique Barboza" <danielhb413@gmail.com>,
	"Akihiko Odaki" <akihiko.odaki@daynix.com>
Subject: [PATCH v4 15/26] hw/net/fsl_etsec/miim: Reuse MII constants
Date: Sun,  3 Nov 2024 14:34:01 +0100	[thread overview]
Message-ID: <20241103133412.73536-16-shentey@gmail.com> (raw)
In-Reply-To: <20241103133412.73536-1-shentey@gmail.com>

Instead of defining redundant constants and using magic numbers reuse the
existing MII constants.

Signed-off-by: Bernhard Beschow <shentey@gmail.com>
cc: Akihiko Odaki <akihiko.odaki@daynix.com>
---
 hw/net/fsl_etsec/miim.c | 19 ++++++-------------
 1 file changed, 6 insertions(+), 13 deletions(-)

diff --git a/hw/net/fsl_etsec/miim.c b/hw/net/fsl_etsec/miim.c
index b48d2cb57b..4e9169907a 100644
--- a/hw/net/fsl_etsec/miim.c
+++ b/hw/net/fsl_etsec/miim.c
@@ -29,13 +29,6 @@
 
 /* #define DEBUG_MIIM */
 
-#define MIIM_CONTROL    0
-#define MIIM_STATUS     1
-#define MIIM_PHY_ID_1   2
-#define MIIM_PHY_ID_2   3
-#define MIIM_T2_STATUS  10
-#define MIIM_EXT_STATUS 15
-
 static void miim_read_cycle(eTSEC *etsec)
 {
     uint8_t  phy;
@@ -47,14 +40,14 @@ static void miim_read_cycle(eTSEC *etsec)
     addr = etsec->regs[MIIMADD].value & 0x1F;
 
     switch (addr) {
-    case MIIM_CONTROL:
+    case MII_BMCR:
         value = etsec->phy_control;
         break;
-    case MIIM_STATUS:
+    case MII_BMSR:
         value = etsec->phy_status;
         break;
-    case MIIM_T2_STATUS:
-        value = 0x1800;           /* Local and remote receivers OK */
+    case MII_STAT1000:
+        value = MII_STAT1000_LOK | MII_STAT1000_ROK;
         break;
     default:
         value = 0x0;
@@ -84,8 +77,8 @@ static void miim_write_cycle(eTSEC *etsec)
 #endif
 
     switch (addr) {
-    case MIIM_CONTROL:
-        etsec->phy_control = value & ~(0x8100);
+    case MII_BMCR:
+        etsec->phy_control = value & ~(MII_BMCR_RESET | MII_BMCR_FD);
         break;
     default:
         break;
-- 
2.47.0



  parent reply	other threads:[~2024-11-03 13:42 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-03 13:33 [PATCH v4 00/26] E500 Cleanup Bernhard Beschow
2024-11-03 13:33 ` [PATCH v4 01/26] hw/ppc/e500: Do not leak struct boot_info Bernhard Beschow
2024-11-03 13:33 ` [PATCH v4 02/26] hw/ppc/e500: Remove firstenv variable Bernhard Beschow
2024-11-03 13:33 ` [PATCH v4 03/26] hw/ppc/e500: Prefer QOM cast Bernhard Beschow
2024-11-03 13:33 ` [PATCH v4 04/26] hw/ppc/e500: Remove unused "irqs" parameter Bernhard Beschow
2024-11-03 13:33 ` [PATCH v4 05/26] hw/ppc/e500: Add missing device tree properties to i2c controller node Bernhard Beschow
2024-11-03 13:33 ` [PATCH v4 06/26] hw/ppc/e500: Reuse TYPE_GPIO_PWR Bernhard Beschow
2024-11-03 13:33 ` [PATCH v4 07/26] hw/ppc/e500: Use SysBusDevice API to access TYPE_CCSR's internal resources Bernhard Beschow
2024-11-03 13:33 ` [PATCH v4 08/26] hw/ppc/e500: Extract ppce500_ccsr.c Bernhard Beschow
2024-11-03 13:33 ` [PATCH v4 09/26] hw/ppc/ppce500_ccsr: Trace access to CCSR region Bernhard Beschow
2024-11-03 13:33 ` [PATCH v4 10/26] hw/ppc/mpc8544_guts: Populate POR PLL ratio status register Bernhard Beschow
2024-11-03 13:33 ` [PATCH v4 11/26] hw/i2c/mpc_i2c: Convert DPRINTF to trace events for register access Bernhard Beschow
2024-11-03 13:33 ` [PATCH v4 12/26] hw/i2c/mpc_i2c: Prefer DEFINE_TYPES() macro Bernhard Beschow
2024-11-04 12:13   ` Corey Minyard
2024-11-03 13:33 ` [PATCH v4 13/26] hw/pci-host/ppce500: Reuse TYPE_PPC_E500_PCI_BRIDGE define Bernhard Beschow
2024-11-03 13:34 ` [PATCH v4 14/26] hw/pci-host/ppce500: Prefer DEFINE_TYPES() macro Bernhard Beschow
2024-11-03 13:34 ` Bernhard Beschow [this message]
2024-11-05  7:42   ` [PATCH v4 15/26] hw/net/fsl_etsec/miim: Reuse MII constants Akihiko Odaki
2024-11-03 13:34 ` [PATCH v4 16/26] hw/net/fsl_etsec/etsec: Prefer DEFINE_TYPES() macro Bernhard Beschow
2024-11-03 13:34 ` [PATCH v4 17/26] hw/gpio/mpc8xxx: " Bernhard Beschow
2024-11-03 13:34 ` [PATCH v4 18/26] hw/ppc/mpc8544_guts: " Bernhard Beschow
2024-11-03 13:34 ` [PATCH v4 19/26] hw/intc: Guard openpic_kvm.c by dedicated OPENPIC_KVM Kconfig switch Bernhard Beschow
2024-11-03 13:34 ` [PATCH v4 20/26] hw/sd/sdhci: Prefer DEFINE_TYPES() macro Bernhard Beschow
2024-11-03 13:34 ` [PATCH v4 21/26] hw/block/pflash_cfi01: " Bernhard Beschow
2024-11-03 13:34 ` [PATCH v4 22/26] hw/i2c/smbus_eeprom: " Bernhard Beschow
2024-11-04 12:13   ` Corey Minyard
2024-11-03 13:34 ` [PATCH v4 23/26] hw/rtc/ds1338: " Bernhard Beschow
2024-11-03 13:34 ` [PATCH v4 24/26] hw/usb/hcd-ehci-sysbus: " Bernhard Beschow
2024-11-03 13:34 ` [PATCH v4 25/26] hw/vfio/platform: Let vfio_start_eventfd_injection() take VFIOPlatformDevice pointer Bernhard Beschow
2024-11-03 13:34 ` [PATCH v4 26/26] MAINTAINERS: Add hw/gpio/gpio_pwr.c Bernhard Beschow
2024-11-05 22:55 ` [PATCH v4 00/26] E500 Cleanup Philippe Mathieu-Daudé
2024-11-06 18:34   ` Bernhard Beschow

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241103133412.73536-16-shentey@gmail.com \
    --to=shentey@gmail.com \
    --cc=akihiko.odaki@daynix.com \
    --cc=alex.williamson@redhat.com \
    --cc=bmeng.cn@gmail.com \
    --cc=clg@redhat.com \
    --cc=cminyard@mvista.com \
    --cc=danielhb413@gmail.com \
    --cc=hreitz@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=npiggin@gmail.com \
    --cc=pbonzini@redhat.com \
    --cc=philmd@linaro.org \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).