From: Bernhard Beschow <shentey@gmail.com>
To: qemu-devel@nongnu.org
Cc: "Jason Wang" <jasowang@redhat.com>,
qemu-ppc@nongnu.org, "Cédric Le Goater" <clg@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Hanna Reitz" <hreitz@redhat.com>,
"Nicholas Piggin" <npiggin@gmail.com>,
"Corey Minyard" <cminyard@mvista.com>,
"Kevin Wolf" <kwolf@redhat.com>, "Bin Meng" <bmeng.cn@gmail.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Bernhard Beschow" <shentey@gmail.com>,
qemu-block@nongnu.org,
"Alex Williamson" <alex.williamson@redhat.com>,
"Daniel Henrique Barboza" <danielhb413@gmail.com>
Subject: [PATCH v4 05/26] hw/ppc/e500: Add missing device tree properties to i2c controller node
Date: Sun, 3 Nov 2024 14:33:51 +0100 [thread overview]
Message-ID: <20241103133412.73536-6-shentey@gmail.com> (raw)
In-Reply-To: <20241103133412.73536-1-shentey@gmail.com>
When compiling a decompiled device tree blob created with dumpdtb, dtc complains
with:
/soc@e0000000/i2c@3000: incorrect #address-cells for I2C bus
/soc@e0000000/i2c@3000: incorrect #size-cells for I2C bus
Fix this by adding the missing device tree properties.
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Signed-off-by: Bernhard Beschow <shentey@gmail.com>
---
hw/ppc/e500.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/ppc/e500.c b/hw/ppc/e500.c
index ecaaab1558..a0c856568b 100644
--- a/hw/ppc/e500.c
+++ b/hw/ppc/e500.c
@@ -196,6 +196,8 @@ static void dt_i2c_create(void *fdt, const char *soc, const char *mpic,
qemu_fdt_setprop_cells(fdt, i2c, "cell-index", 0);
qemu_fdt_setprop_cells(fdt, i2c, "interrupts", irq0, 0x2);
qemu_fdt_setprop_phandle(fdt, i2c, "interrupt-parent", mpic);
+ qemu_fdt_setprop_cell(fdt, i2c, "#size-cells", 0);
+ qemu_fdt_setprop_cell(fdt, i2c, "#address-cells", 1);
qemu_fdt_setprop_string(fdt, "/aliases", alias, i2c);
g_free(i2c);
--
2.47.0
next prev parent reply other threads:[~2024-11-03 13:42 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-03 13:33 [PATCH v4 00/26] E500 Cleanup Bernhard Beschow
2024-11-03 13:33 ` [PATCH v4 01/26] hw/ppc/e500: Do not leak struct boot_info Bernhard Beschow
2024-11-03 13:33 ` [PATCH v4 02/26] hw/ppc/e500: Remove firstenv variable Bernhard Beschow
2024-11-03 13:33 ` [PATCH v4 03/26] hw/ppc/e500: Prefer QOM cast Bernhard Beschow
2024-11-03 13:33 ` [PATCH v4 04/26] hw/ppc/e500: Remove unused "irqs" parameter Bernhard Beschow
2024-11-03 13:33 ` Bernhard Beschow [this message]
2024-11-03 13:33 ` [PATCH v4 06/26] hw/ppc/e500: Reuse TYPE_GPIO_PWR Bernhard Beschow
2024-11-03 13:33 ` [PATCH v4 07/26] hw/ppc/e500: Use SysBusDevice API to access TYPE_CCSR's internal resources Bernhard Beschow
2024-11-03 13:33 ` [PATCH v4 08/26] hw/ppc/e500: Extract ppce500_ccsr.c Bernhard Beschow
2024-11-03 13:33 ` [PATCH v4 09/26] hw/ppc/ppce500_ccsr: Trace access to CCSR region Bernhard Beschow
2024-11-03 13:33 ` [PATCH v4 10/26] hw/ppc/mpc8544_guts: Populate POR PLL ratio status register Bernhard Beschow
2024-11-03 13:33 ` [PATCH v4 11/26] hw/i2c/mpc_i2c: Convert DPRINTF to trace events for register access Bernhard Beschow
2024-11-03 13:33 ` [PATCH v4 12/26] hw/i2c/mpc_i2c: Prefer DEFINE_TYPES() macro Bernhard Beschow
2024-11-04 12:13 ` Corey Minyard
2024-11-03 13:33 ` [PATCH v4 13/26] hw/pci-host/ppce500: Reuse TYPE_PPC_E500_PCI_BRIDGE define Bernhard Beschow
2024-11-03 13:34 ` [PATCH v4 14/26] hw/pci-host/ppce500: Prefer DEFINE_TYPES() macro Bernhard Beschow
2024-11-03 13:34 ` [PATCH v4 15/26] hw/net/fsl_etsec/miim: Reuse MII constants Bernhard Beschow
2024-11-05 7:42 ` Akihiko Odaki
2024-11-03 13:34 ` [PATCH v4 16/26] hw/net/fsl_etsec/etsec: Prefer DEFINE_TYPES() macro Bernhard Beschow
2024-11-03 13:34 ` [PATCH v4 17/26] hw/gpio/mpc8xxx: " Bernhard Beschow
2024-11-03 13:34 ` [PATCH v4 18/26] hw/ppc/mpc8544_guts: " Bernhard Beschow
2024-11-03 13:34 ` [PATCH v4 19/26] hw/intc: Guard openpic_kvm.c by dedicated OPENPIC_KVM Kconfig switch Bernhard Beschow
2024-11-03 13:34 ` [PATCH v4 20/26] hw/sd/sdhci: Prefer DEFINE_TYPES() macro Bernhard Beschow
2024-11-03 13:34 ` [PATCH v4 21/26] hw/block/pflash_cfi01: " Bernhard Beschow
2024-11-03 13:34 ` [PATCH v4 22/26] hw/i2c/smbus_eeprom: " Bernhard Beschow
2024-11-04 12:13 ` Corey Minyard
2024-11-03 13:34 ` [PATCH v4 23/26] hw/rtc/ds1338: " Bernhard Beschow
2024-11-03 13:34 ` [PATCH v4 24/26] hw/usb/hcd-ehci-sysbus: " Bernhard Beschow
2024-11-03 13:34 ` [PATCH v4 25/26] hw/vfio/platform: Let vfio_start_eventfd_injection() take VFIOPlatformDevice pointer Bernhard Beschow
2024-11-03 13:34 ` [PATCH v4 26/26] MAINTAINERS: Add hw/gpio/gpio_pwr.c Bernhard Beschow
2024-11-05 22:55 ` [PATCH v4 00/26] E500 Cleanup Philippe Mathieu-Daudé
2024-11-06 18:34 ` Bernhard Beschow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241103133412.73536-6-shentey@gmail.com \
--to=shentey@gmail.com \
--cc=alex.williamson@redhat.com \
--cc=bmeng.cn@gmail.com \
--cc=clg@redhat.com \
--cc=cminyard@mvista.com \
--cc=danielhb413@gmail.com \
--cc=hreitz@redhat.com \
--cc=jasowang@redhat.com \
--cc=kwolf@redhat.com \
--cc=npiggin@gmail.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).