From: Bernhard Beschow <shentey@gmail.com>
To: qemu-devel@nongnu.org
Cc: "Daniel P. Berrangé" <berrange@redhat.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Jean-Christophe Dubois" <jcd@tribudubois.net>,
qemu-arm@nongnu.org, "Michael Tokarev" <mjt@tls.msk.ru>,
"Laurent Vivier" <laurent@vivier.eu>,
qemu-trivial@nongnu.org,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Bernhard Beschow" <shentey@gmail.com>,
"Guenter Roeck" <linux@roeck-us.net>
Subject: [PATCH v2 3/4] hw/watchdog/wdt_imx2: Remove redundant assignment
Date: Sun, 3 Nov 2024 15:33:29 +0100 [thread overview]
Message-ID: <20241103143330.123596-4-shentey@gmail.com> (raw)
In-Reply-To: <20241103143330.123596-1-shentey@gmail.com>
The same statement is executed unconditionally right before the if statement.
Cc: Guenter Roeck <linux@roeck-us.net>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Bernhard Beschow <shentey@gmail.com>
---
hw/watchdog/wdt_imx2.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/watchdog/wdt_imx2.c b/hw/watchdog/wdt_imx2.c
index be63d421da..8162d58afa 100644
--- a/hw/watchdog/wdt_imx2.c
+++ b/hw/watchdog/wdt_imx2.c
@@ -39,7 +39,6 @@ static void imx2_wdt_expired(void *opaque)
/* Perform watchdog action if watchdog is enabled */
if (s->wcr & IMX2_WDT_WCR_WDE) {
- s->wrsr = IMX2_WDT_WRSR_TOUT;
watchdog_perform_action();
}
}
--
2.47.0
next prev parent reply other threads:[~2024-11-03 14:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-03 14:33 [PATCH v2 0/4] Trivial ARM changes Bernhard Beschow
2024-11-03 14:33 ` [PATCH v2 1/4] hw/rtc/ds1338: Trace send and receive operations Bernhard Beschow
2024-11-03 14:33 ` [PATCH v2 2/4] hw/timer/imx_gpt: Convert DPRINTF to trace events Bernhard Beschow
2024-11-03 14:33 ` Bernhard Beschow [this message]
2024-11-04 11:20 ` [PATCH v2 3/4] hw/watchdog/wdt_imx2: Remove redundant assignment Richard Henderson
2024-11-03 14:33 ` [PATCH v2 4/4] hw/sensor/tmp105: Convert printf() to trace event, add tracing for read/write access Bernhard Beschow
2024-11-03 20:25 ` Philippe Mathieu-Daudé
2024-11-04 13:50 ` [PATCH v2 0/4] Trivial ARM changes Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241103143330.123596-4-shentey@gmail.com \
--to=shentey@gmail.com \
--cc=berrange@redhat.com \
--cc=jcd@tribudubois.net \
--cc=laurent@vivier.eu \
--cc=linux@roeck-us.net \
--cc=marcandre.lureau@redhat.com \
--cc=mjt@tls.msk.ru \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).