From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 51EA8D132CF for ; Mon, 4 Nov 2024 14:22:58 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t7xy9-0002dy-S9; Mon, 04 Nov 2024 09:22:13 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t7xy1-0002dK-Ga for qemu-devel@nongnu.org; Mon, 04 Nov 2024 09:22:06 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t7xxy-0000OZ-UU for qemu-devel@nongnu.org; Mon, 04 Nov 2024 09:22:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1730730120; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9lVNrzWqANj8eqLf0m0JSsL6qe92SRUfDbhQm/dG4iY=; b=d0VHSksMPi0hIgYNngu7ykswbMnMdFQrVC9vtLEn/j/CobI2IrCzNL0k1SeyjL5HnZn5IK Rcpa1Qest7HUbAH9NX2AXq/6o4G4UhPdLk/ehtrBQlclwXgfmlhb/SKrt3SjQWHsBpvH5m TlnaYBZ1aeOTDuutWaCLdi4kJXJ//CA= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-41-r_UQGAjPM9OiDAE3aiIsUQ-1; Mon, 04 Nov 2024 09:21:59 -0500 X-MC-Unique: r_UQGAjPM9OiDAE3aiIsUQ-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-4314a22ed8bso30574595e9.1 for ; Mon, 04 Nov 2024 06:21:59 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730730117; x=1731334917; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=9lVNrzWqANj8eqLf0m0JSsL6qe92SRUfDbhQm/dG4iY=; b=YswrDZpwLZtNr3I1QD72oofLGBvgpJR3MsvXush/MnZiUIZZqhcVV1fHMx5Hw9rnx1 rd26fxe29gM/1zX886078JLq4Ovv67WkmrDbXSifi6tJvMe4YnWopKVK0K0i/07EYrQT /2GQJ03fEhIFIVb9wpBfQo/Gg7Bbpc17pdeSnDnwbhr1oYw6RIef40l6xyESVCT3O6j9 Y5HFuoZIR68E4GLyG6X3V+ZSetPXNm0SdNhrNevymoRsZdqfXcmmddr76JeTRsUDmXvU INaMi94pxb1EFhm2jPgSTb36KqIDPeeb1jB293PzeQkWf+MNW9R0vPoF58f5T0/mVSon roGQ== X-Forwarded-Encrypted: i=1; AJvYcCXvfjReLKiqDVImAc3TpEtSqh5vORRlTg0Vu7cQG+PPZUEJZXKZKrIFKM/qLsYrwk7J/1WhuV0WjIH7@nongnu.org X-Gm-Message-State: AOJu0YxJw0B2mmeBS3e2Y41hB+xk9CRqZ4SRrVz/1h3Fj5ODCqDnY7vP brSxwYIJkMMmOqBDbM4oRm+xNVpjASQwz2pM4+DDSnVcoXHzZ62J5FoMewMfBgPJx/58d9bEI+V y0cUR7FbCI+emNfdoDP1WTVrH53VC94mrVIhcEWCUAi4IRL5R8sND X-Received: by 2002:a05:600c:4688:b0:431:5957:27e8 with SMTP id 5b1f17b1804b1-4327b7ea52dmr124336625e9.28.1730730117074; Mon, 04 Nov 2024 06:21:57 -0800 (PST) X-Google-Smtp-Source: AGHT+IGH7wNOEdrbcu1LJgTXUfaVtCkLdeEwV8TTcWMnuwMwDZ9Wn+j2eDi3w5w6t8hCURCBOxo0qg== X-Received: by 2002:a05:600c:4688:b0:431:5957:27e8 with SMTP id 5b1f17b1804b1-4327b7ea52dmr124336475e9.28.1730730116661; Mon, 04 Nov 2024 06:21:56 -0800 (PST) Received: from redhat.com ([2a02:14f:177:aecb:5a54:cf63:d69d:19ea]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-431bd8e8466sm185692335e9.2.2024.11.04.06.21.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Nov 2024 06:21:56 -0800 (PST) Date: Mon, 4 Nov 2024 09:21:52 -0500 From: "Michael S. Tsirkin" To: Ricardo Ribalda Cc: Igor Mammedov , Ani Sinha , Marcel Apfelbaum , Paolo Bonzini , Richard Henderson , Eduardo Habkost , qemu-devel@nongnu.org, Mark Cave-Ayland Subject: Re: [PATCH v2 3/3] tests/acpi: pc: update golden masters for DSDT Message-ID: <20241104092003-mutt-send-email-mst@kernel.org> References: <20240924132417.739809-1-ribalda@chromium.org> <20240924132417.739809-4-ribalda@chromium.org> <20241104084521-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Received-SPF: pass client-ip=170.10.129.124; envelope-from=mst@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -23 X-Spam_score: -2.4 X-Spam_bar: -- X-Spam_report: (-2.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.34, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Mon, Nov 04, 2024 at 03:00:00PM +0100, Ricardo Ribalda wrote: > Hi Michael > > > > On Mon, 4 Nov 2024 at 14:46, Michael S. Tsirkin wrote: > > > > On Tue, Sep 24, 2024 at 01:24:12PM +0000, Ricardo Ribalda wrote: > > > Signed-off-by: Ricardo Ribalda > > > > > > two things wrong here: > > 1. you do not describe what changed in the ASL in the commit log > > In the cover page I mention that the ASL diff is NoP: > ``` > Unfortunately, the ASL diff is not the best (or I cannot produce > something better): > 12c12 > < * Length 0x00003917 (14615) > --- > > * Length 0x00003914 (14612) > 14c14 > < * Checksum 0xD9 > --- > > * Checksum 0x09 > > ``` Yes, this should go into the commit log. Fow now don't worry, I will put it there, but next time pls remember to put it in the log for the correct patch - the one updating the expected files. Thanks! > > > 2. you forgot one DSDT: tests/data/acpi/x86/q35/DSDT.acpihmat-generic-x > > Maybe the tree has changed since I sent the patch? I am pretty sure > that I test it before I sent the patch :S > Also, I cannot find that file on the tree: > https://github.com/qemu/qemu/tree/master/tests/data/acpi/x86/q35 Oh I think it's a patch I added in my tree then. Don't worry, I fixed it up. > > > > > --- > > > tests/data/acpi/x86/pc/DSDT | Bin 8527 -> 8526 bytes > > > tests/data/acpi/x86/pc/DSDT.acpierst | Bin 8438 -> 8437 bytes > > > tests/data/acpi/x86/pc/DSDT.acpihmat | Bin 9852 -> 9851 bytes > > > tests/data/acpi/x86/pc/DSDT.bridge | Bin 15398 -> 15397 bytes > > > tests/data/acpi/x86/pc/DSDT.cphp | Bin 8991 -> 8990 bytes > > > tests/data/acpi/x86/pc/DSDT.dimmpxm | Bin 10181 -> 10180 bytes > > > tests/data/acpi/x86/pc/DSDT.hpbridge | Bin 8478 -> 8477 bytes > > > tests/data/acpi/x86/pc/DSDT.hpbrroot | Bin 5034 -> 5033 bytes > > > tests/data/acpi/x86/pc/DSDT.ipmikcs | Bin 8599 -> 8598 bytes > > > tests/data/acpi/x86/pc/DSDT.memhp | Bin 9886 -> 9885 bytes > > > tests/data/acpi/x86/pc/DSDT.nohpet | Bin 8385 -> 8384 bytes > > > tests/data/acpi/x86/pc/DSDT.numamem | Bin 8533 -> 8532 bytes > > > tests/data/acpi/x86/pc/DSDT.roothp | Bin 12320 -> 12319 bytes > > > tests/data/acpi/x86/q35/DSDT.cxl | Bin 13148 -> 13146 bytes > > > tests/data/acpi/x86/q35/DSDT.viot | Bin 14615 -> 14612 bytes > > > tests/qtest/bios-tables-test-allowed-diff.h | 15 --------------- > > > 16 files changed, 15 deletions(-) > > > > > > diff --git a/tests/data/acpi/x86/pc/DSDT b/tests/data/acpi/x86/pc/DSDT > > > index 92225236e717b2e522a2ee00492fb0ded418dc7b..8b8235fe79e2fa08a6f840c8479edb75f5a047b9 100644 > > > GIT binary patch > > > delta 50 > > > zcmX@_bk2#(CD@oAE|a9ky!c?JcmeN{0B27F5towqfS?eDB|_fCn**8t > > > G$pHX!zYhWc > > > > > > delta 51 > > > zcmX@-bl!=}CD)i9E|Zk!y!c?Jcmbc10B27F5!aIVfS?eDCBi<%T$=-! > > > H{>cFVe<%+E > > > > > > diff --git a/tests/data/acpi/x86/pc/DSDT.acpierst b/tests/data/acpi/x86/pc/DSDT.acpierst > > > index 25b39955059409b177870800949eaf937cd39005..06829b9c6c6d726d955dc7c99bc9f42448e22aeb 100644 > > > GIT binary patch > > > delta 50 > > > zcmez7_|=iiCD > > GDhB|jb`RtL > > > > > > delta 51 > > > zcmezB_|1{aCD > > HS}F$svl > > > > > diff --git a/tests/data/acpi/x86/pc/DSDT.acpihmat b/tests/data/acpi/x86/pc/DSDT.acpihmat > > > index 73a9ce59e9426b180fea0ec5820c4841ebdb6700..2fe355ebdbb858fa9247d09112e21712e3eddc45 100644 > > > GIT binary patch > > > delta 50 > > > zcmez4^V^5ZCD > > FRRD#m4w3)> > > > > > > delta 51 > > > zcmezE^T&tFCD > > Gv{e9+a1N3H > > > > > > diff --git a/tests/data/acpi/x86/pc/DSDT.bridge b/tests/data/acpi/x86/pc/DSDT.bridge > > > index 4cef454e379e1009141694e0f4036a2a701c80d7..4d4067c182a6625db1e877408eb7436113884b50 100644 > > > GIT binary patch > > > delta 50 > > > zcmZ2hv9yBACD > > GS^@xfwGR#e > > > > > > delta 51 > > > zcmZ2lv8;m2CD > > Hu37>BgE$Wk > > > > > > diff --git a/tests/data/acpi/x86/pc/DSDT.cphp b/tests/data/acpi/x86/pc/DSDT.cphp > > > index 1dc928333d7ae7e4df6bb51d850af5e1cb480158..045a52e75b7fcd4e5f840a758c548231498b96e4 100644 > > > GIT binary patch > > > delta 50 > > > zcmbR5HqVXACD > > GQvd*IF%Gf- > > > > > > delta 51 > > > zcmbQ|Hs6iQCD > > Hol^h+ba)Q3 > > > > > > diff --git a/tests/data/acpi/x86/pc/DSDT.dimmpxm b/tests/data/acpi/x86/pc/DSDT.dimmpxm > > > index 9f71d2e58b1707e733584e38dab7f73f9bda5eb7..205219b99d903555125c4b07fc047c42993eb338 100644 > > > GIT binary patch > > > delta 50 > > > zcmX@=f5e~5CD > > GQ3U{wR1Yx# > > > > > > delta 51 > > > zcmX@&f7GALCD > > Hm8b#$nr{y= > > > > > > diff --git a/tests/data/acpi/x86/pc/DSDT.hpbridge b/tests/data/acpi/x86/pc/DSDT.hpbridge > > > index db420593a3c51eced25cd57420353fbb9ccdf63c..8fa8b519ec65bd5099c45f4e1c85b11b47a23845 100644 > > > GIT binary patch > > > delta 50 > > > zcmbQ|G}npCCD > > Gl>-1^5)N_z > > > > > > delta 51 > > > zcmbR1G|!34CD > > H&dLD*Ya9-8 > > > > > > diff --git a/tests/data/acpi/x86/pc/DSDT.hpbrroot b/tests/data/acpi/x86/pc/DSDT.hpbrroot > > > index 31b6adb4eb941e5bf0c02ec8c3819c9213adf022..01719462a72fd6d40ce433dac601e4b94eae574c 100644 > > > GIT binary patch > > > delta 49 > > > zcmZ3bzEYjbCD > > F1ORu)4$=Ss > > > > > > delta 50 > > > zcmZ3fzDk|TCDw)2U4E%;)9*y1$;^ZoIMRhTub5ufTRsZDwX% > > > GCIkS3!Vb~^ > > > > > > diff --git a/tests/data/acpi/x86/pc/DSDT.ipmikcs b/tests/data/acpi/x86/pc/DSDT.ipmikcs > > > index c2a0330d97d495298889b9e28bde2f90235cea88..0ca664688b16baa3a06b8440181de4f17511c6b0 100644 > > > GIT binary patch > > > delta 50 > > > zcmbR4Jk6QQCD > > GlLr8LI1Zrz > > > > > > delta 51 > > > zcmbQ{Jl&bgCD > > Ha+3!Dh4&7j > > > > > > diff --git a/tests/data/acpi/x86/pc/DSDT.memhp b/tests/data/acpi/x86/pc/DSDT.memhp > > > index c15a9fae947bb3929a30c60b7c0f2092705868f8..03ff464ba4e72082fce0921815cfc09ca20b561a 100644 > > > GIT binary patch > > > delta 50 > > > zcmbQ|JJ*-XCD > > GssI3QI1W(& > > > > > > delta 51 > > > zcmbR1JI|NPCD > > H`KkZ_dYcYW > > > > > > diff --git a/tests/data/acpi/x86/pc/DSDT.nohpet b/tests/data/acpi/x86/pc/DSDT.nohpet > > > index dd29f5cb620e5164601e303e37524530ddb12684..b081030f0ed171e52b13e28cfdc8770a04c2806e 100644 > > > GIT binary patch > > > delta 50 > > > zcmX@;c)*d%CD > > G$N>O%X%3M9 > > > > > > delta 51 > > > zcmX@$c+io{CDBT_!2ddGWzc@d7?20nVNVBCaLz0YM=QON4!jxi$wd > > > H703Yqg6|HI > > > > > > diff --git a/tests/data/acpi/x86/pc/DSDT.numamem b/tests/data/acpi/x86/pc/DSDT.numamem > > > index 8a6b56fe7da18bf42c339d13b863aabf81780527..2c98cafbff5db04410b35a1151eaf18723a4dad7 100644 > > > GIT binary patch > > > delta 50 > > > zcmccWbj69wCD > > F > > > > > delta 51 > > > zcmccObk&K=CD > > GSmXh88x6$( > > > > > > diff --git a/tests/data/acpi/x86/pc/DSDT.roothp b/tests/data/acpi/x86/pc/DSDT.roothp > > > index a16b0d9d4becec47fa3cf57ed0077ff6cff88908..da018dca9e3102e811107994248719ab5278c505 100644 > > > GIT binary patch > > > delta 50 > > > zcmZ3GFh7CICD > > G*98E3GY>2P > > > > > > delta 51 > > > zcmbQAupoiUCD > > Ho!12bhUO0} > > > > > > diff --git a/tests/data/acpi/x86/q35/DSDT.cxl b/tests/data/acpi/x86/q35/DSDT.cxl > > > index f561750cab8b061c123c041fe2209d74c7a740f1..3c34d4dcab16783abe65f6fa5e64eb69d40795fb 100644 > > > GIT binary patch > > > delta 89 > > > zcmcbUb}Nm`CDBTe@uL^Q+#xj=Vo > > U)&1Eg?@ > > > > > delta 91 > > > zcmcbWb|;O?CDBze@uL^Q+#xj*JgEDD@GpIlK6n25QZhfKE+&{ > > > V > > > > > diff --git a/tests/data/acpi/x86/q35/DSDT.viot b/tests/data/acpi/x86/q35/DSDT.viot > > > index 8d98dd8845a60a08df5aff27097646bea4913b75..4c93dfd5c4b362714d3f9aa606a838d4625b3369 100644 > > > GIT binary patch > > > delta 115 > > > zcmbPUG^L2kCDBfLri?IQ+#xj>tuD=rQ9wh@c}_03`>N(i#Okp > > > Z4P{4`H&;cKf1!#h@2-m~|3g=v8vqA!B?tfj > > > > > > delta 127 > > > zcmbPIG`)z+CD(KT@#aP@VOcK!hM4$Zr}*e5x5?_VOL<&N;sb(07?ue86mxC9 > > > gE*r{@tiVhaLxC6jWCLApWJRvJSQKrxH@(UX0RQ4B(*OVf > > > > > > diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h > > > index f81f4e2469..dfb8523c8b 100644 > > > --- a/tests/qtest/bios-tables-test-allowed-diff.h > > > +++ b/tests/qtest/bios-tables-test-allowed-diff.h > > > @@ -1,16 +1 @@ > > > /* List of comma-separated changed AML files to ignore */ > > > -"tests/data/acpi/x86/pc/DSDT", > > > -"tests/data/acpi/x86/pc/DSDT.acpierst", > > > -"tests/data/acpi/x86/pc/DSDT.acpihmat", > > > -"tests/data/acpi/x86/pc/DSDT.bridge", > > > -"tests/data/acpi/x86/pc/DSDT.cphp", > > > -"tests/data/acpi/x86/pc/DSDT.dimmpxm", > > > -"tests/data/acpi/x86/pc/DSDT.hpbridge", > > > -"tests/data/acpi/x86/pc/DSDT.hpbrroot", > > > -"tests/data/acpi/x86/pc/DSDT.ipmikcs", > > > -"tests/data/acpi/x86/pc/DSDT.memhp", > > > -"tests/data/acpi/x86/pc/DSDT.nohpet", > > > -"tests/data/acpi/x86/pc/DSDT.numamem", > > > -"tests/data/acpi/x86/pc/DSDT.roothp", > > > -"tests/data/acpi/x86/q35/DSDT.cxl", > > > -"tests/data/acpi/x86/q35/DSDT.viot", > > > -- > > > 2.46.0.792.g87dc391469-goog > > > > > -- > Ricardo Ribalda