From: Dongli Zhang <dongli.zhang@oracle.com>
To: qemu-devel@nongnu.org, kvm@vger.kernel.org
Cc: pbonzini@redhat.com, mtosatti@redhat.com, sandipan.das@amd.com,
babu.moger@amd.com, zhao1.liu@intel.com, likexu@tencent.com,
like.xu.linux@gmail.com, zhenyuw@linux.intel.com, groug@kaod.org,
lyan@digitalocean.com, khorenko@virtuozzo.com,
alexander.ivanov@virtuozzo.com, den@virtuozzo.com,
joe.jin@oracle.com, davydov-max@yandex-team.ru
Subject: [PATCH 1/7] target/i386: disable PerfMonV2 when PERFCORE unavailable
Date: Mon, 4 Nov 2024 01:40:16 -0800 [thread overview]
Message-ID: <20241104094119.4131-2-dongli.zhang@oracle.com> (raw)
In-Reply-To: <20241104094119.4131-1-dongli.zhang@oracle.com>
When the PERFCORE is disabled with "-cpu host,-perfctr-core", it is
reflected in in guest dmesg.
[ 0.285136] Performance Events: AMD PMU driver.
However, the guest cpuid indicates the PerfMonV2 is still available.
CPU:
Extended Performance Monitoring and Debugging (0x80000022):
AMD performance monitoring V2 = true
AMD LBR V2 = false
AMD LBR stack & PMC freezing = false
number of core perf ctrs = 0x6 (6)
number of LBR stack entries = 0x0 (0)
number of avail Northbridge perf ctrs = 0x0 (0)
number of available UMC PMCs = 0x0 (0)
active UMCs bitmask = 0x0
Disable PerfMonV2 in cpuid when PERFCORE is disabled.
Fixes: 209b0ac12074 ("target/i386: Add PerfMonV2 feature bit")
Signed-off-by: Dongli Zhang <dongli.zhang@oracle.com>
---
target/i386/cpu.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/target/i386/cpu.c b/target/i386/cpu.c
index 3baa95481f..4490a7a8d6 100644
--- a/target/i386/cpu.c
+++ b/target/i386/cpu.c
@@ -7103,6 +7103,7 @@ void cpu_x86_cpuid(CPUX86State *env, uint32_t index, uint32_t count,
*eax = *ebx = *ecx = *edx = 0;
/* AMD Extended Performance Monitoring and Debug */
if (kvm_enabled() && cpu->enable_pmu &&
+ (env->features[FEAT_8000_0001_ECX] & CPUID_EXT3_PERFCORE) &&
(env->features[FEAT_8000_0022_EAX] & CPUID_8000_0022_EAX_PERFMON_V2)) {
*eax |= CPUID_8000_0022_EAX_PERFMON_V2;
*ebx |= kvm_arch_get_supported_cpuid(cs->kvm_state, index, count,
--
2.39.3
next prev parent reply other threads:[~2024-11-04 9:42 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-04 9:40 [PATCH 0/7] target/i386/kvm/pmu: Enhancement, Bugfix and Cleanup Dongli Zhang
2024-11-04 9:40 ` Dongli Zhang [this message]
2024-11-06 3:54 ` [PATCH 1/7] target/i386: disable PerfMonV2 when PERFCORE unavailable Zhao Liu
2024-11-07 0:29 ` dongli.zhang
2024-11-07 7:57 ` Zhao Liu
2024-11-04 9:40 ` [PATCH 2/7] target/i386/kvm: introduce 'pmu-cap-disabled' to set KVM_PMU_CAP_DISABLE Dongli Zhang
2024-11-07 7:52 ` Zhao Liu
2024-11-07 23:44 ` dongli.zhang
2024-11-08 2:32 ` Zhao Liu
2024-11-08 12:52 ` Sandipan Das
2024-11-13 17:15 ` Zhao Liu
2024-11-14 0:13 ` dongli.zhang
2024-11-21 10:06 ` Mi, Dapeng
2025-02-07 9:52 ` Mi, Dapeng
2025-02-09 20:12 ` dongli.zhang
2025-02-10 8:04 ` Mi, Dapeng
2024-11-04 9:40 ` [PATCH 3/7] target/i386/kvm: init PMU information only once Dongli Zhang
2024-11-10 15:29 ` Zhao Liu
2024-11-13 1:50 ` dongli.zhang
2024-11-13 16:48 ` Zhao Liu
2024-11-04 9:40 ` [PATCH 4/7] target/i386/kvm: rename architectural PMU variables Dongli Zhang
2024-11-04 9:40 ` [PATCH 5/7] target/i386/kvm: reset AMD PMU registers during VM reset Dongli Zhang
2024-11-06 9:58 ` Sandipan Das
2024-11-07 0:33 ` dongli.zhang
2024-11-07 21:00 ` Maksim Davydov
2024-11-08 1:19 ` dongli.zhang
2024-11-08 14:07 ` Maksim Davydov
2024-11-08 18:04 ` dongli.zhang
2024-11-04 9:40 ` [PATCH 6/7] target/i386/kvm: support perfmon-v2 for reset Dongli Zhang
2024-11-08 13:09 ` Sandipan Das
2024-11-08 16:55 ` dongli.zhang
2024-11-04 9:40 ` [PATCH 7/7] target/i386/kvm: don't stop Intel PMU counters Dongli Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241104094119.4131-2-dongli.zhang@oracle.com \
--to=dongli.zhang@oracle.com \
--cc=alexander.ivanov@virtuozzo.com \
--cc=babu.moger@amd.com \
--cc=davydov-max@yandex-team.ru \
--cc=den@virtuozzo.com \
--cc=groug@kaod.org \
--cc=joe.jin@oracle.com \
--cc=khorenko@virtuozzo.com \
--cc=kvm@vger.kernel.org \
--cc=like.xu.linux@gmail.com \
--cc=likexu@tencent.com \
--cc=lyan@digitalocean.com \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=sandipan.das@amd.com \
--cc=zhao1.liu@intel.com \
--cc=zhenyuw@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).