From: Ilya Leoshkevich <iii@linux.ibm.com>
To: Warner Losh <imp@bsdimp.com>, Riku Voipio <riku.voipio@iki.fi>,
Laurent Vivier <laurent@vivier.eu>,
Paolo Bonzini <pbonzini@redhat.com>,
Richard Henderson <richard.henderson@linaro.org>
Cc: "Kyle Evans" <kevans@freebsd.org>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
qemu-devel@nongnu.org, "Ilya Leoshkevich" <iii@linux.ibm.com>
Subject: [PATCH v2 2/8] gdbstub: Try unlinking the unix socket before binding
Date: Wed, 6 Nov 2024 23:31:01 +0100 [thread overview]
Message-ID: <20241106223629.2608-3-iii@linux.ibm.com> (raw)
In-Reply-To: <20241106223629.2608-1-iii@linux.ibm.com>
In case an emulated process execve()s another emulated process, bind()
will fail, because the socket already exists. So try deleting it.
Note that it is not possible to handle this in do_execv(): deleting
gdbserver_user_state.socket_path before safe_execve() is not correct,
because the latter may fail, and afterwards we may lose control.
Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
---
gdbstub/user.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/gdbstub/user.c b/gdbstub/user.c
index ef52f249ce9..c900d0a52fe 100644
--- a/gdbstub/user.c
+++ b/gdbstub/user.c
@@ -337,6 +337,7 @@ static int gdbserver_open_socket(const char *path)
sockaddr.sun_family = AF_UNIX;
pstrcpy(sockaddr.sun_path, sizeof(sockaddr.sun_path) - 1, path);
+ unlink(sockaddr.sun_path);
ret = bind(fd, (struct sockaddr *)&sockaddr, sizeof(sockaddr));
if (ret < 0) {
perror("bind socket");
--
2.47.0
next prev parent reply other threads:[~2024-11-06 22:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-06 22:30 [PATCH v2 0/8] gdbstub: Allow late attachment Ilya Leoshkevich
2024-11-06 22:31 ` [PATCH v2 1/8] gdbstub: Allow the %d placeholder in the socket path Ilya Leoshkevich
2024-11-06 22:31 ` Ilya Leoshkevich [this message]
2024-11-06 22:31 ` [PATCH v2 3/8] user: Introduce user/signal.h Ilya Leoshkevich
2024-11-06 22:31 ` [PATCH v2 4/8] user: Introduce host_interrupt_signal Ilya Leoshkevich
2024-11-06 22:31 ` [PATCH v2 5/8] osdep: Introduce qemu_kill_thread() Ilya Leoshkevich
2024-11-06 22:31 ` [PATCH v2 6/8] gdbstub: Allow late attachment Ilya Leoshkevich
2024-11-06 22:31 ` [PATCH v2 7/8] docs/user: Document the %d placeholder and suspend=n QEMU_GDB features Ilya Leoshkevich
2024-11-06 22:31 ` [PATCH v2 8/8] tests/tcg: Add late gdbstub attach test Ilya Leoshkevich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241106223629.2608-3-iii@linux.ibm.com \
--to=iii@linux.ibm.com \
--cc=imp@bsdimp.com \
--cc=kevans@freebsd.org \
--cc=laurent@vivier.eu \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=riku.voipio@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).