From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Anton Johansson <anjo@rev.ng>, qemu-devel@nongnu.org
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
"Thomas Huth" <thuth@redhat.com>,
"Jason Wang" <jasowang@redhat.com>,
devel@lists.libvirt.org, qemu-ppc@nongnu.org,
"Alistair Francis" <alistair@alistair23.me>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
qemu-arm@nongnu.org, "Peter Maydell" <peter.maydell@linaro.org>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: [PATCH v2 13/16] target/microblaze: Consider endianness while translating code
Date: Thu, 7 Nov 2024 01:22:19 +0000 [thread overview]
Message-ID: <20241107012223.94337-14-philmd@linaro.org> (raw)
In-Reply-To: <20241107012223.94337-1-philmd@linaro.org>
Consider the CPU ENDI bit, swap instructions when the CPU
endianness doesn't match the binary one.
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
---
target/microblaze/cpu.h | 7 +++++++
target/microblaze/translate.c | 5 +++--
2 files changed, 10 insertions(+), 2 deletions(-)
diff --git a/target/microblaze/cpu.h b/target/microblaze/cpu.h
index 3e5a3e5c60..6d540713eb 100644
--- a/target/microblaze/cpu.h
+++ b/target/microblaze/cpu.h
@@ -412,6 +412,13 @@ void mb_tcg_init(void);
/* Ensure there is no overlap between the two masks. */
QEMU_BUILD_BUG_ON(MSR_TB_MASK & IFLAGS_TB_MASK);
+static inline bool mb_cpu_is_big_endian(CPUState *cs)
+{
+ MicroBlazeCPU *cpu = MICROBLAZE_CPU(cs);
+
+ return !cpu->cfg.endi;
+}
+
static inline void cpu_get_tb_cpu_state(CPUMBState *env, vaddr *pc,
uint64_t *cs_base, uint32_t *flags)
{
diff --git a/target/microblaze/translate.c b/target/microblaze/translate.c
index 0b466db694..5595ae4fad 100644
--- a/target/microblaze/translate.c
+++ b/target/microblaze/translate.c
@@ -709,7 +709,7 @@ static void record_unaligned_ess(DisasContext *dc, int rd,
static inline MemOp mo_endian(DisasContext *dc)
{
- return MO_TE;
+ return dc->cfg->endi ? MO_LE : MO_BE;
}
static bool do_load(DisasContext *dc, int rd, TCGv addr, MemOp mop,
@@ -1646,7 +1646,8 @@ static void mb_tr_translate_insn(DisasContextBase *dcb, CPUState *cs)
dc->tb_flags_to_set = 0;
- ir = translator_ldl(cpu_env(cs), &dc->base, dc->base.pc_next);
+ ir = translator_ldl_swap(cpu_env(cs), &dc->base, dc->base.pc_next,
+ mb_cpu_is_big_endian(cs) != TARGET_BIG_ENDIAN);
if (!decode(dc, ir)) {
trap_illegal(dc, true);
}
--
2.45.2
next prev parent reply other threads:[~2024-11-07 1:25 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-07 1:22 [PATCH v2 00/16] hw/microblaze: Allow running cross-endian vCPUs Philippe Mathieu-Daudé
2024-11-07 1:22 ` [PATCH v2 01/16] hw/microblaze: Restrict MemoryRegionOps are implemented as 32-bit Philippe Mathieu-Daudé
2024-11-07 1:22 ` [PATCH v2 02/16] hw/microblaze: Propagate CPU endianness to microblaze_load_kernel() Philippe Mathieu-Daudé
2024-11-07 10:06 ` Richard Henderson
2024-11-07 1:22 ` [PATCH v2 03/16] hw/intc/xilinx_intc: Make device endianness configurable Philippe Mathieu-Daudé
2024-11-07 10:12 ` Richard Henderson
2024-11-07 1:22 ` [RFC PATCH v2 04/16] hw/net/xilinx_ethlite: Simplify by having configurable endianness Philippe Mathieu-Daudé
2024-11-07 10:16 ` Richard Henderson
2024-11-07 1:22 ` [RFC PATCH v2 05/16] hw/timer/xilinx_timer: Allow down to 8-bit memory access Philippe Mathieu-Daudé
2024-11-07 1:22 ` [PATCH v2 06/16] hw/timer/xilinx_timer: Make device endianness configurable Philippe Mathieu-Daudé
2024-11-07 10:18 ` Richard Henderson
2024-11-07 1:22 ` [PATCH v2 07/16] hw/char/xilinx_uartlite: " Philippe Mathieu-Daudé
2024-11-07 10:27 ` Richard Henderson
2024-11-08 15:06 ` Philippe Mathieu-Daudé
2024-11-07 1:22 ` [PATCH v2 08/16] hw/ssi/xilinx_spi: " Philippe Mathieu-Daudé
2024-11-07 11:01 ` Richard Henderson
2024-11-08 15:07 ` Philippe Mathieu-Daudé
2024-11-07 1:22 ` [PATCH v2 09/16] hw/ssi/xilinx_spips: " Philippe Mathieu-Daudé
2024-11-07 11:02 ` Richard Henderson
2024-11-07 1:22 ` [PATCH v2 10/16] target/microblaze: Explode MO_TExx -> MO_TE | MO_xx Philippe Mathieu-Daudé
2024-11-07 1:22 ` [PATCH v2 11/16] target/microblaze: Set MO_TE once in do_load() / do_store() Philippe Mathieu-Daudé
2024-11-07 1:22 ` [PATCH v2 12/16] target/microblaze: Introduce mo_endian() helper Philippe Mathieu-Daudé
2024-11-07 1:22 ` Philippe Mathieu-Daudé [this message]
2024-11-07 1:22 ` [PATCH v2 14/16] hw/microblaze: Support various endianness for s3adsp1800 machines Philippe Mathieu-Daudé
2024-11-07 1:22 ` [PATCH v2 15/16] tests/functional: Explicit endianness of microblaze assets Philippe Mathieu-Daudé
2024-11-07 1:22 ` [PATCH v2 16/16] tests/functional: Add microblaze cross-endianness tests Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241107012223.94337-14-philmd@linaro.org \
--to=philmd@linaro.org \
--cc=alistair@alistair23.me \
--cc=anjo@rev.ng \
--cc=devel@lists.libvirt.org \
--cc=edgar.iglesias@gmail.com \
--cc=jasowang@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).