From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Richard Henderson" <richard.henderson@linaro.org>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: [PATCH 06/10] accel/tcg: Remove cpu_unwind_state_data() unused CPUState argument
Date: Fri, 15 Nov 2024 16:20:49 +0100 [thread overview]
Message-ID: <20241115152053.66442-7-philmd@linaro.org> (raw)
In-Reply-To: <20241115152053.66442-1-philmd@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
include/exec/translate-all.h | 3 +--
accel/tcg/translate-all.c | 2 +-
target/i386/helper.c | 3 ++-
target/openrisc/sys_helper.c | 7 +++----
4 files changed, 7 insertions(+), 8 deletions(-)
diff --git a/include/exec/translate-all.h b/include/exec/translate-all.h
index f06cfedd52..9303318953 100644
--- a/include/exec/translate-all.h
+++ b/include/exec/translate-all.h
@@ -23,7 +23,6 @@
/**
* cpu_unwind_state_data:
- * @cpu: the cpu context
* @host_pc: the host pc within the translation
* @data: output data
*
@@ -32,7 +31,7 @@
* function returns false; otherwise @data is loaded.
* This is the same unwind info as given to restore_state_to_opc.
*/
-bool cpu_unwind_state_data(CPUState *cpu, uintptr_t host_pc, uint64_t *data);
+bool cpu_unwind_state_data(uintptr_t host_pc, uint64_t *data);
/* translate-all.c */
void tb_check_watchpoint(CPUState *cpu, uintptr_t retaddr);
diff --git a/accel/tcg/translate-all.c b/accel/tcg/translate-all.c
index fdf6d8ac19..8d5530e341 100644
--- a/accel/tcg/translate-all.c
+++ b/accel/tcg/translate-all.c
@@ -243,7 +243,7 @@ bool cpu_restore_state(CPUState *cpu, uintptr_t host_pc)
return false;
}
-bool cpu_unwind_state_data(CPUState *cpu, uintptr_t host_pc, uint64_t *data)
+bool cpu_unwind_state_data(uintptr_t host_pc, uint64_t *data)
{
if (in_code_gen_buffer((const void *)(host_pc - tcg_splitwx_diff))) {
TranslationBlock *tb = tcg_tb_lookup(host_pc);
diff --git a/target/i386/helper.c b/target/i386/helper.c
index 01a268a30b..b848936441 100644
--- a/target/i386/helper.c
+++ b/target/i386/helper.c
@@ -29,6 +29,7 @@
#endif
#include "qemu/log.h"
#ifdef CONFIG_TCG
+#include "exec/translate-all.h"
#include "tcg/insn-start-words.h"
#endif
@@ -526,7 +527,7 @@ static inline target_ulong get_memio_eip(CPUX86State *env)
uint64_t data[TARGET_INSN_START_WORDS];
CPUState *cs = env_cpu(env);
- if (!cpu_unwind_state_data(cs, cs->mem_io_pc, data)) {
+ if (!cpu_unwind_state_data(cs->mem_io_pc, data)) {
return env->eip;
}
diff --git a/target/openrisc/sys_helper.c b/target/openrisc/sys_helper.c
index 77567afba4..67e1f53fca 100644
--- a/target/openrisc/sys_helper.c
+++ b/target/openrisc/sys_helper.c
@@ -20,7 +20,7 @@
#include "qemu/osdep.h"
#include "cpu.h"
-#include "exec/exec-all.h"
+#include "exec/translate-all.h"
#include "exec/helper-proto.h"
#include "exception.h"
#ifndef CONFIG_USER_ONLY
@@ -219,7 +219,6 @@ target_ulong HELPER(mfspr)(CPUOpenRISCState *env, target_ulong rd,
#ifndef CONFIG_USER_ONLY
uint64_t data[TARGET_INSN_START_WORDS];
MachineState *ms = MACHINE(qdev_get_machine());
- CPUState *cs = env_cpu(env);
int idx;
#endif
@@ -260,7 +259,7 @@ target_ulong HELPER(mfspr)(CPUOpenRISCState *env, target_ulong rd,
return env->evbar;
case TO_SPR(0, 16): /* NPC (equals PC) */
- if (cpu_unwind_state_data(cs, GETPC(), data)) {
+ if (cpu_unwind_state_data(GETPC(), data)) {
return data[0];
}
return env->pc;
@@ -269,7 +268,7 @@ target_ulong HELPER(mfspr)(CPUOpenRISCState *env, target_ulong rd,
return cpu_get_sr(env);
case TO_SPR(0, 18): /* PPC */
- if (cpu_unwind_state_data(cs, GETPC(), data)) {
+ if (cpu_unwind_state_data(GETPC(), data)) {
if (data[1] & 2) {
return data[0] - 4;
}
--
2.45.2
next prev parent reply other threads:[~2024-11-15 15:23 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-15 15:20 [PATCH 00/10] accel/tcg: API prototype cleanups Philippe Mathieu-Daudé
2024-11-15 15:20 ` [PATCH 01/10] target/mips: Drop left-over comment about Jazz machine Philippe Mathieu-Daudé
2024-11-15 15:39 ` Peter Maydell
2024-11-15 17:14 ` Richard Henderson
2024-11-15 15:20 ` [PATCH 02/10] target/loongarch: Declare loongarch_cpu_dump_state() locally Philippe Mathieu-Daudé
2024-11-15 15:40 ` Peter Maydell
2024-11-15 17:15 ` Richard Henderson
2024-11-15 15:20 ` [PATCH 03/10] target/sparc: Move sparc_restore_state_to_opc() to cpu.c Philippe Mathieu-Daudé
2024-11-15 15:42 ` Peter Maydell
2024-11-15 17:17 ` Richard Henderson
2024-11-15 15:20 ` [PATCH 04/10] accel/tcg: Ensure frontends define restore_state_to_opc handler Philippe Mathieu-Daudé
2024-11-15 15:20 ` [PATCH 05/10] accel/tcg: Move cpu_unwind_state_data() declaration Philippe Mathieu-Daudé
2024-11-15 15:48 ` Peter Maydell
2024-11-15 16:04 ` Philippe Mathieu-Daudé
2024-11-15 15:20 ` Philippe Mathieu-Daudé [this message]
2024-11-15 15:50 ` [PATCH 06/10] accel/tcg: Remove cpu_unwind_state_data() unused CPUState argument Peter Maydell
2024-11-15 17:23 ` Richard Henderson
2024-11-15 17:33 ` Peter Maydell
2025-03-19 7:53 ` Philippe Mathieu-Daudé
2024-11-15 15:20 ` [PATCH 07/10] accel/tcg: Reduce log_pc() declaration scope Philippe Mathieu-Daudé
2024-11-15 15:51 ` Peter Maydell
2024-11-15 17:26 ` Richard Henderson
2024-11-15 15:20 ` [PATCH 08/10] hw/core/cpu: Pass CPUArchState to set/get_pc() handlers Philippe Mathieu-Daudé
2024-11-15 15:54 ` Peter Maydell
2024-11-15 16:21 ` Paolo Bonzini
2024-11-15 17:51 ` Richard Henderson
2024-11-15 15:20 ` [PATCH 09/10] hw/core/cpu: Pass CPUArchState to restore_state_to_opc() handler Philippe Mathieu-Daudé
2024-11-15 15:20 ` [PATCH 10/10] hw/core/cpu: Pass CPUArchState to cpu_dump_state() handler Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241115152053.66442-7-philmd@linaro.org \
--to=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).