qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Akihiko Odaki <akihiko.odaki@daynix.com>
To: Jason Wang <jasowang@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>
Cc: qemu-devel@nongnu.org, devel@daynix.com,
	 Akihiko Odaki <akihiko.odaki@daynix.com>
Subject: [PATCH v3 5/6] virtio-net: Initialize hash reporting values
Date: Fri, 22 Nov 2024 14:03:11 +0900	[thread overview]
Message-ID: <20241122-queue-v3-5-f2ff03b8dbfd@daynix.com> (raw)
In-Reply-To: <20241122-queue-v3-0-f2ff03b8dbfd@daynix.com>

The specification says hash_report should be set to
VIRTIO_NET_HASH_REPORT_NONE if VIRTIO_NET_F_HASH_REPORT is negotiated
but not configured with VIRTIO_NET_CTRL_MQ_RSS_CONFIG. However,
virtio_net_receive_rcu() instead wrote out the content of the extra_hdr
variable, which is not uninitialized in such a case.

Fix this by zeroing the extra_hdr.

Fixes: e22f0603fb2f ("virtio-net: reference implementation of hash report")
Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
---
 hw/net/virtio-net.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c
index b544d2e91a77..44ea72b50e0e 100644
--- a/hw/net/virtio-net.c
+++ b/hw/net/virtio-net.c
@@ -1911,6 +1911,8 @@ static ssize_t virtio_net_receive_rcu(NetClientState *nc, const uint8_t *buf,
     size_t offset, i, guest_offset, j;
     ssize_t err;
 
+    memset(&extra_hdr, 0, sizeof(extra_hdr));
+
     if (n->rss_data.enabled && n->rss_data.enabled_software_rss) {
         int index = virtio_net_process_rss(nc, buf, size, &extra_hdr);
         if (index >= 0) {

-- 
2.47.0



  parent reply	other threads:[~2024-11-22  5:03 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-22  5:03 [PATCH v3 0/6] virtio-net fixes Akihiko Odaki
2024-11-22  5:03 ` [PATCH v3 1/6] net: checksum: Convert data to void * Akihiko Odaki
2024-11-22  7:09   ` Philippe Mathieu-Daudé
2024-11-22  5:03 ` [PATCH v3 2/6] virtio-net: Fix size check in dhclient workaround Akihiko Odaki
2024-11-22  5:03 ` [PATCH v3 3/6] virtio-net: Do not check for the queue before RSS Akihiko Odaki
2024-11-22  5:03 ` [PATCH v3 4/6] virtio-net: Fix hash reporting when the queue changes Akihiko Odaki
2024-11-22  5:03 ` Akihiko Odaki [this message]
2024-11-22  7:15   ` [PATCH v3 5/6] virtio-net: Initialize hash reporting values Philippe Mathieu-Daudé
2024-11-22  5:03 ` [PATCH v3 6/6] virtio-net: Copy received header to buffer Akihiko Odaki
2024-11-26  3:02 ` [PATCH v3 0/6] virtio-net fixes Lei Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241122-queue-v3-5-f2ff03b8dbfd@daynix.com \
    --to=akihiko.odaki@daynix.com \
    --cc=devel@daynix.com \
    --cc=jasowang@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).