From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: junjie.mao@hotmail.com, zhao1.liu@intel.com, qemu-rust@nongnu.org
Subject: [PATCH 0/2] rust: safe wrappers for interrupt sources
Date: Fri, 22 Nov 2024 08:47:54 +0100 [thread overview]
Message-ID: <20241122074756.282142-1-pbonzini@redhat.com> (raw)
Interrupt sources, qemu_irq in C code, are pointers to IRQState objects.
They are QOM link properties and can be written to outside the control
of the device (i.e. from a shared reference); therefore their Rust
representation must be an interior-mutable field.
This make interrupt sources similar to a Cell<*mut IRQState>. However,
a Cell can only live within one thread, while here the semantics are
"accessible by multiple threads but only under the Big QEMU Lock".
Therefore, this series adds to QEMU a specialized cell type that checks
locking rules with respect to the "Big QEMU Lock". In particular,
qemu_api::cell::BqlCell only allows get()/set() under BQL protection and
therefore is Send/Sync. It comes with documentation and doctests.
I am not fully satisfied with the solution I used for mocking the BQL;
I have a prototype that runs doctests from "meson test" but that may
take some more time to cook.
Likewise, qemu_api::cell::RefCell would be a RefCell that is Send/Sync,
because it checks that borrow()/borrow_mut() is only done under BQL;
but this is not added here because there is no use case (yet).
The interrupt sources prat was previously posted as RFC at
https://lore.kernel.org/qemu-devel/20241104085159.76841-1-pbonzini@redhat.com/,
while the BqlCell is new. The code is a bit long but most of it is
lifted from the standard library and almost half is documentation.
Please review!
Paolo Bonzini (2):
rust: add BQL-enforcing Cell variant
rust: add bindings for interrupt sources
rust/hw/char/pl011/src/device.rs | 22 +--
rust/qemu-api/meson.build | 3 +
rust/qemu-api/src/cell.rs | 294 +++++++++++++++++++++++++++++++
rust/qemu-api/src/irq.rs | 66 +++++++
rust/qemu-api/src/lib.rs | 3 +
rust/qemu-api/src/sysbus.rs | 26 +++
6 files changed, 404 insertions(+), 10 deletions(-)
create mode 100644 rust/qemu-api/src/cell.rs
create mode 100644 rust/qemu-api/src/irq.rs
create mode 100644 rust/qemu-api/src/sysbus.rs
--
2.47.0
next reply other threads:[~2024-11-22 7:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-22 7:47 Paolo Bonzini [this message]
2024-11-22 7:47 ` [PATCH 1/2] rust: add BQL-enforcing Cell variant Paolo Bonzini
2024-11-26 14:56 ` Zhao Liu
2024-11-26 16:11 ` Paolo Bonzini
2024-11-27 6:35 ` Zhao Liu
2024-11-27 8:31 ` Paolo Bonzini
2024-11-27 6:54 ` Junjie Mao
2024-11-22 7:47 ` [PATCH 2/2] rust: add bindings for interrupt sources Paolo Bonzini
2024-11-22 8:28 ` Philippe Mathieu-Daudé
2024-11-22 8:32 ` Paolo Bonzini
2024-11-22 10:30 ` Philippe Mathieu-Daudé
2024-11-22 10:53 ` Paolo Bonzini
2024-11-22 11:07 ` Philippe Mathieu-Daudé
2024-11-26 13:45 ` Zhao Liu
2024-11-26 13:35 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241122074756.282142-1-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=junjie.mao@hotmail.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-rust@nongnu.org \
--cc=zhao1.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).