* [PATCH] hw/pci: Remove unused pci_irq_pulse() method
@ 2024-11-22 10:34 Philippe Mathieu-Daudé
2024-11-22 12:38 ` Thomas Huth
0 siblings, 1 reply; 2+ messages in thread
From: Philippe Mathieu-Daudé @ 2024-11-22 10:34 UTC (permalink / raw)
To: qemu-devel
Cc: Marcel Apfelbaum, Thomas Huth, Michael S. Tsirkin,
Philippe Mathieu-Daudé
Last use of pci_irq_pulse() was removed 7 years ago in commit
5e9aa92eb1 ("hw/block: Fix pin-based interrupt behaviour of NVMe").
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
include/hw/pci/pci.h | 10 ----------
1 file changed, 10 deletions(-)
diff --git a/include/hw/pci/pci.h b/include/hw/pci/pci.h
index 135695c551..c0717e3121 100644
--- a/include/hw/pci/pci.h
+++ b/include/hw/pci/pci.h
@@ -670,16 +670,6 @@ static inline void pci_irq_deassert(PCIDevice *pci_dev)
pci_set_irq(pci_dev, 0);
}
-/*
- * FIXME: PCI does not work this way.
- * All the callers to this method should be fixed.
- */
-static inline void pci_irq_pulse(PCIDevice *pci_dev)
-{
- pci_irq_assert(pci_dev);
- pci_irq_deassert(pci_dev);
-}
-
MSIMessage pci_get_msi_message(PCIDevice *dev, int vector);
void pci_set_power(PCIDevice *pci_dev, bool state);
--
2.45.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] hw/pci: Remove unused pci_irq_pulse() method
2024-11-22 10:34 [PATCH] hw/pci: Remove unused pci_irq_pulse() method Philippe Mathieu-Daudé
@ 2024-11-22 12:38 ` Thomas Huth
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Huth @ 2024-11-22 12:38 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel
Cc: Marcel Apfelbaum, Michael S. Tsirkin
On 22/11/2024 11.34, Philippe Mathieu-Daudé wrote:
> Last use of pci_irq_pulse() was removed 7 years ago in commit
> 5e9aa92eb1 ("hw/block: Fix pin-based interrupt behaviour of NVMe").
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> include/hw/pci/pci.h | 10 ----------
> 1 file changed, 10 deletions(-)
>
> diff --git a/include/hw/pci/pci.h b/include/hw/pci/pci.h
> index 135695c551..c0717e3121 100644
> --- a/include/hw/pci/pci.h
> +++ b/include/hw/pci/pci.h
> @@ -670,16 +670,6 @@ static inline void pci_irq_deassert(PCIDevice *pci_dev)
> pci_set_irq(pci_dev, 0);
> }
>
> -/*
> - * FIXME: PCI does not work this way.
> - * All the callers to this method should be fixed.
> - */
> -static inline void pci_irq_pulse(PCIDevice *pci_dev)
> -{
> - pci_irq_assert(pci_dev);
> - pci_irq_deassert(pci_dev);
> -}
> -
> MSIMessage pci_get_msi_message(PCIDevice *dev, int vector);
> void pci_set_power(PCIDevice *pci_dev, bool state);
>
Reviewed-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-11-22 12:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-11-22 10:34 [PATCH] hw/pci: Remove unused pci_irq_pulse() method Philippe Mathieu-Daudé
2024-11-22 12:38 ` Thomas Huth
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).