qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org
Cc: qemu-ppc@nongnu.org, qemu-s390x@nongnu.org,
	"Thomas Huth" <thuth@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	qemu-riscv@nongnu.org,
	"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
	"Peter Maydell" <peter.maydell@linaro.org>,
	qemu-arm@nongnu.org, "Paolo Bonzini" <pbonzini@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: [PATCH-for-10.0 v2 00/13] hw/boards: Remove legacy MachineClass::pci_allow_0_address flag
Date: Tue, 26 Nov 2024 12:21:59 +0100	[thread overview]
Message-ID: <20241126112212.64524-1-philmd@linaro.org> (raw)

Since v1:
- Looked at previous analysis from Peter [1]
- Invert logic so "allow address 0 accesses" is default

---

This series aims to remove a legacy field from
MachineClass. Why? Because it doesn't scale on
heterogeneous machine where different host bridges
are created.

Rather than a global exposed to all machines,
use a pci-bus specific flag on each machine
requiring it, propagated by the host bridge
device.

No logical change intended, only machines previously
using pci_allow_0_address do not set refuse-bar-at-addr-0.

Presumably various machines neither need to set this
'refuse-bar-at-addr-0' flag, but updating that is
deferred to each machine maintainer since I don't have
the knowledge and sufficient test suite IMHO.

[1] https://lore.kernel.org/qemu-devel/20241125140535.4526-1-philmd@linaro.org/
[2] https://lore.kernel.org/qemu-devel/1444683308-30543-1-git-send-email-agordeev@redhat.com/T/#u

Philippe Mathieu-Daudé (13):
  hw/pci: Do not declare PCIBus::flags mask as enum
  hw/pci-bridge: Initialize bridge with parent bus flags
  hw/pci: Factor machine_refuses_bar_at_addr_0() helper out
  hw/pci: Introduce PCIBusFlag::PCI_BUS_BAR_AT_ADDR0_REFUSED
  hw/pci: Propagate bar_at_addr_0_refused to
    pci_root_bus_internal_init()
  hw/pci: Propagate bar_at_addr_0_refused to pci_root_bus_init()
  hw/pci: Propagate bar_at_addr_0_refused to pci_root_bus_new()
  hw/pci: Propagate bar_at_addr_0_refused to pci_register_root_bus()
  hw/ppc/spapr: Create host bridge setting bar_at_addr_0_refused=false
  hw/pci-host/gpex: Expose 'refuse-bar-at-addr-0' property
  hw/arm/virt: Create GPEX host bridge without refuse-bar-at-addr-0
  hw/riscv/virt: Create GPEX host bridge without refuse-bar-at-addr-0
  hw/pci/pci: Remove legacy MachineClass::pci_allow_0_address flag

 include/hw/boards.h                 |  1 -
 include/hw/pci-host/gpex.h          |  1 +
 include/hw/pci/pci.h                |  8 +++++---
 include/hw/pci/pci_bus.h            | 10 ++++++++--
 hw/alpha/typhoon.c                  |  2 +-
 hw/arm/sbsa-ref.c                   |  1 -
 hw/arm/virt.c                       |  1 -
 hw/i386/microvm.c                   |  2 ++
 hw/loongarch/virt.c                 |  2 ++
 hw/mips/loongson3_virt.c            |  2 ++
 hw/openrisc/virt.c                  |  2 ++
 hw/pci-bridge/pci_expander_bridge.c | 17 +++++++++++-----
 hw/pci-host/articia.c               |  3 ++-
 hw/pci-host/astro.c                 |  3 ++-
 hw/pci-host/bonito.c                |  2 +-
 hw/pci-host/designware.c            |  2 +-
 hw/pci-host/dino.c                  |  2 +-
 hw/pci-host/gpex.c                  |  5 ++++-
 hw/pci-host/grackle.c               |  2 +-
 hw/pci-host/gt64120.c               |  2 +-
 hw/pci-host/i440fx.c                |  2 +-
 hw/pci-host/mv64361.c               |  2 +-
 hw/pci-host/pnv_phb3.c              |  2 +-
 hw/pci-host/pnv_phb4.c              |  2 +-
 hw/pci-host/ppc440_pcix.c           |  2 +-
 hw/pci-host/ppc4xx_pci.c            |  2 +-
 hw/pci-host/ppce500.c               |  3 ++-
 hw/pci-host/q35.c                   |  2 +-
 hw/pci-host/raven.c                 |  2 +-
 hw/pci-host/remote.c                |  2 +-
 hw/pci-host/sabre.c                 |  2 +-
 hw/pci-host/sh_pci.c                |  2 +-
 hw/pci-host/uninorth.c              |  8 ++++----
 hw/pci-host/versatile.c             |  2 +-
 hw/pci-host/xilinx-pcie.c           |  2 +-
 hw/pci/pci.c                        | 31 ++++++++++++++++++-----------
 hw/pci/pci_bridge.c                 |  1 +
 hw/ppc/ppc440_uc.c                  |  2 +-
 hw/ppc/spapr.c                      |  1 -
 hw/ppc/spapr_pci.c                  |  2 +-
 hw/riscv/virt.c                     |  1 -
 hw/s390x/s390-pci-bus.c             |  2 +-
 hw/xen/xen-pvh-common.c             |  2 ++
 hw/xtensa/virt.c                    |  2 ++
 44 files changed, 94 insertions(+), 57 deletions(-)

-- 
2.45.2



             reply	other threads:[~2024-11-26 11:25 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-26 11:21 Philippe Mathieu-Daudé [this message]
2024-11-26 11:22 ` [PATCH-for-10.0 v2 01/13] hw/pci: Do not declare PCIBus::flags mask as enum Philippe Mathieu-Daudé
2024-11-27  9:37   ` Philippe Mathieu-Daudé
2024-12-04  6:49     ` Thomas Huth
2024-11-26 11:22 ` [PATCH-for-10.0 v2 02/13] hw/pci-bridge: Initialize bridge with parent bus flags Philippe Mathieu-Daudé
2024-11-26 11:22 ` [PATCH-for-10.0 v2 03/13] hw/pci: Factor machine_refuses_bar_at_addr_0() helper out Philippe Mathieu-Daudé
2024-11-26 11:22 ` [PATCH-for-10.0 v2 04/13] hw/pci: Introduce PCIBusFlag::PCI_BUS_BAR_AT_ADDR0_REFUSED Philippe Mathieu-Daudé
2024-11-26 11:22 ` [PATCH-for-10.0 v2 05/13] hw/pci: Propagate bar_at_addr_0_refused to pci_root_bus_internal_init() Philippe Mathieu-Daudé
2024-12-05 16:44   ` Peter Maydell
2024-12-05 21:24     ` Philippe Mathieu-Daudé
2024-11-26 11:22 ` [PATCH-for-10.0 v2 06/13] hw/pci: Propagate bar_at_addr_0_refused to pci_root_bus_init() Philippe Mathieu-Daudé
2024-11-26 11:22 ` [PATCH-for-10.0 v2 07/13] hw/pci: Propagate bar_at_addr_0_refused to pci_root_bus_new() Philippe Mathieu-Daudé
2024-11-26 11:22 ` [PATCH-for-10.0 v2 08/13] hw/pci: Propagate bar_at_addr_0_refused to pci_register_root_bus() Philippe Mathieu-Daudé
2024-11-26 11:22 ` [PATCH-for-10.0 v2 09/13] hw/ppc/spapr: Create host bridge setting bar_at_addr_0_refused=false Philippe Mathieu-Daudé
2024-11-26 11:22 ` [PATCH-for-10.0 v2 10/13] hw/pci-host/gpex: Expose 'refuse-bar-at-addr-0' property Philippe Mathieu-Daudé
2024-12-05 16:47   ` Peter Maydell
2024-12-05 21:25     ` Philippe Mathieu-Daudé
2024-11-26 11:22 ` [PATCH-for-10.0 v2 11/13] hw/arm/virt: Create GPEX host bridge without refuse-bar-at-addr-0 Philippe Mathieu-Daudé
2024-11-26 11:22 ` [PATCH-for-10.0 v2 12/13] hw/riscv/virt: " Philippe Mathieu-Daudé
2024-11-26 11:22 ` [PATCH-for-10.0 v2 13/13] hw/pci/pci: Remove legacy MachineClass::pci_allow_0_address flag Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241126112212.64524-1-philmd@linaro.org \
    --to=philmd@linaro.org \
    --cc=marcel.apfelbaum@gmail.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=qemu-riscv@nongnu.org \
    --cc=qemu-s390x@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).