From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Gerd Hoffmann" <kraxel@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Benjamin Herrenschmidt" <benh@kernel.crashing.org>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: [PATCH v2 2/2] hw/display/vga: Remove pointless VGACommonState::default_endian_fb
Date: Fri, 29 Nov 2024 11:17:21 +0100 [thread overview]
Message-ID: <20241129101721.17836-3-philmd@linaro.org> (raw)
In-Reply-To: <20241129101721.17836-1-philmd@linaro.org>
'default_endian_fb' value is always target_words_bigendian(),
remove it as it isn't very useful.
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
hw/display/vga_int.h | 1 -
hw/display/vga.c | 5 ++---
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/hw/display/vga_int.h b/hw/display/vga_int.h
index f77c1c11457..5dcdecfd422 100644
--- a/hw/display/vga_int.h
+++ b/hw/display/vga_int.h
@@ -135,7 +135,6 @@ typedef struct VGACommonState {
bool full_update_text;
bool full_update_gfx;
bool big_endian_fb;
- bool default_endian_fb;
bool global_vmstate;
/* hardware mouse cursor support */
uint32_t invalidated_y_table[VGA_MAX_HEIGHT / 32];
diff --git a/hw/display/vga.c b/hw/display/vga.c
index b074b58c90d..6dbbbf49073 100644
--- a/hw/display/vga.c
+++ b/hw/display/vga.c
@@ -2116,7 +2116,7 @@ static bool vga_endian_state_needed(void *opaque)
* default one, thus ensuring backward compatibility for
* migration of the common case
*/
- return s->default_endian_fb != s->big_endian_fb;
+ return s->big_endian_fb != target_words_bigendian();
}
static const VMStateDescription vmstate_vga_endian = {
@@ -2264,8 +2264,7 @@ bool vga_common_init(VGACommonState *s, Object *obj, Error **errp)
* into a device attribute set by the machine/platform to remove
* all target endian dependencies from this file.
*/
- s->default_endian_fb = target_words_bigendian();
- s->big_endian_fb = s->default_endian_fb;
+ s->big_endian_fb = target_words_bigendian();
vga_dirty_log_start(s);
--
2.45.2
prev parent reply other threads:[~2024-11-29 10:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-29 10:17 [PATCH v2 0/2] hw/display/vga: Do not reset 'big_endian_fb' in vga_common_reset() Philippe Mathieu-Daudé
2024-11-29 10:17 ` [PATCH-for-9.2? v2 1/2] " Philippe Mathieu-Daudé
2024-12-02 19:48 ` Philippe Mathieu-Daudé
2024-12-03 1:30 ` Benjamin Herrenschmidt
2024-12-03 10:51 ` Gerd Hoffmann
2024-12-03 12:21 ` BALATON Zoltan
2024-12-05 23:00 ` Benjamin Herrenschmidt
2024-12-06 9:28 ` Gerd Hoffmann
2024-12-09 1:12 ` Benjamin Herrenschmidt
2024-11-29 10:17 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241129101721.17836-3-philmd@linaro.org \
--to=philmd@linaro.org \
--cc=benh@kernel.crashing.org \
--cc=kraxel@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).