qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Pierrick Bouvier" <pierrick.bouvier@linaro.org>,
	"Alistair Francis" <alistair.francis@wdc.com>,
	"Kito Cheng" <kito.cheng@sifive.com>,
	"Richard Henderson" <richard.henderson@linaro.org>,
	"Keith Packard" <keithp@keithp.com>,
	"Daniel Henrique Barboza" <dbarboza@ventanamicro.com>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"Thomas Huth" <thuth@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: [PATCH 5/5] semihosting/meson: Build config.o and console.o once
Date: Fri,  3 Jan 2025 18:10:37 +0100	[thread overview]
Message-ID: <20250103171037.11265-6-philmd@linaro.org> (raw)
In-Reply-To: <20250103171037.11265-1-philmd@linaro.org>

config.c and console.c don't use any target specific
headers anymore, move them from specific_ss[] to
system_ss[] so they are built once, but will also be
linked once, removing global symbol clash in a single
QEMU binary.

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 semihosting/meson.build | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/semihosting/meson.build b/semihosting/meson.build
index 34933e5a195..86f5004bed7 100644
--- a/semihosting/meson.build
+++ b/semihosting/meson.build
@@ -4,13 +4,16 @@ specific_ss.add(when: 'CONFIG_SEMIHOSTING', if_true: files(
 ))
 
 specific_ss.add(when: ['CONFIG_SEMIHOSTING', 'CONFIG_SYSTEM_ONLY'], if_true: files(
-  'config.c',
-  'console.c',
   'uaccess.c',
 ))
 
 common_ss.add(when: ['CONFIG_SEMIHOSTING', 'CONFIG_SYSTEM_ONLY'], if_false: files('stubs-all.c'))
-system_ss.add(when: ['CONFIG_SEMIHOSTING'], if_false: files('stubs-system.c'))
+system_ss.add(when: ['CONFIG_SEMIHOSTING'], if_true: files(
+  'config.c',
+  'console.c',
+), if_false: files(
+  'stubs-system.c',
+))
 
 specific_ss.add(when: ['CONFIG_ARM_COMPATIBLE_SEMIHOSTING'],
 		if_true: files('arm-compat-semi.c'))
-- 
2.47.1



  parent reply	other threads:[~2025-01-03 17:11 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-03 17:10 [PATCH 0/5] semihosting: Reduce target specific code Philippe Mathieu-Daudé
2025-01-03 17:10 ` [PATCH 1/5] semihosting/syscalls: Include missing 'exec/cpu-defs.h' header Philippe Mathieu-Daudé
2025-01-03 17:10 ` [PATCH 2/5] semihosting/uaccess: Include missing 'exec/cpu-all.h' header Philippe Mathieu-Daudé
2025-01-03 17:10 ` [PATCH 3/5] semihosting/arm-compat: Include missing 'cpu.h' header Philippe Mathieu-Daudé
2025-01-03 17:10 ` [PATCH 4/5] semihosting/console: Avoid including 'cpu.h' Philippe Mathieu-Daudé
2025-01-03 17:10 ` Philippe Mathieu-Daudé [this message]
2025-01-06 17:28 ` [PATCH 0/5] semihosting: Reduce target specific code Richard Henderson
2025-01-08 15:26 ` Alex Bennée
2025-01-08 22:53   ` Richard Henderson
2025-01-09 11:12     ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250103171037.11265-6-philmd@linaro.org \
    --to=philmd@linaro.org \
    --cc=alex.bennee@linaro.org \
    --cc=alistair.francis@wdc.com \
    --cc=dbarboza@ventanamicro.com \
    --cc=keithp@keithp.com \
    --cc=kito.cheng@sifive.com \
    --cc=pierrick.bouvier@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).