From: Thomas Huth <thuth@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Stefan Hajnoczi" <stefanha@redhat.com>,
"Ilya Leoshkevich" <iii@linux.ibm.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: [PULL 01/14] tests/tcg/s390x: Use the SLOF libc headers for the multiarch tests
Date: Wed, 8 Jan 2025 09:44:58 +0100 [thread overview]
Message-ID: <20250108084511.238458-2-thuth@redhat.com> (raw)
In-Reply-To: <20250108084511.238458-1-thuth@redhat.com>
From: Ilya Leoshkevich <iii@linux.ibm.com>
Compiling the s390x tests on Fedora, which has the s390x cross-compiler
installed, fails with:
In file included from qemu/tests/tcg/s390x/console.c:8:
qemu/tests/tcg/s390x/../../../pc-bios/s390-ccw/sclp.c:11:10: fatal error: string.h: No such file or directory
11 | #include <string.h>
This is because Fedora does not have a cross-libc. Since console.c
already uses the SLOF libc implementation, add the respective headers
to the include path.
Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-ID: <20241216133819.78583-1-iii@linux.ibm.com>
Tested-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
tests/tcg/s390x/Makefile.softmmu-target | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tests/tcg/s390x/Makefile.softmmu-target b/tests/tcg/s390x/Makefile.softmmu-target
index 969bc5728f..7adde2fa08 100644
--- a/tests/tcg/s390x/Makefile.softmmu-target
+++ b/tests/tcg/s390x/Makefile.softmmu-target
@@ -45,7 +45,8 @@ TESTS += $(ASM_TESTS)
S390X_MULTIARCH_RUNTIME_OBJS = head64.o console.o $(MINILIB_OBJS)
$(MULTIARCH_TESTS): $(S390X_MULTIARCH_RUNTIME_OBJS)
$(MULTIARCH_TESTS): LDFLAGS += $(S390X_MULTIARCH_RUNTIME_OBJS)
-$(MULTIARCH_TESTS): CFLAGS += $(MINILIB_INC)
+$(MULTIARCH_TESTS): CFLAGS += $(MINILIB_INC) \
+ -I$(SRC_PATH)/roms/SLOF/lib/libc/include/
memory: CFLAGS += -DCHECK_UNALIGNED=0
# s390x clears the BSS section so we need to account for that
--
2.47.1
next prev parent reply other threads:[~2025-01-08 8:46 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-08 8:44 [PULL 00/14] Fixes for tests and removal of deprecated features Thomas Huth
2025-01-08 8:44 ` Thomas Huth [this message]
2025-01-08 8:44 ` [PULL 02/14] hw/s390x/s390-virtio-ccw: Remove the deprecated 2.4 and 2.5 machine types Thomas Huth
2025-01-08 8:45 ` [PULL 03/14] hw/s390x/s390-skeys: Remove the "migration-enabled" property Thomas Huth
2025-01-08 8:45 ` [PULL 04/14] hw/s390x/s390-virtio-ccw: Remove the deprecated 2.6 machine type Thomas Huth
2025-01-08 8:45 ` [PULL 05/14] hw/s390x: Remove the "ri_allowed" switch Thomas Huth
2025-01-08 8:45 ` [PULL 06/14] hw/s390x/ipl: Remove the "iplbext_migration" property Thomas Huth
2025-01-08 8:45 ` [PULL 07/14] hw/s390x/css-bridge: Remove the "css_dev_path" property Thomas Huth
2025-01-08 8:45 ` [PULL 08/14] hw/s390x/s390-virtio-ccw: Remove the deprecated 2.7 machine type Thomas Huth
2025-01-08 8:45 ` [PULL 09/14] hw/s390x: Remove the cpu_model_allowed flag and related code Thomas Huth
2025-01-08 8:45 ` [PULL 10/14] hw/s390x/s390-virtio-ccw: Remove the deprecated 2.8 machine type Thomas Huth
2025-01-08 8:45 ` [PULL 11/14] hw/s390x: Remove the "adapter_routes_max_batch" property from the flic Thomas Huth
2025-01-08 8:45 ` [PULL 12/14] Remove the deprecated "-runas" command line option Thomas Huth
2025-01-08 8:45 ` [PULL 13/14] docs/about/deprecated: Remove paragraph about initial deprecation in 2.10 Thomas Huth
2025-01-08 8:45 ` [PULL 14/14] tests/functional/test_x86_64_hotplug_cpu: Fix race condition during unplug Thomas Huth
2025-01-08 19:14 ` [PULL 00/14] Fixes for tests and removal of deprecated features Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250108084511.238458-2-thuth@redhat.com \
--to=thuth@redhat.com \
--cc=iii@linux.ibm.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).