From: David Woodhouse <dwmw2@infradead.org>
To: qemu-devel@nongnu.org, "Roger Pau Monné" <roger.pau@citrix.com>
Cc: "Stefano Stabellini" <sstabellini@kernel.org>,
"Anthony PERARD" <anthony@xenproject.org>,
"Paul Durrant" <paul@xen.org>,
"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
"Kevin Wolf" <kwolf@redhat.com>,
"Hanna Reitz" <hreitz@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Jason Wang" <jasowang@redhat.com>,
xen-devel@lists.xenproject.org, qemu-block@nongnu.org
Subject: [PATCH v3 6/7] hw/xen: Use xs_node_read() from xenstore_read_str() instead of open-coding it
Date: Wed, 15 Jan 2025 16:27:24 +0000 [thread overview]
Message-ID: <20250115163542.291424-7-dwmw2@infradead.org> (raw)
In-Reply-To: <20250115163542.291424-1-dwmw2@infradead.org>
From: David Woodhouse <dwmw@amazon.co.uk>
Signed-off-by: David Woodhouse <dwmw@amazon.co.uk>
Reviewed-by: Anthony PERARD <anthony.perard@vates.tech>
Acked-by: Roger Pau Monné <roger.pau@citrix.com>
---
hw/xen/xen_pvdev.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/hw/xen/xen_pvdev.c b/hw/xen/xen_pvdev.c
index c5ad71e8dc..c9143ba259 100644
--- a/hw/xen/xen_pvdev.c
+++ b/hw/xen/xen_pvdev.c
@@ -22,6 +22,7 @@
#include "qemu/main-loop.h"
#include "hw/qdev-core.h"
#include "hw/xen/xen-legacy-backend.h"
+#include "hw/xen/xen-bus-helper.h"
#include "hw/xen/xen_pvdev.h"
/* private */
@@ -81,12 +82,9 @@ int xenstore_write_str(const char *base, const char *node, const char *val)
char *xenstore_read_str(const char *base, const char *node)
{
- char abspath[XEN_BUFSIZE];
- unsigned int len;
char *str, *ret = NULL;
- snprintf(abspath, sizeof(abspath), "%s/%s", base, node);
- str = qemu_xen_xs_read(xenstore, 0, abspath, &len);
+ str = xs_node_read(xenstore, 0, NULL, NULL, "%s/%s", base, node);
if (str != NULL) {
/* move to qemu-allocated memory to make sure
* callers can safely g_free() stuff. */
--
2.47.0
next prev parent reply other threads:[~2025-01-15 16:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-15 16:27 [PATCH v3 1/7] xen: error handling and FreeBSD compatibility fixes David Woodhouse
2025-01-15 16:27 ` [PATCH v3 1/7] hw/xen: Add xs_node_read() helper function David Woodhouse
2025-01-15 16:44 ` Anthony PERARD
2025-01-15 16:27 ` [PATCH v3 2/7] xen: do not use '%ms' scanf specifier David Woodhouse
2025-01-15 16:45 ` Anthony PERARD
2025-01-15 16:46 ` Andrew Cooper
2025-01-15 16:27 ` [PATCH v3 3/7] hw/xen: Use xs_node_read() from xs_node_vscanf() David Woodhouse
2025-01-15 16:27 ` [PATCH v3 4/7] hw/xen: Use xs_node_read() from xen_console_get_name() David Woodhouse
2025-01-15 16:27 ` [PATCH v3 5/7] hw/xen: Use xs_node_read() from xen_netdev_get_name() David Woodhouse
2025-01-15 16:27 ` David Woodhouse [this message]
2025-01-15 16:27 ` [PATCH v3 7/7] hw/xen: Fix errp handling in xen_console David Woodhouse
2025-01-15 16:49 ` Anthony PERARD
2025-01-15 17:44 ` David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250115163542.291424-7-dwmw2@infradead.org \
--to=dwmw2@infradead.org \
--cc=anthony@xenproject.org \
--cc=edgar.iglesias@gmail.com \
--cc=hreitz@redhat.com \
--cc=jasowang@redhat.com \
--cc=kwolf@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=paul@xen.org \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=roger.pau@citrix.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).