From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org
Cc: qemu-arm@nongnu.org, qemu-s390x@nongnu.org,
qemu-riscv@nongnu.org, qemu-ppc@nongnu.org,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: [PATCH 20/28] target/riscv: Move has_work() from CPUClass to SysemuCPUOps
Date: Tue, 21 Jan 2025 15:23:33 +0100 [thread overview]
Message-ID: <20250121142341.17001-21-philmd@linaro.org> (raw)
In-Reply-To: <20250121142341.17001-1-philmd@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
target/riscv/cpu.h | 9 +++++----
target/riscv/internals.h | 3 ---
target/riscv/cpu.c | 8 +++-----
3 files changed, 8 insertions(+), 12 deletions(-)
diff --git a/target/riscv/cpu.h b/target/riscv/cpu.h
index 97713681cbe..32e8e064f36 100644
--- a/target/riscv/cpu.h
+++ b/target/riscv/cpu.h
@@ -552,10 +552,6 @@ int riscv_cpu_gdb_read_register(CPUState *cpu, GByteArray *buf, int reg);
int riscv_cpu_gdb_write_register(CPUState *cpu, uint8_t *buf, int reg);
int riscv_cpu_hviprio_index2irq(int index, int *out_irq, int *out_rdzero);
uint8_t riscv_cpu_default_priority(int irq);
-uint64_t riscv_cpu_all_pending(CPURISCVState *env);
-int riscv_cpu_mirq_pending(CPURISCVState *env);
-int riscv_cpu_sirq_pending(CPURISCVState *env);
-int riscv_cpu_vsirq_pending(CPURISCVState *env);
bool riscv_cpu_fp_enabled(CPURISCVState *env);
target_ulong riscv_cpu_get_geilen(CPURISCVState *env);
void riscv_cpu_set_geilen(CPURISCVState *env, target_ulong geilen);
@@ -576,6 +572,11 @@ int riscv_cpu_max_xlen(RISCVCPUClass *mcc);
bool riscv_cpu_option_set(const char *optname);
#ifndef CONFIG_USER_ONLY
+bool riscv_cpu_has_work(CPUState *cs);
+uint64_t riscv_cpu_all_pending(CPURISCVState *env);
+int riscv_cpu_mirq_pending(CPURISCVState *env);
+int riscv_cpu_sirq_pending(CPURISCVState *env);
+int riscv_cpu_vsirq_pending(CPURISCVState *env);
void riscv_cpu_do_interrupt(CPUState *cpu);
void riscv_isa_write_fdt(RISCVCPU *cpu, void *fdt, char *nodename);
void riscv_cpu_do_transaction_failed(CPUState *cs, hwaddr physaddr,
diff --git a/target/riscv/internals.h b/target/riscv/internals.h
index 67291933f84..86def39aec2 100644
--- a/target/riscv/internals.h
+++ b/target/riscv/internals.h
@@ -142,9 +142,6 @@ static inline float16 check_nanbox_h(CPURISCVState *env, uint64_t f)
}
}
-/* Our implementation of CPUClass::has_work */
-bool riscv_cpu_has_work(CPUState *cs);
-
/* Zjpm addr masking routine */
static inline target_ulong adjust_addr_body(CPURISCVState *env,
target_ulong addr,
diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c
index 3d4bd157d2c..4a7e02d9a99 100644
--- a/target/riscv/cpu.c
+++ b/target/riscv/cpu.c
@@ -1010,9 +1010,9 @@ static vaddr riscv_cpu_get_pc(CPUState *cs)
return env->pc;
}
+#ifndef CONFIG_USER_ONLY
bool riscv_cpu_has_work(CPUState *cs)
{
-#ifndef CONFIG_USER_ONLY
RISCVCPU *cpu = RISCV_CPU(cs);
CPURISCVState *env = &cpu->env;
/*
@@ -1022,10 +1022,8 @@ bool riscv_cpu_has_work(CPUState *cs)
return riscv_cpu_all_pending(env) != 0 ||
riscv_cpu_sirq_pending(env) != RISCV_EXCP_NONE ||
riscv_cpu_vsirq_pending(env) != RISCV_EXCP_NONE;
-#else
- return true;
-#endif
}
+#endif /* !CONFIG_USER_ONLY */
static int riscv_cpu_mmu_index(CPUState *cs, bool ifetch)
{
@@ -2912,6 +2910,7 @@ static int64_t riscv_get_arch_id(CPUState *cs)
#include "hw/core/sysemu-cpu-ops.h"
static const struct SysemuCPUOps riscv_sysemu_ops = {
+ .has_work = riscv_cpu_has_work,
.get_phys_page_debug = riscv_cpu_get_phys_page_debug,
.write_elf64_note = riscv_cpu_write_elf64_note,
.write_elf32_note = riscv_cpu_write_elf32_note,
@@ -2933,7 +2932,6 @@ static void riscv_cpu_common_class_init(ObjectClass *c, void *data)
&mcc->parent_phases);
cc->class_by_name = riscv_cpu_class_by_name;
- cc->has_work = riscv_cpu_has_work;
cc->mmu_index = riscv_cpu_mmu_index;
cc->dump_state = riscv_cpu_dump_state;
cc->set_pc = riscv_cpu_set_pc;
--
2.47.1
next prev parent reply other threads:[~2025-01-21 14:29 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-21 14:23 [PATCH 00/28] cpus: Restrict CPU has_work() handlers to system emulation Philippe Mathieu-Daudé
2025-01-21 14:23 ` [PATCH 01/28] target/hexagon: Ensure not being build on " Philippe Mathieu-Daudé
2025-01-21 17:39 ` Brian Cain
2025-01-21 14:23 ` [PATCH 02/28] target/rx: Ensure not being build on user emulation Philippe Mathieu-Daudé
2025-01-24 16:51 ` Richard Henderson
2025-01-21 14:23 ` [PATCH 03/28] target/tricore: " Philippe Mathieu-Daudé
2025-01-24 16:51 ` Richard Henderson
2025-01-21 14:23 ` [PATCH 04/28] cpus: Restrict cpu_get_memory_mapping() to system emulation Philippe Mathieu-Daudé
2025-01-24 16:52 ` Richard Henderson
2025-01-21 14:23 ` [PATCH 05/28] cpus: Restrict cpu_has_work() " Philippe Mathieu-Daudé
2025-01-24 16:52 ` Richard Henderson
2025-01-21 14:23 ` [PATCH 06/28] cpus: Un-inline cpu_has_work() Philippe Mathieu-Daudé
2025-01-24 16:59 ` Richard Henderson
2025-01-21 14:23 ` [PATCH 07/28] cpus: Introduce SysemuCPUOps::has_work() handler Philippe Mathieu-Daudé
2025-01-24 17:05 ` Richard Henderson
2025-01-21 14:23 ` [PATCH 08/28] target/alpha: Move has_work() from CPUClass to SysemuCPUOps Philippe Mathieu-Daudé
2025-01-24 17:06 ` Richard Henderson
2025-01-21 14:23 ` [PATCH 09/28] target/arm: " Philippe Mathieu-Daudé
2025-01-24 17:06 ` Richard Henderson
2025-01-21 14:23 ` [PATCH 10/28] target/avr: " Philippe Mathieu-Daudé
2025-01-24 17:06 ` Richard Henderson
2025-01-21 14:23 ` [PATCH 11/28] target/hexagon: Remove CPUClass:has_work() handler Philippe Mathieu-Daudé
2025-01-24 17:07 ` Richard Henderson
2025-01-24 17:26 ` Brian Cain
2025-01-21 14:23 ` [PATCH 12/28] target/hppa: Move has_work() from CPUClass to SysemuCPUOps Philippe Mathieu-Daudé
2025-01-24 17:08 ` Richard Henderson
2025-01-21 14:23 ` [PATCH 13/28] target/i386: " Philippe Mathieu-Daudé
2025-01-24 17:09 ` Richard Henderson
2025-01-21 14:23 ` [PATCH 14/28] target/loongarch: " Philippe Mathieu-Daudé
2025-01-24 17:09 ` Richard Henderson
2025-01-21 14:23 ` [PATCH 15/28] target/m68k: " Philippe Mathieu-Daudé
2025-01-24 17:11 ` Richard Henderson
2025-01-21 14:23 ` [PATCH 16/28] target/microblaze: " Philippe Mathieu-Daudé
2025-01-24 17:11 ` Richard Henderson
2025-01-21 14:23 ` [PATCH 17/28] target/mips: " Philippe Mathieu-Daudé
2025-01-24 17:12 ` Richard Henderson
2025-01-21 14:23 ` [PATCH 18/28] target/openrisc: " Philippe Mathieu-Daudé
2025-01-24 17:13 ` Richard Henderson
2025-01-21 14:23 ` [PATCH 19/28] target/ppc: " Philippe Mathieu-Daudé
2025-01-24 17:14 ` Richard Henderson
2025-01-21 14:23 ` Philippe Mathieu-Daudé [this message]
2025-01-24 17:17 ` [PATCH 20/28] target/riscv: " Richard Henderson
2025-01-24 17:41 ` Philippe Mathieu-Daudé
2025-01-21 14:23 ` [PATCH 21/28] target/rx: " Philippe Mathieu-Daudé
2025-01-24 17:17 ` Richard Henderson
2025-01-21 14:23 ` [PATCH 22/28] target/s390x: Restrict I/O handler installers to system emulation Philippe Mathieu-Daudé
2025-01-24 17:18 ` Richard Henderson
2025-01-21 14:23 ` [PATCH 23/28] target/s390x: Move has_work() from CPUClass to SysemuCPUOps Philippe Mathieu-Daudé
2025-01-24 17:21 ` Richard Henderson
2025-01-21 14:23 ` [PATCH 24/28] target/sh4: " Philippe Mathieu-Daudé
2025-01-24 17:35 ` Richard Henderson
2025-01-21 14:23 ` [PATCH 25/28] target/sparc: " Philippe Mathieu-Daudé
2025-01-24 17:35 ` Richard Henderson
2025-01-21 14:23 ` [PATCH 26/28] target/tricore: " Philippe Mathieu-Daudé
2025-01-24 17:36 ` Richard Henderson
2025-01-21 14:23 ` [PATCH 27/28] target/xtensa: " Philippe Mathieu-Daudé
2025-01-24 17:36 ` Richard Henderson
2025-01-21 14:23 ` [PATCH 28/28] cpus: Remove CPUClass::has_work() handler Philippe Mathieu-Daudé
2025-01-24 17:40 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250121142341.17001-21-philmd@linaro.org \
--to=philmd@linaro.org \
--cc=pbonzini@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).