From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org
Cc: qemu-arm@nongnu.org, qemu-s390x@nongnu.org,
qemu-riscv@nongnu.org, qemu-ppc@nongnu.org,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: [PATCH 02/28] target/rx: Ensure not being build on user emulation
Date: Tue, 21 Jan 2025 15:23:15 +0100 [thread overview]
Message-ID: <20250121142341.17001-3-philmd@linaro.org> (raw)
In-Reply-To: <20250121142341.17001-1-philmd@linaro.org>
Currently only system emulation is supported.
Assert no target code is built for user emulation.
Remove #ifdef'ry since more work is required before
being able to emulate a user process.
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
target/rx/cpu.h | 6 ++++--
target/rx/cpu.c | 6 ------
target/rx/helper.c | 4 ----
3 files changed, 4 insertions(+), 12 deletions(-)
diff --git a/target/rx/cpu.h b/target/rx/cpu.h
index 5ba1874bd76..349d61c4e40 100644
--- a/target/rx/cpu.h
+++ b/target/rx/cpu.h
@@ -26,6 +26,10 @@
#include "exec/cpu-defs.h"
#include "qemu/cpu-float.h"
+#ifdef CONFIG_USER_ONLY
+#error "RX does not support user mode emulation"
+#endif
+
/* PSW define */
REG32(PSW, 0)
FIELD(PSW, C, 0, 1)
@@ -129,11 +133,9 @@ struct RXCPUClass {
#define CPU_RESOLVING_TYPE TYPE_RX_CPU
const char *rx_crname(uint8_t cr);
-#ifndef CONFIG_USER_ONLY
void rx_cpu_do_interrupt(CPUState *cpu);
bool rx_cpu_exec_interrupt(CPUState *cpu, int int_req);
hwaddr rx_cpu_get_phys_page_debug(CPUState *cpu, vaddr addr);
-#endif /* !CONFIG_USER_ONLY */
void rx_cpu_dump_state(CPUState *cpu, FILE *f, int flags);
int rx_cpu_gdb_read_register(CPUState *cpu, GByteArray *buf, int reg);
int rx_cpu_gdb_write_register(CPUState *cpu, uint8_t *buf, int reg);
diff --git a/target/rx/cpu.c b/target/rx/cpu.c
index 8c50c7a1bc8..aa310bd6144 100644
--- a/target/rx/cpu.c
+++ b/target/rx/cpu.c
@@ -184,13 +184,11 @@ static void rx_cpu_init(Object *obj)
qdev_init_gpio_in(DEVICE(cpu), rx_cpu_set_irq, 2);
}
-#ifndef CONFIG_USER_ONLY
#include "hw/core/sysemu-cpu-ops.h"
static const struct SysemuCPUOps rx_sysemu_ops = {
.get_phys_page_debug = rx_cpu_get_phys_page_debug,
};
-#endif
#include "hw/core/tcg-cpu-ops.h"
@@ -201,11 +199,9 @@ static const TCGCPUOps rx_tcg_ops = {
.restore_state_to_opc = rx_restore_state_to_opc,
.tlb_fill = rx_cpu_tlb_fill,
-#ifndef CONFIG_USER_ONLY
.cpu_exec_interrupt = rx_cpu_exec_interrupt,
.cpu_exec_halt = rx_cpu_has_work,
.do_interrupt = rx_cpu_do_interrupt,
-#endif /* !CONFIG_USER_ONLY */
};
static void rx_cpu_class_init(ObjectClass *klass, void *data)
@@ -227,9 +223,7 @@ static void rx_cpu_class_init(ObjectClass *klass, void *data)
cc->set_pc = rx_cpu_set_pc;
cc->get_pc = rx_cpu_get_pc;
-#ifndef CONFIG_USER_ONLY
cc->sysemu_ops = &rx_sysemu_ops;
-#endif
cc->gdb_read_register = rx_cpu_gdb_read_register;
cc->gdb_write_register = rx_cpu_gdb_write_register;
cc->disas_set_info = rx_cpu_disas_set_info;
diff --git a/target/rx/helper.c b/target/rx/helper.c
index 80912e8dcb4..7f28e729891 100644
--- a/target/rx/helper.c
+++ b/target/rx/helper.c
@@ -40,8 +40,6 @@ void rx_cpu_unpack_psw(CPURXState *env, uint32_t psw, int rte)
env->psw_c = FIELD_EX32(psw, PSW, C);
}
-#ifndef CONFIG_USER_ONLY
-
#define INT_FLAGS (CPU_INTERRUPT_HARD | CPU_INTERRUPT_FIR)
void rx_cpu_do_interrupt(CPUState *cs)
{
@@ -146,5 +144,3 @@ hwaddr rx_cpu_get_phys_page_debug(CPUState *cs, vaddr addr)
{
return addr;
}
-
-#endif /* !CONFIG_USER_ONLY */
--
2.47.1
next prev parent reply other threads:[~2025-01-21 14:27 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-21 14:23 [PATCH 00/28] cpus: Restrict CPU has_work() handlers to system emulation Philippe Mathieu-Daudé
2025-01-21 14:23 ` [PATCH 01/28] target/hexagon: Ensure not being build on " Philippe Mathieu-Daudé
2025-01-21 17:39 ` Brian Cain
2025-01-21 14:23 ` Philippe Mathieu-Daudé [this message]
2025-01-24 16:51 ` [PATCH 02/28] target/rx: Ensure not being build on user emulation Richard Henderson
2025-01-21 14:23 ` [PATCH 03/28] target/tricore: " Philippe Mathieu-Daudé
2025-01-24 16:51 ` Richard Henderson
2025-01-21 14:23 ` [PATCH 04/28] cpus: Restrict cpu_get_memory_mapping() to system emulation Philippe Mathieu-Daudé
2025-01-24 16:52 ` Richard Henderson
2025-01-21 14:23 ` [PATCH 05/28] cpus: Restrict cpu_has_work() " Philippe Mathieu-Daudé
2025-01-24 16:52 ` Richard Henderson
2025-01-21 14:23 ` [PATCH 06/28] cpus: Un-inline cpu_has_work() Philippe Mathieu-Daudé
2025-01-24 16:59 ` Richard Henderson
2025-01-21 14:23 ` [PATCH 07/28] cpus: Introduce SysemuCPUOps::has_work() handler Philippe Mathieu-Daudé
2025-01-24 17:05 ` Richard Henderson
2025-01-21 14:23 ` [PATCH 08/28] target/alpha: Move has_work() from CPUClass to SysemuCPUOps Philippe Mathieu-Daudé
2025-01-24 17:06 ` Richard Henderson
2025-01-21 14:23 ` [PATCH 09/28] target/arm: " Philippe Mathieu-Daudé
2025-01-24 17:06 ` Richard Henderson
2025-01-21 14:23 ` [PATCH 10/28] target/avr: " Philippe Mathieu-Daudé
2025-01-24 17:06 ` Richard Henderson
2025-01-21 14:23 ` [PATCH 11/28] target/hexagon: Remove CPUClass:has_work() handler Philippe Mathieu-Daudé
2025-01-24 17:07 ` Richard Henderson
2025-01-24 17:26 ` Brian Cain
2025-01-21 14:23 ` [PATCH 12/28] target/hppa: Move has_work() from CPUClass to SysemuCPUOps Philippe Mathieu-Daudé
2025-01-24 17:08 ` Richard Henderson
2025-01-21 14:23 ` [PATCH 13/28] target/i386: " Philippe Mathieu-Daudé
2025-01-24 17:09 ` Richard Henderson
2025-01-21 14:23 ` [PATCH 14/28] target/loongarch: " Philippe Mathieu-Daudé
2025-01-24 17:09 ` Richard Henderson
2025-01-21 14:23 ` [PATCH 15/28] target/m68k: " Philippe Mathieu-Daudé
2025-01-24 17:11 ` Richard Henderson
2025-01-21 14:23 ` [PATCH 16/28] target/microblaze: " Philippe Mathieu-Daudé
2025-01-24 17:11 ` Richard Henderson
2025-01-21 14:23 ` [PATCH 17/28] target/mips: " Philippe Mathieu-Daudé
2025-01-24 17:12 ` Richard Henderson
2025-01-21 14:23 ` [PATCH 18/28] target/openrisc: " Philippe Mathieu-Daudé
2025-01-24 17:13 ` Richard Henderson
2025-01-21 14:23 ` [PATCH 19/28] target/ppc: " Philippe Mathieu-Daudé
2025-01-24 17:14 ` Richard Henderson
2025-01-21 14:23 ` [PATCH 20/28] target/riscv: " Philippe Mathieu-Daudé
2025-01-24 17:17 ` Richard Henderson
2025-01-24 17:41 ` Philippe Mathieu-Daudé
2025-01-21 14:23 ` [PATCH 21/28] target/rx: " Philippe Mathieu-Daudé
2025-01-24 17:17 ` Richard Henderson
2025-01-21 14:23 ` [PATCH 22/28] target/s390x: Restrict I/O handler installers to system emulation Philippe Mathieu-Daudé
2025-01-24 17:18 ` Richard Henderson
2025-01-21 14:23 ` [PATCH 23/28] target/s390x: Move has_work() from CPUClass to SysemuCPUOps Philippe Mathieu-Daudé
2025-01-24 17:21 ` Richard Henderson
2025-01-21 14:23 ` [PATCH 24/28] target/sh4: " Philippe Mathieu-Daudé
2025-01-24 17:35 ` Richard Henderson
2025-01-21 14:23 ` [PATCH 25/28] target/sparc: " Philippe Mathieu-Daudé
2025-01-24 17:35 ` Richard Henderson
2025-01-21 14:23 ` [PATCH 26/28] target/tricore: " Philippe Mathieu-Daudé
2025-01-24 17:36 ` Richard Henderson
2025-01-21 14:23 ` [PATCH 27/28] target/xtensa: " Philippe Mathieu-Daudé
2025-01-24 17:36 ` Richard Henderson
2025-01-21 14:23 ` [PATCH 28/28] cpus: Remove CPUClass::has_work() handler Philippe Mathieu-Daudé
2025-01-24 17:40 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250121142341.17001-3-philmd@linaro.org \
--to=philmd@linaro.org \
--cc=pbonzini@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).